From 01a57d1eb6440f143bb72fb042148bf084d7668e Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Wed, 18 Oct 2017 14:00:13 -0700 Subject: [PATCH] Call fmtmsg/getdate/getdate_err useless. They're POSIX, and they're implemented in iOS and glibc, but they're not actually used in any codebase I have access to. They're *defined* in several places, and some of those places have a handful of tests, but I couldn't find a single genuine caller. Bug: N/A Test: N/A Change-Id: Id3e2c36183fcff323aa5a2e3a3dabaa8378fae56 --- docs/status.md | 3 --- libc/tools/check-symbols-glibc.py | 6 +++++- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/docs/status.md b/docs/status.md index c11943913..7d2f3b68b 100644 --- a/docs/status.md +++ b/docs/status.md @@ -72,9 +72,6 @@ aio_return aio_suspend aio_write fexecve -fmtmsg -getdate -getdate_err lio_listio pthread_attr_getinheritsched pthread_attr_setinheritsched diff --git a/libc/tools/check-symbols-glibc.py b/libc/tools/check-symbols-glibc.py index 765792505..31a7484e6 100755 --- a/libc/tools/check-symbols-glibc.py +++ b/libc/tools/check-symbols-glibc.py @@ -184,13 +184,17 @@ known = set([ ]) # POSIX has some stuff that's too stupid for words (a64l) or not actually # implemented in glibc unless you count always failing with ENOSYS as -# being implemented (fattach). +# being implemented (fattach). Other stuff (fmtmsg) isn't used in any +# codebase I have access to, internal or external. in_posix_and_glibc_but_dead_or_useless = set([ 'a64l', # obsolete 'confstr', # obsolete 'endutxent', # no utmp on Android 'fattach', # obsolete 'fdetach', # obsolete + 'fmtmsg', # unused + 'getdate', # unused + 'getdate_err', # unused 'gethostid', # obsolete 'getmsg', # obsolete 'getpmsg', # obsolete