tequilaOS/platform_bionic
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Disable signal frame unwinding tests on arm64

Browse source 
The current libunwind.a LLVM prebuilt lacks the special arm64 signal
frame unwinder (https://reviews.llvm.org/D90898), so disable the signal
frame unwinding tests temporarily. (It's not clear who needs this
functionality on Android -- typically crash dumping should use
libunwindstack instead of _Unwind_Backtrace.)

Bug: http://b/153025717
Test: bionic unit tests
Change-Id: I36644dfe4acbedd937768c3aaaad1010099d602c
This commit is contained in:
Ryan Prichard 2021-01-13 20:34:32 -08:00
parent b4fd072976
commit 315969a67e
1 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
tests/stack_unwinding_test.cpp
View file

@ -82,7 +82,7 @@ struct UnwindData {
static UnwindData g_unwind_data; static UnwindData g_unwind_data;
static void noinline UnwindSignalHandler(int) { __attribute__((unused)) static void noinline UnwindSignalHandler(int) {
_Unwind_Backtrace(FrameCounter, &g_unwind_data.handler_frame_count); _Unwind_Backtrace(FrameCounter, &g_unwind_data.handler_frame_count);
g_unwind_data.handler_one_deeper_frame_count = unwind_one_frame_deeper(); g_unwind_data.handler_one_deeper_frame_count = unwind_one_frame_deeper();
@ -98,7 +98,7 @@ static void verify_unwind_data(const UnwindData& unwind_data) {
EXPECT_EQ(unwind_data.handler_frame_count + 1, unwind_data.handler_one_deeper_frame_count); EXPECT_EQ(unwind_data.handler_frame_count + 1, unwind_data.handler_one_deeper_frame_count);
} }
static void noinline UnwindTest() { __attribute__((unused)) static void noinline UnwindTest() {
g_unwind_data = {}; g_unwind_data = {};
_Unwind_Backtrace(FrameCounter, &g_unwind_data.expected_frame_count); _Unwind_Backtrace(FrameCounter, &g_unwind_data.expected_frame_count);
@ -112,14 +112,24 @@ static void noinline UnwindTest() {
} }
TEST(stack_unwinding, unwind_through_signal_frame) { TEST(stack_unwinding, unwind_through_signal_frame) {
#if defined(__aarch64__)
// A newer libunwind.a update should restore signal frame unwinding on arm64.
GTEST_SKIP() << "signal frame unwinding temporarily broken on arm64 -- b/153025717";
#else
ScopedSignalHandler ssh(SIGUSR1, UnwindSignalHandler); ScopedSignalHandler ssh(SIGUSR1, UnwindSignalHandler);
UnwindTest(); UnwindTest();
#endif
} }
// On LP32, the SA_SIGINFO flag gets you __restore_rt instead of __restore. // On LP32, the SA_SIGINFO flag gets you __restore_rt instead of __restore.
TEST(stack_unwinding, unwind_through_signal_frame_SA_SIGINFO) { TEST(stack_unwinding, unwind_through_signal_frame_SA_SIGINFO) {
#if defined(__aarch64__)
// A newer libunwind.a update should restore signal frame unwinding on arm64.
GTEST_SKIP() << "signal frame unwinding temporarily broken on arm64 -- b/153025717";
#else
ScopedSignalHandler ssh(SIGUSR1, UnwindSignalHandler, SA_SIGINFO); ScopedSignalHandler ssh(SIGUSR1, UnwindSignalHandler, SA_SIGINFO);
UnwindTest(); UnwindTest();
#endif
} }