tequilaOS/platform_bionic
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Treat "persist.sys.timezone" as being a Java-format timezone.

Browse source 
POSIX and Java disagree about the sign in a timezone string like "GMT+3".
This means that if you set "persist.sys.timezone" to such a string, native
code and Java code disagree about what time it is. Resolve this by
translating to POSIX form for native code.

Bug: http://b/25463955
Change-Id: I7c08c459dd8514348a12ce419edcbfbfe8f6d327
Test: manually tested with setprop and date.
This commit is contained in:
Elliott Hughes 2016-07-20 17:23:54 -07:00
parent a9fbaee593
commit 3e3f4a51b8
1 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
libc/tzcode/localtime.c
View file

@ -1317,11 +1317,11 @@ tzset_unlocked(void)
{
#if defined(__ANDROID__)
// The TZ environment variable is meant to override the system-wide setting.
const char * name = getenv("TZ");
const char* name = getenv("TZ");
// If that's not set, look at the "persist.sys.timezone" system property.
if (name == NULL) {
static const prop_info *pi;
static const prop_info* pi;
if (!pi) {
pi = __system_property_find("persist.sys.timezone");
@ -1336,12 +1336,21 @@ tzset_unlocked(void)
s = serial;
}
if (ok) {
// POSIX and Java disagree about the sign in a timezone string. For POSIX, "GMT+3" means
// "3 hours west/behind", but for Java it means "3 hours east/ahead". Since (a) Java is
// the one that matches human expectations and (b) this system property is used directly
// by Java, we flip the sign here to translate from Java to POSIX. http://b/25463955.
if (buf[3] == '-') {
buf[3] = '+';
} else if (buf[3] == '+') {
buf[3] = '-';
}
name = buf;
}
}
}
// If that's not available (because you're running AOSP on a WiFi-only
// If the system property is also not available (because you're running AOSP on a WiFi-only
// device, say), fall back to GMT.
if (name == NULL) name = gmt;