tequilaOS/platform_bionic
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

bionic: Do not use magic number for portability

Browse source 
Do not use the magic number 0xFFFFFFFFU to represent the max value of an address
as it's not correct on 64bit platform. We should use UINTPTR_MAX instead.

Change-Id: I1fc6f5864a651b2eddea2333cb0788f9d9223270
Signed-off-by: Qiming Shi <qiming.shi@intel.com>
Signed-off-by: Weiwu Chen <weiwu.chen@intel.com>
This commit is contained in:
Qiming Shi 2014-01-26 16:49:39 +08:00 committed by Elliott Hughes
parent 6f23ce36ce
commit 4041b13c20
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
linker/linker_phdr.cpp
View file

@ -252,8 +252,8 @@ bool ElfReader::ReadProgramHeader() {
size_t phdr_table_get_load_size(const Elf_Phdr* phdr_table, size_t phdr_count,
Elf_Addr* out_min_vaddr,
Elf_Addr* out_max_vaddr) {
Elf_Addr min_vaddr = 0xFFFFFFFFU;
Elf_Addr max_vaddr = 0x00000000U;
Elf_Addr min_vaddr = UINTPTR_MAX;
Elf_Addr max_vaddr = 0;
bool found_pt_load = false;
for (size_t i = 0; i < phdr_count; ++i) {
@ -273,7 +273,7 @@ size_t phdr_table_get_load_size(const Elf_Phdr* phdr_table, size_t phdr_count,
}
}
if (!found_pt_load) {
min_vaddr = 0x00000000U;
min_vaddr = 0;
}
min_vaddr = PAGE_START(min_vaddr);