From 63dd03ccedc316724c40e140067e612932e4420e Mon Sep 17 00:00:00 2001 From: Ben Cheng Date: Tue, 7 May 2013 16:53:33 -0700 Subject: [PATCH] Remove a spurious FIXME and unnecessary type cast. Change-Id: I05dcefdec7f047bef7eef5c5ceb7453992d56c24 --- libc/bionic/debug_stacktrace.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/libc/bionic/debug_stacktrace.cpp b/libc/bionic/debug_stacktrace.cpp index 5e8a40103..fb933e6f9 100644 --- a/libc/bionic/debug_stacktrace.cpp +++ b/libc/bionic/debug_stacktrace.cpp @@ -101,10 +101,7 @@ static _Unwind_Reason_Code trace_function(__unwind_context* context, void* arg) if (ip != 0) { short* ptr = reinterpret_cast(ip); // Thumb BLX(2) - - // FIXME - GCC 4.7 seems to have a bug as without the unnecessary cast to - // short the test will never pass. - if ((*(ptr-1) & 0xff80) == (short) 0x4780) { + if ((*(ptr-1) & 0xff80) == 0x4780) { ip -= 2; } else { ip -= 4;