tequilaOS/platform_bionic
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Align struct passwd definition with other variations of libc

Browse source 
Add pg_gecos ("real name") field to struct passwd.

Bug: 14679430
Bug: 12875898
Change-Id: I833ec2c46f6a6259b7232a8e3f7942968ef0b50d
This commit is contained in:
Calin Juravle 2014-05-09 21:50:53 +01:00
parent 790890fd5c
commit c768874c66
3 changed files with 17 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
libc/bionic/stubs.cpp
View file

@ -89,9 +89,11 @@ static int do_getpw_r(int by_name, const char* name, uid_t uid,
// Copy the strings.
snprintf(buf, byte_count, "%s%c%s%c%s", src->pw_name, 0, src->pw_dir, 0, src->pw_shell);
// pw_passwd is non-POSIX and unused (always NULL) in bionic.
// pw_gecos is non-POSIX and missing in bionic.
// pw_passwd and pw_gecos are non-POSIX and unused (always NULL) in bionic.
dst->pw_passwd = NULL;
#ifdef __LP64__
dst->pw_gecos = NULL;
#endif
// Copy the integral fields.
dst->pw_gid = src->pw_gid;

15
libc/include/pwd.h
View file

@ -100,12 +100,15 @@
struct passwd
{
char* pw_name;
char* pw_passwd;
uid_t pw_uid;
gid_t pw_gid;
char* pw_dir;
char* pw_shell;
char* pw_name;
char* pw_passwd;
uid_t pw_uid;
gid_t pw_gid;
#ifdef __LP64__
char* pw_gecos;
#endif
char* pw_dir;
char* pw_shell;
};
__BEGIN_DECLS

4
tests/stubs_test.cpp
View file

@ -41,6 +41,10 @@ static void check_getpwnam(const char* username, uid_t uid, uid_type_t uid_type)
EXPECT_STREQ(username, pwd->pw_name);
EXPECT_EQ(uid, pwd->pw_uid);
EXPECT_EQ(uid, pwd->pw_gid);
ASSERT_EQ(NULL, pwd->pw_passwd);
#ifdef __LP64__
ASSERT_EQ(NULL, pwd->pw_gecos);
#endif
if (uid_type == TYPE_SYSTEM) {
EXPECT_STREQ("/", pwd->pw_dir);