From 035988ffb4370e5a3844b9ee8058b1766be98d32 Mon Sep 17 00:00:00 2001 From: Christopher Ferris Date: Wed, 15 May 2019 17:06:31 -0700 Subject: [PATCH] Temporarily disable unwind through signal test. On cf_x86_phone-userdebug, both of the unwind through signal tests fail. This has been failing forever, but seems to have suddenly become an issue, so disable while I try to figure out why this is happening. Bug: 132763120 Test: Ran on emulator and verified tests are skipped. Change-Id: Iafc227d972a7783e94c701d73078c9570cea288e Merged-In: Iafc227d972a7783e94c701d73078c9570cea288e (cherry picked from commit d424fafbce4b60f4e5c38981af99c05d07727ed4) (cherry picked from commit fe0fbcff7f70ecd6dc046902385ab06a73320e7c) --- tests/stack_unwinding_test.cpp | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tests/stack_unwinding_test.cpp b/tests/stack_unwinding_test.cpp index 0ff6f30a6..e620ecd09 100644 --- a/tests/stack_unwinding_test.cpp +++ b/tests/stack_unwinding_test.cpp @@ -112,6 +112,10 @@ static void noinline UnwindTest() { } TEST(stack_unwinding, unwind_through_signal_frame) { +#if defined(__i386__) + GTEST_SKIP() << "Temporarily skip test since it fails on x86 see b/132763120."; +#endif + ScopedSignalHandler ssh(SIGUSR1, UnwindSignalHandler); UnwindTest(); @@ -119,6 +123,10 @@ TEST(stack_unwinding, unwind_through_signal_frame) { // On LP32, the SA_SIGINFO flag gets you __restore_rt instead of __restore. TEST(stack_unwinding, unwind_through_signal_frame_SA_SIGINFO) { +#if defined(__i386__) + GTEST_SKIP() << "Temporarily skip test since it fails on x86 see b/132763120."; +#endif + ScopedSignalHandler ssh(SIGUSR1, UnwindSignalHandler, SA_SIGINFO); UnwindTest();