tequilaOS/platform_bionic
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fdtrack: make it clearer that there's more information available.

Browse source 
A lot of people who see these via pitot or whatever don't even think to look at the real tombstone. Make it explicit that this is what they should do next. Also, since we have the numbers, say exactly what we mean by "most common".

Bug: http://b/338882189
Change-Id: Ia21848a40e82cb2486538a7578501e2ec0948e1c
This commit is contained in:
Elliott Hughes 2024-05-30 17:26:25 +00:00
parent a1e51dc4b8
commit e56350c4ad
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
libfdtrack/fdtrack.cpp
View file

@ -281,11 +281,13 @@ static void fdtrack_dump_impl(bool fatal) {
if (!stack) {
async_safe_format_buffer(buf, sizeof(buf),
"aborting due to fd leak: failed to find most common stack");
"aborting due to fd leak: see \"open files\" in the tombstone; "
"no stacks?!");
} else {
char* p = buf;
p += async_safe_format_buffer(buf, sizeof(buf),
"aborting due to fd leak: most common stack =\n");
"aborting due to fd leak: see \"open files\" in the tombstone; "
"most common stack (%zu/%zu) is\n", max, stacks.count);
for (size_t i = 0; i < stack->stack_depth; ++i) {
ssize_t bytes_left = buf + sizeof(buf) - p;