153 commits

Author	SHA1	Message	Date
Elliott Hughes	a4959aa6f8	Reimplement the <ctype.h> is* functions. ... Following on from the towlower()/towupper() changes, add benchmarks for most of <ctype.h>, rewrite the tests to cover the entire defined range for all of these functions, and then reimplement most of the functions. The old table-based implementation is mostly a bad idea on modern hardware, with only ispunct() showing a significant benefit compared to any other way I could think of writing it, and isalnum() a marginal but still convincingly genuine benefit. My new benchmarks make an effort to test an example from each relevant range of characters to avoid, say, accidentally optimizing the behavior of `isalnum('0')` at the expense of `isalnum('z')`. Interestingly, clang is able to generate what I believe to be the optimal implementations from the most readable code, which is impressive. It certainly matched or beat all my attempts to be clever! The BSD table-based implementations made a special case of EOF despite having a `_ctype_` table that's offset by 1 to include EOF at index 0. I'm not sure why they didn't take advantage of that, but removing the explicit check for EOF measurably improves the generated code on arm and arm64, so even the two functions that still use the table benefit from this rewrite. Here are the benchmark results: arm64 before: BM_ctype_isalnum_n 3.73 ns 3.73 ns 183727137 BM_ctype_isalnum_y1 3.82 ns 3.81 ns 186383058 BM_ctype_isalnum_y2 3.73 ns 3.72 ns 187809830 BM_ctype_isalnum_y3 3.78 ns 3.77 ns 181383055 BM_ctype_isalpha_n 3.75 ns 3.75 ns 189453927 BM_ctype_isalpha_y1 3.76 ns 3.75 ns 184854043 BM_ctype_isalpha_y2 4.32 ns 3.78 ns 186326931 BM_ctype_isascii_n 2.49 ns 2.48 ns 275583822 BM_ctype_isascii_y 2.51 ns 2.51 ns 282123915 BM_ctype_isblank_n 3.11 ns 3.10 ns 220472044 BM_ctype_isblank_y1 3.20 ns 3.19 ns 226088868 BM_ctype_isblank_y2 3.11 ns 3.11 ns 220809122 BM_ctype_iscntrl_n 3.79 ns 3.78 ns 188719938 BM_ctype_iscntrl_y1 3.72 ns 3.71 ns 186209237 BM_ctype_iscntrl_y2 3.80 ns 3.80 ns 184315749 BM_ctype_isdigit_n 3.76 ns 3.74 ns 188334682 BM_ctype_isdigit_y 3.78 ns 3.77 ns 186249335 BM_ctype_isgraph_n 3.99 ns 3.98 ns 177814143 BM_ctype_isgraph_y1 3.98 ns 3.95 ns 175140090 BM_ctype_isgraph_y2 4.01 ns 4.00 ns 178320453 BM_ctype_isgraph_y3 3.96 ns 3.95 ns 175412814 BM_ctype_isgraph_y4 4.01 ns 4.00 ns 175711174 BM_ctype_islower_n 3.75 ns 3.74 ns 188604818 BM_ctype_islower_y 3.79 ns 3.78 ns 154738238 BM_ctype_isprint_n 3.96 ns 3.95 ns 177607734 BM_ctype_isprint_y1 3.94 ns 3.93 ns 174877244 BM_ctype_isprint_y2 4.02 ns 4.01 ns 178206135 BM_ctype_isprint_y3 3.94 ns 3.93 ns 175959069 BM_ctype_isprint_y4 4.03 ns 4.02 ns 176158314 BM_ctype_isprint_y5 3.95 ns 3.94 ns 178745462 BM_ctype_ispunct_n 3.78 ns 3.77 ns 184727184 BM_ctype_ispunct_y 3.76 ns 3.75 ns 187947503 BM_ctype_isspace_n 3.74 ns 3.74 ns 185300285 BM_ctype_isspace_y1 3.77 ns 3.76 ns 187202066 BM_ctype_isspace_y2 3.73 ns 3.73 ns 184105959 BM_ctype_isupper_n 3.81 ns 3.80 ns 185038761 BM_ctype_isupper_y 3.71 ns 3.71 ns 185885793 BM_ctype_isxdigit_n 3.79 ns 3.79 ns 184965673 BM_ctype_isxdigit_y1 3.76 ns 3.75 ns 188251672 BM_ctype_isxdigit_y2 3.79 ns 3.78 ns 184187481 BM_ctype_isxdigit_y3 3.77 ns 3.76 ns 187635540 arm64 after: BM_ctype_isalnum_n 3.37 ns 3.37 ns 205613810 BM_ctype_isalnum_y1 3.40 ns 3.39 ns 204806361 BM_ctype_isalnum_y2 3.43 ns 3.43 ns 205066077 BM_ctype_isalnum_y3 3.50 ns 3.50 ns 200057128 BM_ctype_isalpha_n 2.97 ns 2.97 ns 236084076 BM_ctype_isalpha_y1 2.97 ns 2.97 ns 236083626 BM_ctype_isalpha_y2 2.97 ns 2.97 ns 236084246 BM_ctype_isascii_n 2.55 ns 2.55 ns 272879994 BM_ctype_isascii_y 2.46 ns 2.45 ns 286522323 BM_ctype_isblank_n 3.18 ns 3.18 ns 220431175 BM_ctype_isblank_y1 3.18 ns 3.18 ns 220345602 BM_ctype_isblank_y2 3.18 ns 3.18 ns 220308509 BM_ctype_iscntrl_n 3.10 ns 3.10 ns 220344270 BM_ctype_iscntrl_y1 3.10 ns 3.07 ns 228973615 BM_ctype_iscntrl_y2 3.07 ns 3.07 ns 229192626 BM_ctype_isdigit_n 3.07 ns 3.07 ns 228925676 BM_ctype_isdigit_y 3.07 ns 3.07 ns 229182934 BM_ctype_isgraph_n 2.66 ns 2.66 ns 264268737 BM_ctype_isgraph_y1 2.66 ns 2.66 ns 264445277 BM_ctype_isgraph_y2 2.66 ns 2.66 ns 264327427 BM_ctype_isgraph_y3 2.66 ns 2.66 ns 264427480 BM_ctype_isgraph_y4 2.66 ns 2.66 ns 264155250 BM_ctype_islower_n 2.66 ns 2.66 ns 264421600 BM_ctype_islower_y 2.66 ns 2.66 ns 264341148 BM_ctype_isprint_n 2.66 ns 2.66 ns 264415198 BM_ctype_isprint_y1 2.66 ns 2.66 ns 264268793 BM_ctype_isprint_y2 2.66 ns 2.66 ns 264419205 BM_ctype_isprint_y3 2.66 ns 2.66 ns 264205886 BM_ctype_isprint_y4 2.66 ns 2.66 ns 264440797 BM_ctype_isprint_y5 2.72 ns 2.72 ns 264333293 BM_ctype_ispunct_n 3.52 ns 3.51 ns 198956572 BM_ctype_ispunct_y 3.38 ns 3.38 ns 201661792 BM_ctype_isspace_n 3.39 ns 3.39 ns 206896620 BM_ctype_isspace_y1 3.39 ns 3.39 ns 206569020 BM_ctype_isspace_y2 3.39 ns 3.39 ns 206564415 BM_ctype_isupper_n 2.76 ns 2.75 ns 254227134 BM_ctype_isupper_y 2.76 ns 2.75 ns 254235314 BM_ctype_isxdigit_n 3.60 ns 3.60 ns 194418653 BM_ctype_isxdigit_y1 2.97 ns 2.97 ns 236082424 BM_ctype_isxdigit_y2 3.48 ns 3.48 ns 200390011 BM_ctype_isxdigit_y3 3.48 ns 3.48 ns 202255815 arm32 before: BM_ctype_isalnum_n 4.77 ns 4.76 ns 129230464 BM_ctype_isalnum_y1 4.88 ns 4.87 ns 147939321 BM_ctype_isalnum_y2 4.74 ns 4.73 ns 145508054 BM_ctype_isalnum_y3 4.81 ns 4.80 ns 144968914 BM_ctype_isalpha_n 4.80 ns 4.79 ns 148262579 BM_ctype_isalpha_y1 4.74 ns 4.73 ns 145061326 BM_ctype_isalpha_y2 4.83 ns 4.82 ns 147642546 BM_ctype_isascii_n 3.74 ns 3.72 ns 186711139 BM_ctype_isascii_y 3.79 ns 3.78 ns 183654780 BM_ctype_isblank_n 4.20 ns 4.19 ns 169733252 BM_ctype_isblank_y1 4.19 ns 4.18 ns 165713363 BM_ctype_isblank_y2 4.22 ns 4.21 ns 168776265 BM_ctype_iscntrl_n 4.75 ns 4.74 ns 145417484 BM_ctype_iscntrl_y1 4.82 ns 4.81 ns 146283250 BM_ctype_iscntrl_y2 4.79 ns 4.78 ns 148662453 BM_ctype_isdigit_n 4.77 ns 4.76 ns 145789210 BM_ctype_isdigit_y 4.84 ns 4.84 ns 146909458 BM_ctype_isgraph_n 4.72 ns 4.71 ns 145874663 BM_ctype_isgraph_y1 4.86 ns 4.85 ns 142037606 BM_ctype_isgraph_y2 4.79 ns 4.78 ns 145109612 BM_ctype_isgraph_y3 4.75 ns 4.75 ns 144829039 BM_ctype_isgraph_y4 4.86 ns 4.85 ns 146769899 BM_ctype_islower_n 4.76 ns 4.75 ns 147537637 BM_ctype_islower_y 4.79 ns 4.78 ns 145648017 BM_ctype_isprint_n 4.82 ns 4.81 ns 147154780 BM_ctype_isprint_y1 4.76 ns 4.76 ns 145117604 BM_ctype_isprint_y2 4.87 ns 4.86 ns 145801406 BM_ctype_isprint_y3 4.79 ns 4.78 ns 148043446 BM_ctype_isprint_y4 4.77 ns 4.76 ns 145157619 BM_ctype_isprint_y5 4.91 ns 4.90 ns 147810800 BM_ctype_ispunct_n 4.74 ns 4.73 ns 145588611 BM_ctype_ispunct_y 4.82 ns 4.81 ns 144065436 BM_ctype_isspace_n 4.78 ns 4.77 ns 147153712 BM_ctype_isspace_y1 4.73 ns 4.72 ns 145252863 BM_ctype_isspace_y2 4.84 ns 4.83 ns 148615797 BM_ctype_isupper_n 4.75 ns 4.74 ns 148276631 BM_ctype_isupper_y 4.80 ns 4.79 ns 145529893 BM_ctype_isxdigit_n 4.78 ns 4.77 ns 147271646 BM_ctype_isxdigit_y1 4.74 ns 4.74 ns 145142209 BM_ctype_isxdigit_y2 4.83 ns 4.82 ns 146398497 BM_ctype_isxdigit_y3 4.78 ns 4.77 ns 147617686 arm32 after: BM_ctype_isalnum_n 4.35 ns 4.35 ns 161086146 BM_ctype_isalnum_y1 4.36 ns 4.35 ns 160961111 BM_ctype_isalnum_y2 4.36 ns 4.36 ns 160733210 BM_ctype_isalnum_y3 4.35 ns 4.35 ns 160897524 BM_ctype_isalpha_n 3.67 ns 3.67 ns 189377208 BM_ctype_isalpha_y1 3.68 ns 3.67 ns 189438146 BM_ctype_isalpha_y2 3.75 ns 3.69 ns 190971186 BM_ctype_isascii_n 3.69 ns 3.68 ns 191029191 BM_ctype_isascii_y 3.68 ns 3.68 ns 191011817 BM_ctype_isblank_n 4.09 ns 4.09 ns 171887541 BM_ctype_isblank_y1 4.09 ns 4.09 ns 171829345 BM_ctype_isblank_y2 4.08 ns 4.07 ns 170585590 BM_ctype_iscntrl_n 4.08 ns 4.07 ns 170614383 BM_ctype_iscntrl_y1 4.13 ns 4.11 ns 171495899 BM_ctype_iscntrl_y2 4.19 ns 4.18 ns 165255578 BM_ctype_isdigit_n 4.25 ns 4.24 ns 165237008 BM_ctype_isdigit_y 4.24 ns 4.24 ns 165256149 BM_ctype_isgraph_n 3.82 ns 3.81 ns 183610114 BM_ctype_isgraph_y1 3.82 ns 3.81 ns 183614131 BM_ctype_isgraph_y2 3.82 ns 3.81 ns 183616840 BM_ctype_isgraph_y3 3.79 ns 3.79 ns 183620182 BM_ctype_isgraph_y4 3.82 ns 3.81 ns 185740009 BM_ctype_islower_n 3.75 ns 3.74 ns 183619502 BM_ctype_islower_y 3.68 ns 3.68 ns 190999901 BM_ctype_isprint_n 3.69 ns 3.68 ns 190899544 BM_ctype_isprint_y1 3.68 ns 3.67 ns 190192384 BM_ctype_isprint_y2 3.67 ns 3.67 ns 189351466 BM_ctype_isprint_y3 3.67 ns 3.67 ns 189430348 BM_ctype_isprint_y4 3.68 ns 3.68 ns 189430161 BM_ctype_isprint_y5 3.69 ns 3.68 ns 190962419 BM_ctype_ispunct_n 4.14 ns 4.14 ns 171034861 BM_ctype_ispunct_y 4.19 ns 4.19 ns 168308152 BM_ctype_isspace_n 4.50 ns 4.50 ns 156250887 BM_ctype_isspace_y1 4.48 ns 4.48 ns 155124476 BM_ctype_isspace_y2 4.50 ns 4.50 ns 155077504 BM_ctype_isupper_n 3.68 ns 3.68 ns 191020583 BM_ctype_isupper_y 3.68 ns 3.68 ns 191015669 BM_ctype_isxdigit_n 4.50 ns 4.50 ns 156276745 BM_ctype_isxdigit_y1 3.28 ns 3.27 ns 214729725 BM_ctype_isxdigit_y2 4.48 ns 4.48 ns 155265129 BM_ctype_isxdigit_y3 4.48 ns 4.48 ns 155216846 I've also corrected a small mistake in the documentation for isxdigit(). Test: tests and benchmarks Change-Id: I4a77859f826c3fc8f0e327e847886882f29ec4a3	2019-10-08 12:04:09 -07:00
Ryan Prichard	41488b79c4	Merge "Revert "Revert "Add benchmarks that run simple programs"""	2019-09-27 19:59:50 +00:00
Elliott Hughes	9ff7d09643	Add trivial <ctype.h> benchmarks. ... Just to sanity check that toupper/tolower and towupper/towlower are in the same ballpark for the ASCII range. Test: ran benchmarks Change-Id: I1ddc3f4f4478b4075107831f27bf4d4b4a3bc5e8	2019-09-26 21:47:01 -07:00
Ryan Prichard	2c236bc506	Revert "Revert "Add benchmarks that run simple programs"" ... This reverts commit 3bf27c86d1. Disable the 32-bit glibc target. We're not interested in benchmarking that target, and the bench_noop_nostl executable doesn't build when ASAN is turned on, because the libclang_rt.asan_cxx-i386.a lib contains ubsan_type_hash_itanium.cc.o, which needs __dynamic_cast and various STL typeinfo variables. The equivalent libclang_rt.asan_cxx-x86_64.a lib doesn't have ubsan_type_hash_itanium.cc.o in it. Bug: http://b/141693636 Test: m bench_noop_nostl bench_noop bench_noop_static ASAN_OPTIONS=detect_leaks=0 SANITIZE_HOST=address Change-Id: Id6de17e622682f3a166367ad670cba5bfa6aee47	2019-09-26 16:18:37 -07:00
Elliott Hughes	f5b44a5ea6	Merge "benchmarks: remove more boilerplate."	2019-09-26 21:38:52 +00:00
Raman Tenneti	0878ac991a	Merge "Revert "Add benchmarks that run simple programs""	2019-09-26 17:54:33 +00:00
Raman Tenneti	3bf27c86d1	Revert "Add benchmarks that run simple programs" ... This reverts commit aa85ac2b08. Reason for revert: builds are broken - Bug: 141693636 Change-Id: I7502813ae519719c578a05676a0adf9537019bd3	2019-09-26 17:52:48 +00:00
Elliott Hughes	96705e3712	benchmarks: remove more boilerplate. ... Many of our benchmarks are basically just "call one function with a fixed argument". We don't need to keep repeating all the boilerplate for that. This also ensures we don't forget the benchmark::DoNotOptimize, which -- in addition to being a good idea in general -- specifically solves the problem with gettid benchmark and provides a more accurate result by removing the indirection through a function pointer. Test: ran benchmarks Change-Id: Id67535243678cd0d48f51cf25141e2040da9af03	2019-09-26 07:42:23 -07:00
Elliott Hughes	bab9cfd99a	Add trivial towlower/towupper benchmarks. ... Currently 11ns for both ascii and unicode in 64-bit, 15ns for 32-bit. Test: ran benchmarks Change-Id: Ie810b324c855b52b66a96889a194bc5b5b55653f	2019-09-25 22:13:32 -07:00
Ryan Prichard	ef0adb1275	Merge "run-on-host fixes"	2019-09-25 19:48:35 +00:00
Ryan Prichard	aa85ac2b08	Add benchmarks that run simple programs ... Specifically, test the wall-clock time for running: * a C program that does nothing (i.e. no STL) * a C++ program that does nothing * a statically-linked C++ program * toybox true (in /system/bin and /vendor/bin) * mksh -c true (in /system/bin and /vendor/bin) Test: bionic-spawn-benchmarks Change-Id: I961850ec90004cac83088feab5783f4f27768be1	2019-09-25 09:35:43 +00:00
Ryan Prichard	3cfb89d451	run-on-host fixes ... * Fix the path to bionic-benchmarks-glibc * Add symlinks for the toybox symlink commands. Each symlink bypasses the intermediate symlink in ${OUT}/system/bin and points to the final toybox binary. Suppress a bunch of warnings by skipping symlinks for non-existent files. The new spawn benchmarks try to run /system/bin/true. (They also try to run /vendor/bin/true and print an error.) * Quote "$@" * Use soong_ui.bash --dumpvars-mode to set a bunch of variables, rather than get_build_var, which invokes Soong once per variable. This reduces the "build/run-on-host.sh" runtime from 4s to 1.3s. * build/run-on-host.sh isn't executable and is only useful when it's sourced into another shell, so remove its shebang to reduce confusion. Bug: none Test: \ . build/envsetup.sh lunch aosp_x86_64-userdebug . bionic/build/run-on-host.sh prepare MODULES-IN-bionic MODULES-IN-external-toybox /system/bin/true Change-Id: I59e9a6aca77d35b16bdf51759c5fc7e725bfc67c	2019-09-24 15:36:31 -07:00
Elliott Hughes	dfa3231fae	Merge "Fix running tests/benchmarks on the host."	2019-04-27 16:15:21 +00:00
Elliott Hughes	4da99ffe5e	Fix running tests/benchmarks on the host. ... This was broken by all the mainline modules stuff. It's quite a bit hairier to set up now, given that we don't have an apexd on the host. An alternative might be to actually set up a fake /apex that points to the bootstrap directories? Test: ./benchmarks/run-on-host.sh 64 Test: ./tests/run-on-host.sh 64 Change-Id: If2c277ba492c7c443cdf51526ea42f56568e2ea6	2019-04-26 17:45:17 -07:00
Elliott Hughes	d655bc6dfa	Update doc comment about running the benchmarks. ... Test: N/A Change-Id: Idf1f8c38aa90478b861358677e1d12b96809377d	2019-04-23 11:49:13 -07:00
Christopher Ferris	7ec2c8a9b6	Add malloc benchmarks. ... Adding some benchmarks that keep a certain number of allocation around. This benchmark should not be used as an absolute for determining what is a good/bad native allocator. However, it should be used to make sure that numbers are not completely changed between allocator versions. Also update the malloc sql benchmark to match the same style as these new benchmarks. Bug: 129743239 Test: Ran these benchmarks. Change-Id: I1995d98fd269b61d9c96efed6eff3ed278e24c97	2019-04-05 14:45:15 -07:00
Yi Kong	358603a409	Modernise code to use override specifier ... Generated by clang-tidy. Test: m checkbuild Change-Id: I8e23da6b8af31b291be2eefe9937ca222ea8a8c3	2019-03-29 14:27:27 -07:00
Chih-Hung Hsieh	770032ddfa	Fix/suppress bionic google-explicit-constructor warnings ... * Add explicit to conversion constructors/operators Bug: 28341362 Test: make with WITH_TIDY=1 DEFAULT_GLOBAL_TIDY_CHECKS=-*,google-explicit-constructor Change-Id: Id1ad0327c1b8c6f094bcbb3ae599bc1f716b3f2f	2019-01-02 11:04:05 -08:00
Mark Salyzyn	ba1a723ad1	switch to using android-base/file.h instead of android-base/test_utils.h ... Test: compile Bug: 119313545 Change-Id: I664fb32522d01909c603d7b903475c4e9aea9223	2018-11-14 15:46:49 -08:00
Christopher Ferris	9ac0cd5f85	Fix test failures. ... - Fix the help output for new benchmarks help output. - Fix incorrect regex for sanitizing output. Test: Ran unit tests and they pass. Change-Id: I227eef3ce8c4ce639321e5ab8a57d0877063ede1	2018-11-07 14:30:55 -08:00
Christopher Ferris	18cbed7008	Make the test less specific. ... Remove the need to add every benchmark to the list of all benchmarks. Also, add some hard-coding of the location of the benchmark executable. Add a test to make sure the benchmark exists so it's possible to detect if the executable changes location. Finally, make the tests isolated so that they finish in half the time. Test: Ran unit tests. Change-Id: I1e59eb283e31d29b14e54c44ac865827c9704127	2018-10-19 14:05:14 -07:00
Hans Boehm	3e5754c6ad	Add benchmarks for heap size retrieval ... Add benchmarks for mallinfo, and for retrieving RSS from /proc/self/statm, since we're considering using these for GC triggering. Add some static linkage specifiers, after running into a build problem due to a spurious conflict. Bug: 111447610 Test: Ran benchmarks Change-Id: Ie50d512294993882728c63ce51ec507590257d80	2018-10-18 17:56:58 -07:00
Elliott Hughes	efaa60ff6c	Merge "Only use NDK libraries in the benchmarks."	2018-09-25 22:13:09 +00:00
Elliott Hughes	627329915a	Only use NDK libraries in the benchmarks. ... It should be possible to run the benchmarks on any device, including past and future ones, and sticking to NDK libraries ensures that. Bug: N/A Test: `readelf -aW` Change-Id: I15a7a4104fa30263136bc3033d2bd9022cd8ff7b	2018-09-24 16:45:13 -07:00
Christopher Ferris	4fae703029	Touch the memory when doing malloc/free benchmark. ... Also, update the benchmark loop for modern C++. Test: Ran benchmarks. Change-Id: I925446b893793eb8c2c6759716cdd3dbbcf1e7c1	2018-09-20 15:03:49 -07:00
Peter Collingbourne	ed16b344e7	Merge "benchmarks: Fix the benchmark tests."	2018-09-14 02:16:52 +00:00
Peter Collingbourne	62011c27a7	benchmarks: Update the documentation. ... Update the locations of the benchmark binaries to match where they are currently installed.	2018-09-13 16:08:18 -07:00
Peter Collingbourne	c282ca9f44	benchmarks: Fix the benchmark tests. ... Update the list of benchmarks to include the recently added strncmp benchmarks.	2018-09-13 16:06:01 -07:00
Haibo Huang	e466cc0d55	Add benchmark for strncmp ... Test: run benchmark Change-Id: Id99d81fe4d2a72a7f22414c7eea3ef3d873022ab	2018-08-21 21:04:43 +00:00
Christopher Ferris	0dc784431b	Add new malloc benchmarks. ... This runs through the trace of the allocations in a sql benchmark app executed in the benchmark thread. Add one benchmark with decay time set to 0 and another with decay time set to 1. Include a script that can generate a header file that can be used to regenerate the data. Bug: 112317428 Test: Builds, ran unit tests, ran benchmarks. Change-Id: I62e287cc06b74b74bcc5a4bbee71b0fac0a196fd	2018-08-14 16:01:58 -07:00
Haibo Huang	510dda3ea1	Fix benchmark-tests ... 1. fix all_benchmarks. Some new benchmarks were added. 2. move some benchmark suites to the right place. 3. add unit test for https://android-review.googlesource.com/c/platform/bionic/+/724785 Test: compile and run bionic-benchmarks-tests on device. Change-Id: I2b686b51910a422b664f9ea968199f37944039c0	2018-08-11 23:43:03 -07:00
Adhemerval Zanella	43f2b77c8b	Add new strcmp/strncmp benchmark ... This patch adds a new strcmp/strcmp benchmark with different set of inputs. It cover all pre-defined range values (small, medium, large) for aligned inputs and also small range for unaligned ones. Test: Ran new string test suite with a single bionic iteration. Change-Id: Ice78d74c3583a33158eaba3309c10df54044aa28	2018-08-11 07:20:53 +00:00
Adhemerval Zanella	0e4fd755a0	Add new memcmp benchmark ... This patch adds a new memcmp benchmark with different set of inputs. It covers all pre-defined range values (small, medium, large) for aligned inputs and also medium range for unaligned ones. Test: Ran new string test suite with a single bionic iteration. Change-Id: Icdb95220a62d46bd71fa6ffbbf4567a9a05b7685	2018-08-11 07:20:13 +00:00
Adhemerval Zanella	eda94aa1ae	Add option to define ranges sets for benchmarks ... This patch add an option to use the pre-define set of ranges along with macros AT_ONEBUF_MANUAL_ALIGN_* and AT_TWOBUF_MANUAL_ALIGN1_*. The size argument can be either a number or a string representing the sets of values: * SMALL for values between 1 and 256. * MEDIUM for values between 512 and 128KB. * LARGE for values between 256KB and 2048KB. Test: Ran new string test suite with a single bionic iteration. Change-Id: Ieda81ee9a5019991b0b2f97d4ca3a237127c5848	2018-08-11 00:27:27 +00:00
Adhemerval Zanella	72fe1c8df6	Add pow benchmark ... As for exp/exp2 benchmark, this patch add two benchmark for pow: one which measures thoughput and one which measures latency. The input data is the same as powf. Test: ran 32-bit and 64-bit x86 tests on host Change-Id: I04335fac9e76fb3f39935323dacf6b7be6a6f917	2018-08-08 18:04:48 -03:00
Adhemerval Zanella	56f4511c39	Add log and log2 benchmark ... Similar to exp/exp2, this patch add two benchmarks for log and log2: one which measures thoughput and one which measures latency. The input data is based on logf/log2f one (reduced trace based on 2.8 billion samples extracted from specpu2017 521.wrf_r benchmark). Test: ran 32-bit and 64-bit x86 tests on host Change-Id: I51a9e2960e45d5619585e685eaa7634cc7be901b	2018-08-08 18:04:48 -03:00
Adhemerval Zanella	10d330af34	Add exp and exp2 benchmark ... This patch add two benchmarks for both exp and exp2, one which measures thoughput and one which measures latency. The latency benchmark works by creating a dependency on the previous iteration and with a zero multiply to avoid changing the input value. The input is based on expf/exp2f benchmark (reduced trace based on 2.4 billion samples extracted from specpu2017 521.wrf_r benchmark). Test: ran 32-bit and 64-bit x86 tests on host	2018-08-08 15:06:09 -03:00
Yi Kong	32bc0fcf69	Modernize codebase by replacing NULL with nullptr ... Fixes -Wzero-as-null-pointer-constant warning. Test: m Bug: 68236239 Change-Id: I5b4123bc6709641315120a191e36cc57541349b2	2018-08-02 18:09:44 -07:00
Haibo Huang	d5ee4c5fb7	Change args to int64_t ... The new benchmark framework uses int64_t for args. Related benchmark change: 9913418d32 (diff-b9f55422dc0bd52759c6aaa25c305bb0R757) Upgrade benchmark framework: https://android-review.googlesource.com/c/platform/external/google-benchmark/+/714118 Test: compile and run bionic benchmark Change-Id: I1b81c853c28abbead1816bf0be7a20a35e036619	2018-07-07 04:14:22 +00:00
Adhemerval Zanella	7871ca1075	Add sinf/cosf/sincosf benchmark ... Similar to expf/exp2f, this patch add two benchmarks for sinf, cosf, and sincosf: one which measures thoughput as default and one which measures latency. The input in 512 random value divided in 8 ranges: 1. 0.0 <= x < 0.1 2. 0.1 <= x < 0.7 3. 0.7 <= x < 3.1 4. -3.1 <= x < 3.1 5. 3.3 <= x < 33.3 6. 100.0 <= x < 1000.0 7. 1e6 <= x < 1e32 8. 1e32 < x < FLT_MAX Test: ran 32-bit and 64-bit x86 tests on host Change-Id: I92bc2f1fac911c573c5122911d08ca590311578a	2018-06-19 11:34:54 -03:00
Adhemerval Zanella	ff5a353112	Add logf and log2f benchmark ... Similar to expf/exp2f, this patch add two benchmarks for logf and log2f: one which measures thoughput and one which measures latency. The input data is based on a reduced trace based on 2.8 billion samples extracted from specpu2017 521.wrf_r benchmark. Test: ran 32-bit and 64-bit x86 tests on host Change-Id: If4fbd7eb3d40f8e155935149a82f162b222d5506	2018-06-19 11:34:54 -03:00
Adhemerval Zanella	872c8b5133	Add powf benchmark ... As for expf/exp2f benchmark, this patch add two benchmark for powf: one which measures thoughput and one which measures latency. The input data is based on a reduced trace from 2.3 billion samples extracted from specpu2017 521.wrf_r benchmark. Test: ran 32-bit and 64-bit x86 tests on host Change-Id: Id8943d90dd5452146e55fb75708daaf7bf0e25fa	2018-06-19 11:34:54 -03:00
Adhemerval Zanella	357f6c1b47	Add expf and exp2f benchmark ... This patch add two benchmarks for both expf and exp2f, one which measures thoughput, as default, and one which measures latency. The latency benchmark works by creating a dependency on the previous iteration and with a zero multiply to avoid changing the input value. The input is based on a reduced trace based on 2.4 billion samples extracted from specpu2017 521.wrf_r benchmark. Test: ran 32-bit and 64-bit x86 tests on host Change-Id: Ic0d40cc4977dd6875fb7431146fc38ea0e6e0bc2	2018-06-19 11:34:54 -03:00
Elliott Hughes	e332f658e0	Switch to FreeBSD's actual sincos. ... Before: BM_math_sin_fast 48 ns 48 ns 14693053 BM_math_sincos 61 ns 61 ns 11470219 After: BM_math_sin_fast 48 ns 48 ns 14725120 BM_math_sincos 43 ns 43 ns 16329843 Bug: N/A Test: ran tests, benchmarks Change-Id: I8693c64135233c0641af5302c38748f47ac76737	2018-05-09 12:25:12 -07:00
Christopher Ferris	bfb7c761d4	Fix bug in --bionic_cpu option handling. ... Make sure that all the variables are properly initialized. Remove the code that verifies the core to enable using get_schedaffinity since that make it impossible to change the cpu for different tests. Change the cpu_to_lock to an int, it really didn't need to be a long. Fix a few missing tests. Test: Ran unit tests. Test: Built the tests and ran on different cpus, verifying that the Test: chosen cpu was correct. Test: Created an xml file that had different cpus for different tests Test: and verified that it locked to each cpu properly. Change-Id: Ie7b4ad8f306f13d6e968d118e71bb5dc0221552a	2018-05-04 17:34:35 -07:00
Tom Cherry	ee8e3dd67c	Remove non-trivial constructors/destructors from SystemProperties ... With the goal of disallowing exit time destructors, SystemProperties's non-trivial destructor needs to be removed. This means replacing the union hack with yet another hack as we don't want to allocate anything despite relying on some polymorphism. Bug: 73485611 Test: boot bullhead Change-Id: I64223714c9b26c9724bfb8f3e2b0168e47b56bc8	2018-02-21 15:10:17 -08:00
Elliott Hughes	cbc80ba9d8	Switch the rest of our internal headers to #pragma once. ... We've been using #pragma once for new internal files, but let's be more bold. Bug: N/A Test: builds Change-Id: I7e2ee2730043bd884f9571cdbd8b524043030c07	2018-02-13 14:27:17 -08:00
Elliott Hughes	d50a1de565	Run bpfmt manually. ... Bug: N/A Test: builds Change-Id: I0cf145c3b699ac8ef170a63366832f63a9cc1a91	2018-02-05 17:30:57 -08:00
Yabin Cui	5a00ba7c1c	Support priority inheritance mutex in 32-bit programs. ... Add fast path calling PIMutexTryLock() in pthread_mutex_lock. Add trace for pi mutex waiting. Bug: http://b/29177606 Test: run bionic-unit-tests. Test: run bionic-benchmarks. Change-Id: I30b6436692d5ea6b63ca9905df745edb843b5528	2018-02-01 16:01:46 -08:00
Yabin Cui	6b9c85b36d	Support priority inheritance mutex in 64bit programs. ... Bug: http://b/29177606 Test: run bionic-unit-tests on walleye. Test: run bionic-unit-tests-glibc on host. Change-Id: Iac349284aa73515f384e7509445f87434757f59e	2018-01-24 16:11:07 -08:00