2c4ec7e109
readlink does not append a terminator, and a few tests assumed it did. Test: Unit tests pass. Change-Id: I3ccea4e7895cd919b45e1ca0c90aa6f0031de320
117 lines
3.6 KiB
C++
117 lines
3.6 KiB
C++
/*
|
|
* Copyright (C) 2015 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#include <gtest/gtest.h>
|
|
#include <pthread.h>
|
|
#include <fcntl.h>
|
|
#include <unistd.h>
|
|
#include <sys/types.h>
|
|
#include <sys/stat.h>
|
|
#include <sys/prctl.h>
|
|
|
|
#include <string>
|
|
|
|
#include <android-base/scopeguard.h>
|
|
|
|
extern "C" pid_t gettid();
|
|
|
|
static void ProcSelfReadlinkBody() {
|
|
char buf[100];
|
|
char buf2[1024];
|
|
int fd = open("/dev/null", O_RDWR | O_CLOEXEC);
|
|
ASSERT_NE(-1, fd);
|
|
snprintf(buf, sizeof(buf), "/proc/self/fd/%d", fd);
|
|
const char* ERRORMSG = "Please apply the following two kernel patches:\n"
|
|
"* https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=73af963f9f3036dffed55c3a2898598186db1045\n"
|
|
"* https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=96d0df79f2644fc823f26c06491e182d87a90c2a\n";
|
|
ssize_t length = readlink(buf, buf2, sizeof(buf2));
|
|
ASSERT_LT(0, length) << ERRORMSG;
|
|
ASSERT_EQ("/dev/null", std::string(buf2, length));
|
|
close(fd);
|
|
}
|
|
|
|
static void* ProcSelfReadlink(void*) {
|
|
ProcSelfReadlinkBody();
|
|
return nullptr;
|
|
}
|
|
|
|
TEST(bug_26110743, ProcSelfReadlink) {
|
|
pthread_t t;
|
|
ASSERT_EQ(0, pthread_create(&t, nullptr, ProcSelfReadlink, nullptr));
|
|
void* result;
|
|
ASSERT_EQ(0, pthread_join(t, &result));
|
|
ASSERT_EQ(nullptr, result);
|
|
}
|
|
|
|
TEST(bug_26110743, ProcSelfReadlink_NotDumpable) {
|
|
int dumpable = prctl(PR_GET_DUMPABLE, 0, 0, 0, 0);
|
|
prctl(PR_SET_DUMPABLE, 0, 0, 0, 0);
|
|
auto guard = android::base::make_scope_guard([&]() {
|
|
// restore dumpable
|
|
prctl(PR_SET_DUMPABLE, dumpable, 0, 0, 0);
|
|
});
|
|
|
|
pthread_t t;
|
|
ASSERT_EQ(0, pthread_create(&t, nullptr, ProcSelfReadlink, nullptr));
|
|
void* result;
|
|
ASSERT_EQ(0, pthread_join(t, &result));
|
|
ASSERT_EQ(nullptr, result);
|
|
}
|
|
|
|
static void ProcTaskFdReadlinkBody() {
|
|
char buf[200];
|
|
char buf2[1024];
|
|
int fd = open("/dev/null", O_RDWR | O_CLOEXEC);
|
|
ASSERT_NE(-1, fd);
|
|
pid_t mypid = getpid();
|
|
pid_t mytid = gettid();
|
|
ASSERT_NE(mypid, mytid);
|
|
snprintf(buf, sizeof(buf), "/proc/%d/task/%d/fd/%d", mypid, mytid, fd);
|
|
const char* ERRORMSG = "Please apply the following kernel patch:\n"
|
|
"* https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=54708d2858e79a2bdda10bf8a20c80eb96c20613\n";
|
|
ssize_t length = readlink(buf, buf2, sizeof(buf2));
|
|
ASSERT_LT(0, length) << ERRORMSG;
|
|
ASSERT_EQ("/dev/null", std::string(buf2, length));
|
|
close(fd);
|
|
}
|
|
|
|
static void* ProcTaskFdReadlink(void*) {
|
|
ProcTaskFdReadlinkBody();
|
|
return nullptr;
|
|
}
|
|
|
|
TEST(bug_26110743, ProcTaskFdReadlink) {
|
|
pthread_t t;
|
|
ASSERT_EQ(0, pthread_create(&t, nullptr, ProcTaskFdReadlink, nullptr));
|
|
void* result;
|
|
ASSERT_EQ(0, pthread_join(t, &result));
|
|
ASSERT_EQ(nullptr, result);
|
|
}
|
|
|
|
TEST(bug_26110743, ProcTaskFdReadlink_NotDumpable) {
|
|
int dumpable = prctl(PR_GET_DUMPABLE, 0, 0, 0, 0);
|
|
prctl(PR_SET_DUMPABLE, 0, 0, 0, 0);
|
|
auto guard = android::base::make_scope_guard([&]() {
|
|
// restore dumpable
|
|
prctl(PR_SET_DUMPABLE, dumpable, 0, 0, 0);
|
|
});
|
|
|
|
pthread_t t;
|
|
ASSERT_EQ(0, pthread_create(&t, nullptr, ProcTaskFdReadlink, nullptr));
|
|
void* result;
|
|
ASSERT_EQ(0, pthread_join(t, &result));
|
|
ASSERT_EQ(nullptr, result);
|
|
}
|