0fec6b9d88
__atomic_cmpxchg and other related atomic operations did not provide memory barriers, which can be a problem for non-platform code that links against them when it runs on multi-core devices. This patch does two things to fix this: - It modifies the existing implementation of the functions that are exported by the C library to always provide full memory barriers. We need to keep them exported by the C library to prevent breaking existing application machine code. - It also modifies <sys/atomics.h> to only export always-inlined versions of the functions, to ensure that any application code compiled against the new header will not rely on the platform version of the functions. This ensure that said machine code will run properly on all multi-core devices. This is based on the GCC built-in sync primitives. The end result should be only slightly slower than the previous implementation. Note that the platform code does not use these functions at all. A previous patch completely removed their usage in the pthread and libstdc++ code. + rename arch-arm/bionic/atomics_arm.S to futex_arm.S + rename arch-x86/bionic/atomics_x86.S to futex_x86.S + remove arch-x86/include/sys/atomics.h which already provided inlined functions to the x86 platform. Change-Id: I752a594475090cf37fa926bb38209c2175dda539 |
||
---|---|---|
.. | ||
arch-arm | ||
arch-sh | ||
arch-x86 | ||
bionic | ||
docs | ||
include | ||
inet | ||
kernel | ||
netbsd | ||
private | ||
regex | ||
stdio | ||
stdlib | ||
string | ||
tools | ||
tzcode | ||
unistd | ||
wchar | ||
zoneinfo | ||
Android.mk | ||
CAVEATS | ||
Jamfile | ||
MODULE_LICENSE_BSD | ||
NOTICE | ||
README | ||
SYSCALLS.TXT |
Welcome to Bionic, Android's small and custom C library for the Android platform. Bionic is mainly a port of the BSD C library to our Linux kernel with the following additions/changes: - no support for locales - no support for wide chars (i.e. multi-byte characters) - its own smallish implementation of pthreads based on Linux futexes - support for x86, ARM and ARM thumb CPU instruction sets and kernel interfaces Bionic is released under the standard 3-clause BSD License Bionic doesn't want to implement all features of a traditional C library, we only add features to it as we need them, and we try to keep things as simple and small as possible. Our goal is not to support scaling to thousands of concurrent threads on multi-processors machines; we're running this on cell-phones, damnit !! Note that Bionic doesn't provide a libthread_db or a libm implementation. Adding new syscalls: ==================== Bionic provides the gensyscalls.py Python script to automatically generate syscall stubs from the list defined in the file SYSCALLS.TXT. You can thus add a new syscall by doing the following: - edit SYSCALLS.TXT - add a new line describing your syscall, it should look like: return_type syscall_name(parameters) syscall_number - in the event where you want to differentiate the syscall function from its entry name, use the alternate: return_type funcname:syscall_name(parameters) syscall_number - additionally, if the syscall number is different between ARM and x86, use: return_type funcname[:syscall_name](parameters) arm_number,x86_number - a syscall number can be -1 to indicate that the syscall is not implemented on a given platform, for example: void __set_tls(void*) arm_number,-1 the comments in SYSCALLS.TXT contain more information about the line format You can also use the 'checksyscalls.py' script to check that all the syscall numbers you entered are correct. It does so by looking at the values defined in your Linux kernel headers. The script indicates where the values are incorrect and what is expected instead.