platform_bionic/tests/sys_vfs_test.cpp
Elliott Hughes 95646e6666 Add ASSERT_ERRNO and EXPECT_ERRNO (and use them).
We've talked about this many times in the past, but partners struggle to
understand "expected 38, got 22" in these contexts, and I always have to
go and check the header files just to be sure I'm sure.

I actually think the glibc geterrorname_np() function (which would
return "ENOSYS" rather than "Function not implemented") would be more
helpful, but I'll have to go and implement that first, and then come
back.

Being forced to go through all our errno assertions did also make me
want to use a more consistent style for our ENOSYS assertions in
particular --- there's a particularly readable idiom, and I'll also come
back and move more of those checks to the most readable idiom.

I've added a few missing `errno = 0`s before tests, and removed a few
stray `errno = 0`s from tests that don't actually make assertions about
errno, since I had to look at every single reference to errno anyway.

Test: treehugger
Change-Id: Iba7c56f2adc30288c3e00ade106635e515e88179
2023-09-21 14:15:59 -07:00

97 lines
2.3 KiB
C++

/*
* Copyright (C) 2014 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include <gtest/gtest.h>
#include <sys/vfs.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <string>
#include "utils.h"
template <typename StatFsT> void Check(StatFsT& sb) {
EXPECT_EQ(4096, static_cast<int>(sb.f_bsize));
EXPECT_EQ(0U, sb.f_bfree);
EXPECT_EQ(0U, sb.f_ffree);
EXPECT_EQ(0, sb.f_fsid.__val[0]);
EXPECT_EQ(0, sb.f_fsid.__val[1]);
EXPECT_EQ(255, static_cast<int>(sb.f_namelen));
// The kernel sets a private bit to indicate that f_flags is valid.
// This flag is not supposed to be exposed to libc clients.
static const uint32_t ST_VALID = 0x0020;
EXPECT_TRUE((sb.f_flags & ST_VALID) == 0) << sb.f_flags;
}
TEST(sys_vfs, statfs) {
struct statfs sb;
ASSERT_EQ(0, statfs("/proc", &sb));
Check(sb);
}
TEST(sys_vfs, statfs_failure) {
struct statfs sb;
errno = 0;
ASSERT_EQ(-1, statfs("/does-not-exist", &sb));
ASSERT_ERRNO(ENOENT);
}
TEST(sys_vfs, statfs64_smoke) {
struct statfs64 sb;
ASSERT_EQ(0, statfs64("/proc", &sb));
Check(sb);
}
TEST(sys_vfs, statfs64_failure) {
struct statfs64 sb;
errno = 0;
ASSERT_EQ(-1, statfs64("/does-not-exist", &sb));
ASSERT_ERRNO(ENOENT);
}
TEST(sys_vfs, fstatfs) {
struct statfs sb;
int fd = open("/proc", O_RDONLY);
ASSERT_EQ(0, fstatfs(fd, &sb));
close(fd);
Check(sb);
}
TEST(sys_vfs, fstatfs_failure) {
struct statfs sb;
errno = 0;
ASSERT_EQ(-1, fstatfs(-1, &sb));
ASSERT_ERRNO(EBADF);
}
TEST(sys_vfs, fstatfs64_smoke) {
struct statfs64 sb;
int fd = open("/proc", O_RDONLY);
ASSERT_EQ(0, fstatfs64(fd, &sb));
close(fd);
Check(sb);
}
TEST(sys_vfs, fstatfs64_failure) {
struct statfs sb;
errno = 0;
ASSERT_EQ(-1, fstatfs(-1, &sb));
ASSERT_ERRNO(EBADF);
}