cbd85b9cc1
It turns out that when passing a closed file to getdelim or getline, the functions in glibc will properly return a failure, but errno might not be set. Skip the errno check except on bionic. Change-Id: I8d625f15303d4c2d42e8d28491ea8a368aea4d32
370 lines
9.4 KiB
C++
370 lines
9.4 KiB
C++
/*
|
|
* Copyright (C) 2012 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#include <gtest/gtest.h>
|
|
|
|
#include <errno.h>
|
|
#include <limits.h>
|
|
#include <stdio.h>
|
|
#include <sys/types.h>
|
|
#include <sys/stat.h>
|
|
#include <unistd.h>
|
|
|
|
TEST(stdio, tmpfile_fileno_fprintf_rewind_fgets) {
|
|
FILE* fp = tmpfile();
|
|
ASSERT_TRUE(fp != NULL);
|
|
|
|
int fd = fileno(fp);
|
|
ASSERT_NE(fd, -1);
|
|
|
|
struct stat sb;
|
|
int rc = fstat(fd, &sb);
|
|
ASSERT_NE(rc, -1);
|
|
ASSERT_EQ(sb.st_mode & 0777, 0600U);
|
|
|
|
rc = fprintf(fp, "hello\n");
|
|
ASSERT_EQ(rc, 6);
|
|
|
|
rewind(fp);
|
|
|
|
char buf[16];
|
|
char* s = fgets(buf, sizeof(buf), fp);
|
|
ASSERT_TRUE(s != NULL);
|
|
ASSERT_STREQ("hello\n", s);
|
|
|
|
fclose(fp);
|
|
}
|
|
|
|
TEST(stdio, getdelim) {
|
|
FILE* fp = tmpfile();
|
|
ASSERT_TRUE(fp != NULL);
|
|
|
|
const char* line_written = "This is a test";
|
|
int rc = fprintf(fp, "%s", line_written);
|
|
ASSERT_EQ(rc, static_cast<int>(strlen(line_written)));
|
|
|
|
rewind(fp);
|
|
|
|
char* word_read = NULL;
|
|
size_t allocated_length = 0;
|
|
|
|
const char* expected[] = { "This ", " ", "is ", "a ", "test" };
|
|
for (size_t i = 0; i < 5; ++i) {
|
|
ASSERT_FALSE(feof(fp));
|
|
ASSERT_EQ(getdelim(&word_read, &allocated_length, ' ', fp), static_cast<int>(strlen(expected[i])));
|
|
ASSERT_GE(allocated_length, strlen(expected[i]));
|
|
ASSERT_STREQ(word_read, expected[i]);
|
|
}
|
|
// The last read should have set the end-of-file indicator for the stream.
|
|
ASSERT_TRUE(feof(fp));
|
|
clearerr(fp);
|
|
|
|
// getdelim returns -1 but doesn't set errno if we're already at EOF.
|
|
// It should set the end-of-file indicator for the stream, though.
|
|
errno = 0;
|
|
ASSERT_EQ(getdelim(&word_read, &allocated_length, ' ', fp), -1);
|
|
ASSERT_EQ(0, errno);
|
|
ASSERT_TRUE(feof(fp));
|
|
|
|
free(word_read);
|
|
fclose(fp);
|
|
}
|
|
|
|
TEST(stdio, getdelim_invalid) {
|
|
FILE* fp = tmpfile();
|
|
|
|
char* buffer = NULL;
|
|
size_t buffer_length = 0;
|
|
|
|
// The first argument can't be NULL.
|
|
errno = 0;
|
|
ASSERT_EQ(getdelim(NULL, &buffer_length, ' ', fp), -1);
|
|
ASSERT_EQ(EINVAL, errno);
|
|
|
|
// The second argument can't be NULL.
|
|
errno = 0;
|
|
ASSERT_EQ(getdelim(&buffer, NULL, ' ', fp), -1);
|
|
ASSERT_EQ(EINVAL, errno);
|
|
|
|
// The stream can't be closed.
|
|
fclose(fp);
|
|
errno = 0;
|
|
ASSERT_EQ(getdelim(&buffer, &buffer_length, ' ', fp), -1);
|
|
// glibc sometimes doesn't set errno in this particular case.
|
|
#if defined(__BIONIC__)
|
|
ASSERT_EQ(EBADF, errno);
|
|
#endif
|
|
}
|
|
|
|
TEST(stdio, getline) {
|
|
FILE* fp = tmpfile();
|
|
ASSERT_TRUE(fp != NULL);
|
|
|
|
const char* line_written = "This is a test for getline\n";
|
|
const size_t line_count = 5;
|
|
|
|
for (size_t i = 0; i < line_count; ++i) {
|
|
int rc = fprintf(fp, "%s", line_written);
|
|
ASSERT_EQ(rc, static_cast<int>(strlen(line_written)));
|
|
}
|
|
|
|
rewind(fp);
|
|
|
|
char* line_read = NULL;
|
|
size_t allocated_length = 0;
|
|
|
|
size_t read_line_count = 0;
|
|
ssize_t read_char_count;
|
|
while ((read_char_count = getline(&line_read, &allocated_length, fp)) != -1) {
|
|
ASSERT_EQ(read_char_count, static_cast<int>(strlen(line_written)));
|
|
ASSERT_GE(allocated_length, strlen(line_written));
|
|
ASSERT_STREQ(line_read, line_written);
|
|
++read_line_count;
|
|
}
|
|
ASSERT_EQ(read_line_count, line_count);
|
|
|
|
// The last read should have set the end-of-file indicator for the stream.
|
|
ASSERT_TRUE(feof(fp));
|
|
clearerr(fp);
|
|
|
|
// getline returns -1 but doesn't set errno if we're already at EOF.
|
|
// It should set the end-of-file indicator for the stream, though.
|
|
errno = 0;
|
|
ASSERT_EQ(getline(&line_read, &allocated_length, fp), -1);
|
|
ASSERT_EQ(0, errno);
|
|
ASSERT_TRUE(feof(fp));
|
|
|
|
free(line_read);
|
|
fclose(fp);
|
|
}
|
|
|
|
TEST(stdio, getline_invalid) {
|
|
FILE* fp = tmpfile();
|
|
|
|
char* buffer = NULL;
|
|
size_t buffer_length = 0;
|
|
|
|
// The first argument can't be NULL.
|
|
errno = 0;
|
|
ASSERT_EQ(getline(NULL, &buffer_length, fp), -1);
|
|
ASSERT_EQ(EINVAL, errno);
|
|
|
|
// The second argument can't be NULL.
|
|
errno = 0;
|
|
ASSERT_EQ(getline(&buffer, NULL, fp), -1);
|
|
ASSERT_EQ(EINVAL, errno);
|
|
|
|
// The stream can't be closed.
|
|
fclose(fp);
|
|
errno = 0;
|
|
ASSERT_EQ(getline(&buffer, &buffer_length, fp), -1);
|
|
// glibc sometimes doesn't set errno in this particular case.
|
|
#if defined(__BIONIC__)
|
|
ASSERT_EQ(EBADF, errno);
|
|
#endif
|
|
}
|
|
|
|
TEST(stdio, printf_ssize_t) {
|
|
// http://b/8253769
|
|
ASSERT_EQ(sizeof(ssize_t), sizeof(long int));
|
|
ASSERT_EQ(sizeof(ssize_t), sizeof(size_t));
|
|
// For our 32-bit ABI, we had a ssize_t definition that confuses GCC into saying:
|
|
// error: format '%zd' expects argument of type 'signed size_t',
|
|
// but argument 4 has type 'ssize_t {aka long int}' [-Werror=format]
|
|
ssize_t v = 1;
|
|
char buf[32];
|
|
snprintf(buf, sizeof(buf), "%zd", v);
|
|
}
|
|
|
|
#if !defined(__GLIBC__)
|
|
TEST(stdio, snprintf_n_format_specifier_not_implemented) {
|
|
char buf[32];
|
|
int i = 0;
|
|
// We deliberately don't implement %n, so it's treated like
|
|
// any other unrecognized format specifier.
|
|
EXPECT_EQ(5, snprintf(buf, sizeof(buf), "a %n b", &i));
|
|
EXPECT_EQ(0, i);
|
|
EXPECT_STREQ("a n b", buf);
|
|
}
|
|
#endif
|
|
|
|
TEST(stdio, snprintf_smoke) {
|
|
char buf[BUFSIZ];
|
|
|
|
snprintf(buf, sizeof(buf), "a");
|
|
EXPECT_STREQ("a", buf);
|
|
|
|
snprintf(buf, sizeof(buf), "%%");
|
|
EXPECT_STREQ("%", buf);
|
|
|
|
snprintf(buf, sizeof(buf), "01234");
|
|
EXPECT_STREQ("01234", buf);
|
|
|
|
snprintf(buf, sizeof(buf), "a%sb", "01234");
|
|
EXPECT_STREQ("a01234b", buf);
|
|
|
|
char* s = NULL;
|
|
snprintf(buf, sizeof(buf), "a%sb", s);
|
|
EXPECT_STREQ("a(null)b", buf);
|
|
|
|
snprintf(buf, sizeof(buf), "aa%scc", "bb");
|
|
EXPECT_STREQ("aabbcc", buf);
|
|
|
|
snprintf(buf, sizeof(buf), "a%cc", 'b');
|
|
EXPECT_STREQ("abc", buf);
|
|
|
|
snprintf(buf, sizeof(buf), "a%db", 1234);
|
|
EXPECT_STREQ("a1234b", buf);
|
|
|
|
snprintf(buf, sizeof(buf), "a%db", -8123);
|
|
EXPECT_STREQ("a-8123b", buf);
|
|
|
|
snprintf(buf, sizeof(buf), "a%hdb", static_cast<short>(0x7fff0010));
|
|
EXPECT_STREQ("a16b", buf);
|
|
|
|
snprintf(buf, sizeof(buf), "a%hhdb", static_cast<char>(0x7fffff10));
|
|
EXPECT_STREQ("a16b", buf);
|
|
|
|
snprintf(buf, sizeof(buf), "a%lldb", 0x1000000000LL);
|
|
EXPECT_STREQ("a68719476736b", buf);
|
|
|
|
snprintf(buf, sizeof(buf), "a%ldb", 70000L);
|
|
EXPECT_STREQ("a70000b", buf);
|
|
|
|
snprintf(buf, sizeof(buf), "a%pb", reinterpret_cast<void*>(0xb0001234));
|
|
EXPECT_STREQ("a0xb0001234b", buf);
|
|
|
|
snprintf(buf, sizeof(buf), "a%xz", 0x12ab);
|
|
EXPECT_STREQ("a12abz", buf);
|
|
|
|
snprintf(buf, sizeof(buf), "a%Xz", 0x12ab);
|
|
EXPECT_STREQ("a12ABz", buf);
|
|
|
|
snprintf(buf, sizeof(buf), "a%08xz", 0x123456);
|
|
EXPECT_STREQ("a00123456z", buf);
|
|
|
|
snprintf(buf, sizeof(buf), "a%5dz", 1234);
|
|
EXPECT_STREQ("a 1234z", buf);
|
|
|
|
snprintf(buf, sizeof(buf), "a%05dz", 1234);
|
|
EXPECT_STREQ("a01234z", buf);
|
|
|
|
snprintf(buf, sizeof(buf), "a%8dz", 1234);
|
|
EXPECT_STREQ("a 1234z", buf);
|
|
|
|
snprintf(buf, sizeof(buf), "a%-8dz", 1234);
|
|
EXPECT_STREQ("a1234 z", buf);
|
|
|
|
snprintf(buf, sizeof(buf), "A%-11sZ", "abcdef");
|
|
EXPECT_STREQ("Aabcdef Z", buf);
|
|
|
|
snprintf(buf, sizeof(buf), "A%s:%dZ", "hello", 1234);
|
|
EXPECT_STREQ("Ahello:1234Z", buf);
|
|
|
|
snprintf(buf, sizeof(buf), "a%03d:%d:%02dz", 5, 5, 5);
|
|
EXPECT_STREQ("a005:5:05z", buf);
|
|
|
|
void* p = NULL;
|
|
snprintf(buf, sizeof(buf), "a%d,%pz", 5, p);
|
|
#if defined(__BIONIC__)
|
|
EXPECT_STREQ("a5,0x0z", buf);
|
|
#else
|
|
EXPECT_STREQ("a5,(nil)z", buf);
|
|
#endif
|
|
|
|
snprintf(buf, sizeof(buf), "a%lld,%d,%d,%dz", 0x1000000000LL, 6, 7, 8);
|
|
EXPECT_STREQ("a68719476736,6,7,8z", buf);
|
|
|
|
snprintf(buf, sizeof(buf), "a_%f_b", 1.23f);
|
|
EXPECT_STREQ("a_1.230000_b", buf);
|
|
|
|
snprintf(buf, sizeof(buf), "a_%g_b", 3.14);
|
|
EXPECT_STREQ("a_3.14_b", buf);
|
|
}
|
|
|
|
TEST(stdio, snprintf_d_INT_MAX) {
|
|
char buf[BUFSIZ];
|
|
snprintf(buf, sizeof(buf), "%d", INT_MAX);
|
|
EXPECT_STREQ("2147483647", buf);
|
|
}
|
|
|
|
TEST(stdio, snprintf_d_INT_MIN) {
|
|
char buf[BUFSIZ];
|
|
snprintf(buf, sizeof(buf), "%d", INT_MIN);
|
|
EXPECT_STREQ("-2147483648", buf);
|
|
}
|
|
|
|
TEST(stdio, snprintf_ld_LONG_MAX) {
|
|
char buf[BUFSIZ];
|
|
snprintf(buf, sizeof(buf), "%ld", LONG_MAX);
|
|
#if __LP64__
|
|
EXPECT_STREQ("9223372036854775807", buf);
|
|
#else
|
|
EXPECT_STREQ("2147483647", buf);
|
|
#endif
|
|
}
|
|
|
|
TEST(stdio, snprintf_ld_LONG_MIN) {
|
|
char buf[BUFSIZ];
|
|
snprintf(buf, sizeof(buf), "%ld", LONG_MIN);
|
|
#if __LP64__
|
|
EXPECT_STREQ("-9223372036854775808", buf);
|
|
#else
|
|
EXPECT_STREQ("-2147483648", buf);
|
|
#endif
|
|
}
|
|
|
|
TEST(stdio, snprintf_lld_LLONG_MAX) {
|
|
char buf[BUFSIZ];
|
|
snprintf(buf, sizeof(buf), "%lld", LLONG_MAX);
|
|
EXPECT_STREQ("9223372036854775807", buf);
|
|
}
|
|
|
|
TEST(stdio, snprintf_lld_LLONG_MIN) {
|
|
char buf[BUFSIZ];
|
|
snprintf(buf, sizeof(buf), "%lld", LLONG_MIN);
|
|
EXPECT_STREQ("-9223372036854775808", buf);
|
|
}
|
|
|
|
TEST(stdio, popen) {
|
|
FILE* fp = popen("cat /proc/version", "r");
|
|
ASSERT_TRUE(fp != NULL);
|
|
|
|
char buf[16];
|
|
char* s = fgets(buf, sizeof(buf), fp);
|
|
buf[13] = '\0';
|
|
ASSERT_STREQ("Linux version", s);
|
|
|
|
ASSERT_EQ(0, pclose(fp));
|
|
}
|
|
|
|
TEST(stdio, getc) {
|
|
FILE* fp = fopen("/proc/version", "r");
|
|
ASSERT_TRUE(fp != NULL);
|
|
ASSERT_EQ('L', getc(fp));
|
|
ASSERT_EQ('i', getc(fp));
|
|
ASSERT_EQ('n', getc(fp));
|
|
ASSERT_EQ('u', getc(fp));
|
|
ASSERT_EQ('x', getc(fp));
|
|
fclose(fp);
|
|
}
|
|
|
|
TEST(stdio, putc) {
|
|
FILE* fp = fopen("/proc/version", "r");
|
|
ASSERT_TRUE(fp != NULL);
|
|
ASSERT_EQ(EOF, putc('x', fp));
|
|
fclose(fp);
|
|
}
|