97271920bf
Add a hook that's called upon file descriptor creation to libc, and a
library that uses it to capture backtraces for file descriptor creation,
to make it easier to hunt down file descriptor leaks.
Currently, this doesn't capture all of the ways of creating a file
descriptor, but completeness isn't required for this to be useful as
long as leaked file descriptors are created with a function that is
tracked. The primary unhandled case is binder, which receives file
descriptors as a payload in a not-trivially-parsable byte blob, but
there's a chance that the leak we're currently trying to track down
isn't of a file descriptor received over binder, so leave that for
later.
Bug: http://b/140703823
Test: manual
Change-Id: I308a14c2e234cdba4207157b634ab6b8bc539dd9
(cherry picked from commit b7eccd4b15)
76 lines
2.5 KiB
C++
76 lines
2.5 KiB
C++
/*
|
|
* Copyright (C) 2019 The Android Open Source Project
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* * Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in
|
|
* the documentation and/or other materials provided with the
|
|
* distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
|
|
* FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
|
|
* COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
|
|
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
|
|
* BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
|
|
* OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
|
|
* AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
|
|
* OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
|
|
* OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
|
|
* SUCH DAMAGE.
|
|
*/
|
|
|
|
#include <stdarg.h>
|
|
#include <fcntl.h>
|
|
|
|
#include "private/bionic_fdtrack.h"
|
|
|
|
#if defined(__LP64__)
|
|
|
|
extern "C" int __fcntl(int fd, int cmd, ...);
|
|
|
|
int fcntl(int fd, int cmd, ...) {
|
|
va_list args;
|
|
va_start(args, cmd);
|
|
|
|
// This is a bit sketchy, especially because arg can be an int, but all of our
|
|
// supported 64-bit ABIs pass arg in a register.
|
|
void* arg = va_arg(args, void*);
|
|
va_end(args);
|
|
|
|
int rc = __fcntl(fd, cmd, arg);
|
|
if (cmd == F_DUPFD) {
|
|
return FDTRACK_CREATE_NAME("F_DUPFD", rc);
|
|
} else if (cmd == F_DUPFD_CLOEXEC) {
|
|
return FDTRACK_CREATE_NAME("F_DUPFD_CLOEXEC", rc);
|
|
}
|
|
return rc;
|
|
}
|
|
|
|
#else
|
|
|
|
extern "C" int __fcntl64(int, int, ...);
|
|
|
|
// For fcntl we use the fcntl64 system call to signal that we're using struct flock64.
|
|
int fcntl(int fd, int cmd, ...) {
|
|
va_list ap;
|
|
|
|
va_start(ap, cmd);
|
|
void* arg = va_arg(ap, void*);
|
|
va_end(ap);
|
|
|
|
if (cmd == F_DUPFD) {
|
|
return FDTRACK_CREATE_NAME("F_DUPFD", __fcntl64(fd, cmd, arg));
|
|
} else if (cmd == F_DUPFD_CLOEXEC) {
|
|
return FDTRACK_CREATE_NAME("F_DUPFD_CLOEXEC", __fcntl64(fd, cmd, arg));
|
|
}
|
|
return __fcntl64(fd, cmd, arg);
|
|
}
|
|
|
|
#endif
|