95646e6666
We've talked about this many times in the past, but partners struggle to understand "expected 38, got 22" in these contexts, and I always have to go and check the header files just to be sure I'm sure. I actually think the glibc geterrorname_np() function (which would return "ENOSYS" rather than "Function not implemented") would be more helpful, but I'll have to go and implement that first, and then come back. Being forced to go through all our errno assertions did also make me want to use a more consistent style for our ENOSYS assertions in particular --- there's a particularly readable idiom, and I'll also come back and move more of those checks to the most readable idiom. I've added a few missing `errno = 0`s before tests, and removed a few stray `errno = 0`s from tests that don't actually make assertions about errno, since I had to look at every single reference to errno anyway. Test: treehugger Change-Id: Iba7c56f2adc30288c3e00ade106635e515e88179
138 lines
3.8 KiB
C++
138 lines
3.8 KiB
C++
/*
|
|
* Copyright (C) 2015 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#include <fcntl.h>
|
|
#include <sys/types.h>
|
|
#include <sys/xattr.h>
|
|
|
|
#include <android-base/file.h>
|
|
#include <gtest/gtest.h>
|
|
|
|
#include "utils.h"
|
|
|
|
TEST(sys_xattr, setxattr) {
|
|
TemporaryFile tf;
|
|
char buf[10];
|
|
ASSERT_EQ(0, setxattr(tf.path, "user.foo", "bar", 4, 0));
|
|
ASSERT_EQ(4, getxattr(tf.path, "user.foo", buf, sizeof(buf)));
|
|
ASSERT_STREQ("bar", buf);
|
|
buf[0] = '\0';
|
|
ASSERT_EQ(4, lgetxattr(tf.path, "user.foo", buf, sizeof(buf)));
|
|
ASSERT_STREQ("bar", buf);
|
|
}
|
|
|
|
TEST(sys_xattr, fsetxattr) {
|
|
TemporaryFile tf;
|
|
char buf[10];
|
|
ASSERT_EQ(0, fsetxattr(tf.fd, "user.foo", "bar", 4, 0));
|
|
ASSERT_EQ(4, fgetxattr(tf.fd, "user.foo", buf, sizeof(buf)));
|
|
ASSERT_STREQ("bar", buf);
|
|
}
|
|
|
|
TEST(sys_xattr, fsetxattr_zerobuf) {
|
|
TemporaryFile tf;
|
|
char buf[10];
|
|
ASSERT_EQ(0, fsetxattr(tf.fd, "user.foo", "", 0, 0));
|
|
ASSERT_EQ(0, fgetxattr(tf.fd, "user.foo", buf, sizeof(buf)));
|
|
}
|
|
|
|
TEST(sys_xattr, fsetxattr_toosmallbuf) {
|
|
TemporaryFile tf;
|
|
char buf[10];
|
|
ASSERT_EQ(0, fsetxattr(tf.fd, "user.foo", "01234567890123456789", 21, 0));
|
|
ASSERT_EQ(-1, fgetxattr(tf.fd, "user.foo", buf, sizeof(buf)));
|
|
ASSERT_ERRNO(ERANGE);
|
|
}
|
|
|
|
TEST(sys_xattr, fsetxattr_invalid_fd) {
|
|
char buf[10];
|
|
errno = 0;
|
|
ASSERT_EQ(-1, fsetxattr(-1, "user.foo", "0123", 5, 0));
|
|
ASSERT_ERRNO(EBADF);
|
|
errno = 0;
|
|
ASSERT_EQ(-1, fgetxattr(-1, "user.foo", buf, sizeof(buf)));
|
|
ASSERT_ERRNO(EBADF);
|
|
}
|
|
|
|
TEST(sys_xattr, fsetxattr_with_opath) {
|
|
TemporaryFile tf;
|
|
int fd = open(tf.path, O_PATH);
|
|
ASSERT_NE(-1, fd);
|
|
|
|
int res = fsetxattr(fd, "user.foo", "bar", 4, 0);
|
|
#if defined(__BIONIC__)
|
|
char buf[10];
|
|
ASSERT_EQ(0, res);
|
|
ASSERT_EQ(4, fgetxattr(fd, "user.foo", buf, sizeof(buf)));
|
|
ASSERT_STREQ("bar", buf);
|
|
#else
|
|
ASSERT_EQ(-1, res);
|
|
ASSERT_ERRNO(EBADF);
|
|
#endif
|
|
close(fd);
|
|
}
|
|
|
|
TEST(sys_xattr, fsetxattr_with_opath_toosmall) {
|
|
TemporaryFile tf;
|
|
int fd = open(tf.path, O_PATH);
|
|
ASSERT_NE(-1, fd);
|
|
|
|
int res = fsetxattr(fd, "user.foo", "01234567890123456789", 21, 0);
|
|
#if defined(__BIONIC__)
|
|
char buf[10];
|
|
ASSERT_EQ(0, res);
|
|
ASSERT_EQ(-1, fgetxattr(fd, "user.foo", buf, sizeof(buf)));
|
|
ASSERT_ERRNO(ERANGE);
|
|
#else
|
|
ASSERT_EQ(-1, res);
|
|
ASSERT_ERRNO(EBADF);
|
|
#endif
|
|
close(fd);
|
|
}
|
|
|
|
TEST(sys_xattr, flistattr) {
|
|
TemporaryFile tf;
|
|
char buf[65536]; // 64kB is max possible xattr list size. See "man 7 xattr".
|
|
ASSERT_EQ(0, fsetxattr(tf.fd, "user.foo", "bar", 4, 0));
|
|
ssize_t result = flistxattr(tf.fd, buf, sizeof(buf));
|
|
ASSERT_TRUE(result >= 9);
|
|
ASSERT_TRUE(memmem(buf, sizeof(buf), "user.foo", 9) != nullptr);
|
|
}
|
|
|
|
TEST(sys_xattr, flistattr_opath) {
|
|
TemporaryFile tf;
|
|
char buf[65536]; // 64kB is max possible xattr list size. See "man 7 xattr".
|
|
ASSERT_EQ(0, fsetxattr(tf.fd, "user.foo", "bar", 4, 0));
|
|
int fd = open(tf.path, O_PATH);
|
|
ASSERT_NE(-1, fd);
|
|
ssize_t res = flistxattr(fd, buf, sizeof(buf));
|
|
#if defined(__BIONIC__)
|
|
ASSERT_TRUE(res >= 9);
|
|
ASSERT_TRUE(static_cast<size_t>(res) <= sizeof(buf));
|
|
ASSERT_TRUE(memmem(buf, res, "user.foo", 9) != nullptr);
|
|
#else
|
|
ASSERT_EQ(-1, res);
|
|
ASSERT_ERRNO(EBADF);
|
|
#endif
|
|
close(fd);
|
|
}
|
|
|
|
TEST(sys_xattr, flistattr_invalid_fd) {
|
|
char buf[65536]; // 64kB is max possible xattr list size. See "man 7 xattr".
|
|
errno = 0;
|
|
ASSERT_EQ(-1, flistxattr(-1, buf, sizeof(buf)));
|
|
ASSERT_ERRNO(EBADF);
|
|
}
|