platform_bionic/linker/linker_namespaces.h
Elliott Hughes f9dd1a760a Store soname as a std::string.
Once upon a time (and, indeed, to this very day if you're on LP32) the
soinfo struct used a fixed-length buffer for the soname. This caused
some issues, mainly with app developers who accidentally included a full
Windows "C:\My Computer\...\libfoo.so" style path. To avoid all this we
switched to just pointing into the ELF file itself, where the DT_SONAME
is already stored as a NUL-terminated string. And all was well for many
years.

Now though, we've seen a bunch of slow startup traces from dogfood where
`dlopen("libnativebridge.so")` in a cold start takes 125-200ms on a recent
device, despite no IO contention. Even though libnativebridge.so is only
20KiB.

Measurement showed that every library whose soname we check required
pulling in a whole page just for the (usually) very short string. Worse,
there's readahead. In one trace we saw 18 pages of libhwui.so pulled
in just for `"libhwui.so\0"`. In fact, there were 3306 pages (~13MiB)
added to the page cache during `dlopen("libnativebridge.so")`. 13MiB for
a 20KiB shared library!

This is the obvious change to use a std::string to copy the sonames
instead. This will dirty slightly more memory, but massively improve
locality.

Testing with the same pathological setup took `dlopen("libnativebridge.so")`
down from 192ms to 819us.

Bug: http://b/177102905
Test: tested with a pathologically modified kernel
Change-Id: I33837f4706adc25f93c6fa6013e8ba970911dfb9
2021-01-11 09:57:46 -08:00

183 lines
6.4 KiB
C++

/*
* Copyright (C) 2016 The Android Open Source Project
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* * Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* * Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in
* the documentation and/or other materials provided with the
* distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
* FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
* COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
* BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
* OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
* AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
* OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
* OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*/
#pragma once
#include "linker_common_types.h"
#include <string>
#include <vector>
#include <unordered_set>
std::vector<std::string> fix_lib_paths(std::vector<std::string> paths);
struct android_namespace_t;
struct android_namespace_link_t {
public:
android_namespace_link_t(android_namespace_t* linked_namespace,
const std::unordered_set<std::string>& shared_lib_sonames,
bool allow_all_shared_libs)
: linked_namespace_(linked_namespace), shared_lib_sonames_(shared_lib_sonames),
allow_all_shared_libs_(allow_all_shared_libs)
{}
android_namespace_t* linked_namespace() const {
return linked_namespace_;
}
const std::unordered_set<std::string>& shared_lib_sonames() const {
return shared_lib_sonames_;
}
bool is_accessible(const char* soname) const {
return allow_all_shared_libs_ || shared_lib_sonames_.find(soname) != shared_lib_sonames_.end();
}
bool allow_all_shared_libs() const {
return allow_all_shared_libs_;
}
private:
android_namespace_t* const linked_namespace_;
const std::unordered_set<std::string> shared_lib_sonames_;
bool allow_all_shared_libs_;
};
struct android_namespace_t {
public:
android_namespace_t() :
is_isolated_(false),
is_exempt_list_enabled_(false),
is_also_used_as_anonymous_(false) {}
const char* get_name() const { return name_.c_str(); }
void set_name(const char* name) { name_ = name; }
bool is_isolated() const { return is_isolated_; }
void set_isolated(bool isolated) { is_isolated_ = isolated; }
bool is_exempt_list_enabled() const { return is_exempt_list_enabled_; }
void set_exempt_list_enabled(bool enabled) { is_exempt_list_enabled_ = enabled; }
bool is_also_used_as_anonymous() const { return is_also_used_as_anonymous_; }
void set_also_used_as_anonymous(bool yes) { is_also_used_as_anonymous_ = yes; }
const std::vector<std::string>& get_ld_library_paths() const {
return ld_library_paths_;
}
void set_ld_library_paths(std::vector<std::string>&& library_paths) {
ld_library_paths_ = std::move(library_paths);
}
const std::vector<std::string>& get_default_library_paths() const {
return default_library_paths_;
}
void set_default_library_paths(std::vector<std::string>&& library_paths) {
default_library_paths_ = fix_lib_paths(std::move(library_paths));
}
void set_default_library_paths(const std::vector<std::string>& library_paths) {
default_library_paths_ = fix_lib_paths(library_paths);
}
const std::vector<std::string>& get_permitted_paths() const {
return permitted_paths_;
}
void set_permitted_paths(std::vector<std::string>&& permitted_paths) {
permitted_paths_ = std::move(permitted_paths);
}
void set_permitted_paths(const std::vector<std::string>& permitted_paths) {
permitted_paths_ = permitted_paths;
}
const std::vector<std::string>& get_allowed_libs() const { return allowed_libs_; }
void set_allowed_libs(std::vector<std::string>&& allowed_libs) {
allowed_libs_ = std::move(allowed_libs);
}
void set_allowed_libs(const std::vector<std::string>& allowed_libs) {
allowed_libs_ = allowed_libs;
}
const std::vector<android_namespace_link_t>& linked_namespaces() const {
return linked_namespaces_;
}
void add_linked_namespace(android_namespace_t* linked_namespace,
const std::unordered_set<std::string>& shared_lib_sonames,
bool allow_all_shared_libs) {
linked_namespaces_.push_back(
android_namespace_link_t(linked_namespace, shared_lib_sonames, allow_all_shared_libs));
}
void add_soinfo(soinfo* si) {
soinfo_list_.push_back(si);
}
void add_soinfos(const soinfo_list_t& soinfos) {
for (auto si : soinfos) {
add_soinfo(si);
}
}
void remove_soinfo(soinfo* si) {
soinfo_list_.remove_if([&](soinfo* candidate) {
return si == candidate;
});
}
const soinfo_list_t& soinfo_list() const { return soinfo_list_; }
// For isolated namespaces - checks if the file is on the search path;
// always returns true for not isolated namespace.
bool is_accessible(const std::string& path);
// Returns true if si is accessible from this namespace. A soinfo
// is considered accessible when it belongs to this namespace
// or one of it's parent soinfos belongs to this namespace.
bool is_accessible(soinfo* si);
soinfo_list_t get_global_group();
soinfo_list_t get_shared_group();
private:
std::string name_;
bool is_isolated_;
bool is_exempt_list_enabled_;
bool is_also_used_as_anonymous_;
std::vector<std::string> ld_library_paths_;
std::vector<std::string> default_library_paths_;
std::vector<std::string> permitted_paths_;
std::vector<std::string> allowed_libs_;
// Loader looks into linked namespace if it was not able
// to find a library in this namespace. Note that library
// lookup in linked namespaces are limited by the list of
// shared sonames.
std::vector<android_namespace_link_t> linked_namespaces_;
soinfo_list_t soinfo_list_;
DISALLOW_COPY_AND_ASSIGN(android_namespace_t);
};