95646e6666
We've talked about this many times in the past, but partners struggle to understand "expected 38, got 22" in these contexts, and I always have to go and check the header files just to be sure I'm sure. I actually think the glibc geterrorname_np() function (which would return "ENOSYS" rather than "Function not implemented") would be more helpful, but I'll have to go and implement that first, and then come back. Being forced to go through all our errno assertions did also make me want to use a more consistent style for our ENOSYS assertions in particular --- there's a particularly readable idiom, and I'll also come back and move more of those checks to the most readable idiom. I've added a few missing `errno = 0`s before tests, and removed a few stray `errno = 0`s from tests that don't actually make assertions about errno, since I had to look at every single reference to errno anyway. Test: treehugger Change-Id: Iba7c56f2adc30288c3e00ade106635e515e88179
203 lines
5.9 KiB
C++
203 lines
5.9 KiB
C++
/*
|
|
* Copyright (C) 2014 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#include <ftw.h>
|
|
|
|
#include <fcntl.h>
|
|
#include <pwd.h>
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <sys/stat.h>
|
|
#include <sys/types.h>
|
|
#include <unistd.h>
|
|
|
|
#include <android-base/file.h>
|
|
#include <android-base/stringprintf.h>
|
|
#include <gtest/gtest.h>
|
|
|
|
#include "utils.h"
|
|
|
|
static void MakeTree(const char* root) {
|
|
char path[PATH_MAX];
|
|
|
|
snprintf(path, sizeof(path), "%s/dir", root);
|
|
ASSERT_EQ(0, mkdir(path, 0755)) << path;
|
|
snprintf(path, sizeof(path), "%s/dir/sub", root);
|
|
ASSERT_EQ(0, mkdir(path, 0555)) << path;
|
|
snprintf(path, sizeof(path), "%s/unreadable-dir", root);
|
|
ASSERT_EQ(0, mkdir(path, 0000)) << path;
|
|
|
|
snprintf(path, sizeof(path), "%s/dangler", root);
|
|
ASSERT_EQ(0, symlink("/does-not-exist", path));
|
|
snprintf(path, sizeof(path), "%s/symlink", root);
|
|
ASSERT_EQ(0, symlink("dir/sub", path));
|
|
|
|
int fd;
|
|
snprintf(path, sizeof(path), "%s/regular", root);
|
|
ASSERT_NE(-1, fd = open(path, O_CREAT|O_TRUNC, 0666));
|
|
ASSERT_EQ(0, close(fd));
|
|
}
|
|
|
|
void smoke_test_ftw(const char* fpath, const struct stat* sb, int tflag) {
|
|
ASSERT_TRUE(fpath != nullptr);
|
|
ASSERT_TRUE(sb != nullptr);
|
|
|
|
// Was it a case where the struct stat we're given is meaningless?
|
|
if (tflag == FTW_NS || tflag == FTW_SLN) {
|
|
// If so, double-check that we really can't stat.
|
|
struct stat sb;
|
|
EXPECT_EQ(-1, stat(fpath, &sb));
|
|
return;
|
|
}
|
|
|
|
// Otherwise check that the struct stat matches the type flag.
|
|
if (S_ISDIR(sb->st_mode)) {
|
|
if (access(fpath, R_OK) == 0) {
|
|
EXPECT_TRUE(tflag == FTW_D || tflag == FTW_DP) << fpath << ' ' << tflag;
|
|
} else {
|
|
EXPECT_EQ(FTW_DNR, tflag) << fpath;
|
|
}
|
|
} else if (S_ISLNK(sb->st_mode)) {
|
|
EXPECT_EQ(FTW_SL, tflag) << fpath;
|
|
} else {
|
|
EXPECT_EQ(FTW_F, tflag) << fpath;
|
|
}
|
|
}
|
|
|
|
void smoke_test_nftw(const char* fpath, const struct stat* sb, int tflag, FTW* ftwbuf) {
|
|
smoke_test_ftw(fpath, sb, tflag);
|
|
ASSERT_EQ('/', fpath[ftwbuf->base - 1]) << fpath;
|
|
}
|
|
|
|
int check_ftw(const char* fpath, const struct stat* sb, int tflag) {
|
|
smoke_test_ftw(fpath, sb, tflag);
|
|
return 0;
|
|
}
|
|
|
|
int check_ftw64(const char* fpath, const struct stat64* sb, int tflag) {
|
|
smoke_test_ftw(fpath, reinterpret_cast<const struct stat*>(sb), tflag);
|
|
return 0;
|
|
}
|
|
|
|
int check_nftw(const char* fpath, const struct stat* sb, int tflag, FTW* ftwbuf) {
|
|
smoke_test_nftw(fpath, sb, tflag, ftwbuf);
|
|
return 0;
|
|
}
|
|
|
|
int check_nftw64(const char* fpath, const struct stat64* sb, int tflag, FTW* ftwbuf) {
|
|
smoke_test_nftw(fpath, reinterpret_cast<const struct stat*>(sb), tflag, ftwbuf);
|
|
return 0;
|
|
}
|
|
|
|
TEST(ftw, ftw) {
|
|
TemporaryDir root;
|
|
MakeTree(root.path);
|
|
ASSERT_EQ(0, ftw(root.path, check_ftw, 128));
|
|
}
|
|
|
|
TEST(ftw, ftw64_smoke) {
|
|
TemporaryDir root;
|
|
MakeTree(root.path);
|
|
ASSERT_EQ(0, ftw64(root.path, check_ftw64, 128));
|
|
}
|
|
|
|
TEST(ftw, nftw) {
|
|
TemporaryDir root;
|
|
MakeTree(root.path);
|
|
ASSERT_EQ(0, nftw(root.path, check_nftw, 128, 0));
|
|
}
|
|
|
|
TEST(ftw, nftw64_smoke) {
|
|
TemporaryDir root;
|
|
MakeTree(root.path);
|
|
ASSERT_EQ(0, nftw64(root.path, check_nftw64, 128, 0));
|
|
}
|
|
|
|
template <typename StatT>
|
|
static int bug_28197840_ftw(const char* path, const StatT*, int flag) {
|
|
EXPECT_EQ(strstr(path, "unreadable") != nullptr ? FTW_DNR : FTW_D, flag) << path;
|
|
return 0;
|
|
}
|
|
|
|
template <typename StatT>
|
|
static int bug_28197840_nftw(const char* path, const StatT* sb, int flag, FTW*) {
|
|
return bug_28197840_ftw(path, sb, flag);
|
|
}
|
|
|
|
TEST(ftw, bug_28197840) {
|
|
// Drop root for this test, because root can still read directories even if
|
|
// permissions would imply otherwise.
|
|
if (getuid() == 0) {
|
|
passwd* pwd = getpwnam("shell");
|
|
ASSERT_EQ(0, setuid(pwd->pw_uid));
|
|
}
|
|
|
|
TemporaryDir root;
|
|
|
|
std::string path = android::base::StringPrintf("%s/unreadable-directory", root.path);
|
|
ASSERT_EQ(0, mkdir(path.c_str(), 0000)) << path;
|
|
|
|
ASSERT_EQ(0, ftw(root.path, bug_28197840_ftw<struct stat>, 128));
|
|
ASSERT_EQ(0, ftw64(root.path, bug_28197840_ftw<struct stat64>, 128));
|
|
ASSERT_EQ(0, nftw(root.path, bug_28197840_nftw<struct stat>, 128, FTW_PHYS));
|
|
ASSERT_EQ(0, nftw64(root.path, bug_28197840_nftw<struct stat64>, 128, FTW_PHYS));
|
|
}
|
|
|
|
template <typename StatT>
|
|
static int null_ftw_callback(const char*, const StatT*, int) {
|
|
return 0;
|
|
}
|
|
|
|
template <typename StatT>
|
|
static int null_nftw_callback(const char*, const StatT*, int, FTW*) {
|
|
return 0;
|
|
}
|
|
|
|
TEST(ftw, ftw_non_existent_ENOENT) {
|
|
errno = 0;
|
|
ASSERT_EQ(-1, ftw("/does/not/exist", null_ftw_callback<struct stat>, 128));
|
|
ASSERT_ERRNO(ENOENT);
|
|
errno = 0;
|
|
ASSERT_EQ(-1, ftw64("/does/not/exist", null_ftw_callback<struct stat64>, 128));
|
|
ASSERT_ERRNO(ENOENT);
|
|
}
|
|
|
|
TEST(ftw, nftw_non_existent_ENOENT) {
|
|
errno = 0;
|
|
ASSERT_EQ(-1, nftw("/does/not/exist", null_nftw_callback<struct stat>, 128, FTW_PHYS));
|
|
ASSERT_ERRNO(ENOENT);
|
|
errno = 0;
|
|
ASSERT_EQ(-1, nftw64("/does/not/exist", null_nftw_callback<struct stat64>, 128, FTW_PHYS));
|
|
ASSERT_ERRNO(ENOENT);
|
|
}
|
|
|
|
TEST(ftw, ftw_empty_ENOENT) {
|
|
errno = 0;
|
|
ASSERT_EQ(-1, ftw("", null_ftw_callback<struct stat>, 128));
|
|
ASSERT_ERRNO(ENOENT);
|
|
errno = 0;
|
|
ASSERT_EQ(-1, ftw64("", null_ftw_callback<struct stat64>, 128));
|
|
ASSERT_ERRNO(ENOENT);
|
|
}
|
|
|
|
TEST(ftw, nftw_empty_ENOENT) {
|
|
errno = 0;
|
|
ASSERT_EQ(-1, nftw("", null_nftw_callback<struct stat>, 128, FTW_PHYS));
|
|
ASSERT_ERRNO(ENOENT);
|
|
errno = 0;
|
|
ASSERT_EQ(-1, nftw64("", null_nftw_callback<struct stat64>, 128, FTW_PHYS));
|
|
ASSERT_ERRNO(ENOENT);
|
|
}
|