tequilaOS/platform_bootable_recovery
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix clang-tidy performance warnings.

Browse source 
* Use const reference parameter type to avoid unnecessary copy.
* Use more efficient overloaded string methods.

Bug: 30407689
Bug: 30411878
Change-Id: Iefab05c077367f272abf545036b853e8a295c8cd
Test: build with WITH_TIDY=1
This commit is contained in:
Chih-Hung Hsieh 2016-07-27 10:19:47 -07:00
parent a82ee456bb
commit 23abfd37a5
5 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
minui/events.cpp
View file

@ -204,7 +204,7 @@ int ev_sync_key_state(ev_set_key_callback set_key_cb, void* data) {
return 0;
}
void ev_iterate_available_keys(std::function<void(int)> f) {
void ev_iterate_available_keys(const std::function<void(int)>& f) {
// Use unsigned long to match ioctl's parameter type.
unsigned long ev_bits[BITS_TO_LONGS(EV_MAX)]; // NOLINT
unsigned long key_bits[BITS_TO_LONGS(KEY_MAX)]; // NOLINT

2
minui/minui.h
View file

@ -67,7 +67,7 @@ typedef int (*ev_set_key_callback)(int code, int value, void* data);
int ev_init(ev_callback input_cb, void* data);
void ev_exit();
int ev_add_fd(int fd, ev_callback cb, void* data);
void ev_iterate_available_keys(std::function<void(int)> f);
void ev_iterate_available_keys(const std::function<void(int)>& f);
int ev_sync_key_state(ev_set_key_callback set_key_cb, void* data);
// 'timeout' has the same semantics as poll(2).

2
otafault/ota_io.cpp
View file

@ -31,7 +31,7 @@ static std::string write_fault_file_name = "";
static std::string fsync_fault_file_name = "";
bool have_eio_error = false;
static bool get_hit_file(const char* cached_path, std::string ffn) {
static bool get_hit_file(const char* cached_path, const std::string& ffn) {
return should_hit_cache()
? !strncmp(cached_path, OTAIO_CACHE_FNAME, strlen(cached_path))
: !strncmp(cached_path, ffn.c_str(), strlen(cached_path));

2
recovery-refresh.cpp
View file

@ -76,7 +76,7 @@ static ssize_t logrotate(
}
std::string name(filename);
size_t dot = name.find_last_of(".");
size_t dot = name.find_last_of('.');
std::string sub = name.substr(0, dot);
if (!strstr(LAST_KMSG_FILE, sub.c_str()) &&

2
recovery.cpp
View file

@ -1274,7 +1274,7 @@ static ssize_t logrotate(
}
std::string name(filename);
size_t dot = name.find_last_of(".");
size_t dot = name.find_last_of('.');
std::string sub = name.substr(0, dot);
if (!strstr(LAST_KMSG_FILE, sub.c_str()) &&