Merge changes from topic 'sinkfn'
* changes: applypatch: Let Apply{BSDiff,Image}Patch accept std::function. applypatch: Change the ssize_t length parameters to size_t.
This commit is contained in:
commit
34df98ee6d
7 changed files with 195 additions and 236 deletions
|
@ -27,6 +27,7 @@
|
|||
#include <sys/types.h>
|
||||
#include <unistd.h>
|
||||
|
||||
#include <functional>
|
||||
#include <memory>
|
||||
#include <string>
|
||||
#include <utility>
|
||||
|
@ -42,7 +43,7 @@
|
|||
#include "print_sha1.h"
|
||||
|
||||
static int LoadPartitionContents(const std::string& filename, FileContents* file);
|
||||
static ssize_t FileSink(const unsigned char* data, ssize_t len, void* token);
|
||||
static size_t FileSink(const unsigned char* data, size_t len, int fd);
|
||||
static int GenerateTarget(const FileContents& source_file, const std::unique_ptr<Value>& patch,
|
||||
const std::string& target_filename,
|
||||
const uint8_t target_sha1[SHA_DIGEST_LENGTH], const Value* bonus_data);
|
||||
|
@ -194,8 +195,8 @@ int SaveFileContents(const char* filename, const FileContents* file) {
|
|||
return -1;
|
||||
}
|
||||
|
||||
ssize_t bytes_written = FileSink(file->data.data(), file->data.size(), &fd);
|
||||
if (bytes_written != static_cast<ssize_t>(file->data.size())) {
|
||||
size_t bytes_written = FileSink(file->data.data(), file->data.size(), fd);
|
||||
if (bytes_written != file->data.size()) {
|
||||
printf("short write of \"%s\" (%zd bytes of %zu): %s\n", filename, bytes_written,
|
||||
file->data.size(), strerror(errno));
|
||||
return -1;
|
||||
|
@ -433,25 +434,17 @@ int ShowLicenses() {
|
|||
return 0;
|
||||
}
|
||||
|
||||
ssize_t FileSink(const unsigned char* data, ssize_t len, void* token) {
|
||||
int fd = *static_cast<int*>(token);
|
||||
ssize_t done = 0;
|
||||
ssize_t wrote;
|
||||
while (done < len) {
|
||||
wrote = TEMP_FAILURE_RETRY(ota_write(fd, data+done, len-done));
|
||||
if (wrote == -1) {
|
||||
printf("error writing %zd bytes: %s\n", (len-done), strerror(errno));
|
||||
return done;
|
||||
}
|
||||
done += wrote;
|
||||
static size_t FileSink(const unsigned char* data, size_t len, int fd) {
|
||||
size_t done = 0;
|
||||
while (done < len) {
|
||||
ssize_t wrote = TEMP_FAILURE_RETRY(ota_write(fd, data + done, len - done));
|
||||
if (wrote == -1) {
|
||||
printf("error writing %zd bytes: %s\n", (len - done), strerror(errno));
|
||||
return done;
|
||||
}
|
||||
return done;
|
||||
}
|
||||
|
||||
ssize_t MemorySink(const unsigned char* data, ssize_t len, void* token) {
|
||||
std::string* s = static_cast<std::string*>(token);
|
||||
s->append(reinterpret_cast<const char*>(data), len);
|
||||
return len;
|
||||
done += wrote;
|
||||
}
|
||||
return done;
|
||||
}
|
||||
|
||||
// Return the amount of free space (in bytes) on the filesystem
|
||||
|
@ -647,9 +640,11 @@ static int GenerateTarget(const FileContents& source_file, const std::unique_ptr
|
|||
}
|
||||
|
||||
// We store the decoded output in memory.
|
||||
SinkFn sink = MemorySink;
|
||||
std::string memory_sink_str; // Don't need to reserve space.
|
||||
void* token = &memory_sink_str;
|
||||
SinkFn sink = [&memory_sink_str](const unsigned char* data, size_t len) {
|
||||
memory_sink_str.append(reinterpret_cast<const char*>(data), len);
|
||||
return len;
|
||||
};
|
||||
|
||||
SHA_CTX ctx;
|
||||
SHA1_Init(&ctx);
|
||||
|
@ -657,10 +652,10 @@ static int GenerateTarget(const FileContents& source_file, const std::unique_ptr
|
|||
int result;
|
||||
if (use_bsdiff) {
|
||||
result = ApplyBSDiffPatch(source_file.data.data(), source_file.data.size(), patch.get(), 0,
|
||||
sink, token, &ctx);
|
||||
sink, &ctx);
|
||||
} else {
|
||||
result = ApplyImagePatch(source_file.data.data(), source_file.data.size(), patch.get(), sink,
|
||||
token, &ctx, bonus_data);
|
||||
&ctx, bonus_data);
|
||||
}
|
||||
|
||||
if (result != 0) {
|
||||
|
|
|
@ -24,9 +24,9 @@
|
|||
#include <sys/types.h>
|
||||
|
||||
#include <bspatch.h>
|
||||
#include <openssl/sha.h>
|
||||
|
||||
#include "applypatch/applypatch.h"
|
||||
#include "openssl/sha.h"
|
||||
|
||||
void ShowBSDiffLicense() {
|
||||
puts("The bsdiff library used herein is:\n"
|
||||
|
@ -60,10 +60,10 @@ void ShowBSDiffLicense() {
|
|||
);
|
||||
}
|
||||
|
||||
int ApplyBSDiffPatch(const unsigned char* old_data, ssize_t old_size, const Value* patch,
|
||||
ssize_t patch_offset, SinkFn sink, void* token, SHA_CTX* ctx) {
|
||||
auto sha_sink = [&](const uint8_t* data, size_t len) {
|
||||
len = sink(data, len, token);
|
||||
int ApplyBSDiffPatch(const unsigned char* old_data, size_t old_size, const Value* patch,
|
||||
size_t patch_offset, SinkFn sink, SHA_CTX* ctx) {
|
||||
auto sha_sink = [&sink, &ctx](const uint8_t* data, size_t len) {
|
||||
len = sink(data, len);
|
||||
if (ctx) SHA1_Update(ctx, data, len);
|
||||
return len;
|
||||
};
|
||||
|
@ -72,8 +72,8 @@ int ApplyBSDiffPatch(const unsigned char* old_data, ssize_t old_size, const Valu
|
|||
patch->data.size(), sha_sink);
|
||||
}
|
||||
|
||||
int ApplyBSDiffPatchMem(const unsigned char* old_data, ssize_t old_size, const Value* patch,
|
||||
ssize_t patch_offset, std::vector<unsigned char>* new_data) {
|
||||
int ApplyBSDiffPatchMem(const unsigned char* old_data, size_t old_size, const Value* patch,
|
||||
size_t patch_offset, std::vector<unsigned char>* new_data) {
|
||||
auto vector_sink = [new_data](const uint8_t* data, size_t len) {
|
||||
new_data->insert(new_data->end(), data, data + len);
|
||||
return len;
|
||||
|
|
|
@ -43,12 +43,11 @@ static inline int32_t Read4(const void *address) {
|
|||
return android::base::get_unaligned<int32_t>(address);
|
||||
}
|
||||
|
||||
int ApplyImagePatch(const unsigned char* old_data, ssize_t old_size,
|
||||
const unsigned char* patch_data, ssize_t patch_size,
|
||||
SinkFn sink, void* token) {
|
||||
int ApplyImagePatch(const unsigned char* old_data, size_t old_size, const unsigned char* patch_data,
|
||||
size_t patch_size, SinkFn sink) {
|
||||
Value patch(VAL_BLOB, std::string(reinterpret_cast<const char*>(patch_data), patch_size));
|
||||
|
||||
return ApplyImagePatch(old_data, old_size, &patch, sink, token, nullptr, nullptr);
|
||||
return ApplyImagePatch(old_data, old_size, &patch, sink, nullptr, nullptr);
|
||||
}
|
||||
|
||||
/*
|
||||
|
@ -57,8 +56,8 @@ int ApplyImagePatch(const unsigned char* old_data, ssize_t old_size,
|
|||
* file, and update the SHA context with the output data as well.
|
||||
* Return 0 on success.
|
||||
*/
|
||||
int ApplyImagePatch(const unsigned char* old_data, ssize_t old_size, const Value* patch,
|
||||
SinkFn sink, void* token, SHA_CTX* ctx, const Value* bonus_data) {
|
||||
int ApplyImagePatch(const unsigned char* old_data, size_t old_size, const Value* patch, SinkFn sink,
|
||||
SHA_CTX* ctx, const Value* bonus_data) {
|
||||
if (patch->data.size() < 12) {
|
||||
printf("patch too short to contain header\n");
|
||||
return -1;
|
||||
|
@ -97,11 +96,11 @@ int ApplyImagePatch(const unsigned char* old_data, ssize_t old_size, const Value
|
|||
size_t src_len = static_cast<size_t>(Read8(normal_header + 8));
|
||||
size_t patch_offset = static_cast<size_t>(Read8(normal_header + 16));
|
||||
|
||||
if (src_start + src_len > static_cast<size_t>(old_size)) {
|
||||
if (src_start + src_len > old_size) {
|
||||
printf("source data too short\n");
|
||||
return -1;
|
||||
}
|
||||
ApplyBSDiffPatch(old_data + src_start, src_len, patch, patch_offset, sink, token, ctx);
|
||||
ApplyBSDiffPatch(old_data + src_start, src_len, patch, patch_offset, sink, ctx);
|
||||
} else if (type == CHUNK_RAW) {
|
||||
const char* raw_header = &patch->data[pos];
|
||||
pos += 4;
|
||||
|
@ -110,15 +109,14 @@ int ApplyImagePatch(const unsigned char* old_data, ssize_t old_size, const Value
|
|||
return -1;
|
||||
}
|
||||
|
||||
ssize_t data_len = Read4(raw_header);
|
||||
size_t data_len = static_cast<size_t>(Read4(raw_header));
|
||||
|
||||
if (pos + data_len > patch->data.size()) {
|
||||
printf("failed to read chunk %d raw data\n", i);
|
||||
return -1;
|
||||
}
|
||||
if (ctx) SHA1_Update(ctx, &patch->data[pos], data_len);
|
||||
if (sink(reinterpret_cast<const unsigned char*>(&patch->data[pos]), data_len, token) !=
|
||||
data_len) {
|
||||
if (sink(reinterpret_cast<const unsigned char*>(&patch->data[pos]), data_len) != data_len) {
|
||||
printf("failed to write chunk %d raw data\n", i);
|
||||
return -1;
|
||||
}
|
||||
|
@ -143,7 +141,7 @@ int ApplyImagePatch(const unsigned char* old_data, ssize_t old_size, const Value
|
|||
int memLevel = Read4(deflate_header + 52);
|
||||
int strategy = Read4(deflate_header + 56);
|
||||
|
||||
if (src_start + src_len > static_cast<size_t>(old_size)) {
|
||||
if (src_start + src_len > old_size) {
|
||||
printf("source data too short\n");
|
||||
return -1;
|
||||
}
|
||||
|
@ -240,9 +238,9 @@ int ApplyImagePatch(const unsigned char* old_data, ssize_t old_size, const Value
|
|||
strm.avail_out = temp_data.size();
|
||||
strm.next_out = temp_data.data();
|
||||
ret = deflate(&strm, Z_FINISH);
|
||||
ssize_t have = temp_data.size() - strm.avail_out;
|
||||
size_t have = temp_data.size() - strm.avail_out;
|
||||
|
||||
if (sink(temp_data.data(), have, token) != have) {
|
||||
if (sink(temp_data.data(), have) != have) {
|
||||
printf("failed to write %zd compressed bytes to output\n", have);
|
||||
return -1;
|
||||
}
|
||||
|
|
|
@ -20,6 +20,7 @@
|
|||
#include <stdint.h>
|
||||
#include <sys/stat.h>
|
||||
|
||||
#include <functional>
|
||||
#include <memory>
|
||||
#include <string>
|
||||
#include <vector>
|
||||
|
@ -41,7 +42,7 @@ struct FileContents {
|
|||
// and use it as the source instead.
|
||||
#define CACHE_TEMP_SOURCE "/cache/saved.file"
|
||||
|
||||
typedef ssize_t (*SinkFn)(const unsigned char*, ssize_t, void*);
|
||||
using SinkFn = std::function<size_t(const unsigned char*, size_t)>;
|
||||
|
||||
// applypatch.cpp
|
||||
int ShowLicenses();
|
||||
|
@ -66,18 +67,14 @@ int SaveFileContents(const char* filename, const FileContents* file);
|
|||
|
||||
// bspatch.cpp
|
||||
void ShowBSDiffLicense();
|
||||
int ApplyBSDiffPatch(const unsigned char* old_data, ssize_t old_size,
|
||||
const Value* patch, ssize_t patch_offset,
|
||||
SinkFn sink, void* token, SHA_CTX* ctx);
|
||||
int ApplyBSDiffPatchMem(const unsigned char* old_data, ssize_t old_size,
|
||||
const Value* patch, ssize_t patch_offset,
|
||||
std::vector<unsigned char>* new_data);
|
||||
int ApplyBSDiffPatch(const unsigned char* old_data, size_t old_size, const Value* patch,
|
||||
size_t patch_offset, SinkFn sink, SHA_CTX* ctx);
|
||||
int ApplyBSDiffPatchMem(const unsigned char* old_data, size_t old_size, const Value* patch,
|
||||
size_t patch_offset, std::vector<unsigned char>* new_data);
|
||||
|
||||
// imgpatch.cpp
|
||||
int ApplyImagePatch(const unsigned char* old_data, ssize_t old_size,
|
||||
const Value* patch,
|
||||
SinkFn sink, void* token, SHA_CTX* ctx,
|
||||
const Value* bonus_data);
|
||||
int ApplyImagePatch(const unsigned char* old_data, size_t old_size, const Value* patch, SinkFn sink,
|
||||
SHA_CTX* ctx, const Value* bonus_data);
|
||||
|
||||
// freecache.cpp
|
||||
int MakeFreeSpaceOnCache(size_t bytes_needed);
|
||||
|
|
|
@ -19,10 +19,11 @@
|
|||
|
||||
#include <sys/types.h>
|
||||
|
||||
using SinkFn = ssize_t (*)(const unsigned char*, ssize_t, void*);
|
||||
#include <functional>
|
||||
|
||||
int ApplyImagePatch(const unsigned char* old_data, ssize_t old_size,
|
||||
const unsigned char* patch_data, ssize_t patch_size,
|
||||
SinkFn sink, void* token);
|
||||
using SinkFn = std::function<size_t(const unsigned char*, size_t)>;
|
||||
|
||||
int ApplyImagePatch(const unsigned char* old_data, size_t old_size, const unsigned char* patch_data,
|
||||
size_t patch_size, SinkFn sink);
|
||||
|
||||
#endif // _APPLYPATCH_IMGPATCH_H
|
||||
|
|
|
@ -14,6 +14,8 @@
|
|||
* limitations under the License.
|
||||
*/
|
||||
|
||||
#include <stdio.h>
|
||||
|
||||
#include <string>
|
||||
#include <vector>
|
||||
|
||||
|
@ -27,12 +29,6 @@
|
|||
|
||||
using android::base::get_unaligned;
|
||||
|
||||
static ssize_t MemorySink(const unsigned char* data, ssize_t len, void* token) {
|
||||
std::string* s = static_cast<std::string*>(token);
|
||||
s->append(reinterpret_cast<const char*>(data), len);
|
||||
return len;
|
||||
}
|
||||
|
||||
// Sanity check for the given imgdiff patch header.
|
||||
static void verify_patch_header(const std::string& patch, size_t* num_normal, size_t* num_raw,
|
||||
size_t* num_deflate) {
|
||||
|
@ -79,6 +75,18 @@ static void verify_patch_header(const std::string& patch, size_t* num_normal, si
|
|||
if (num_deflate != nullptr) *num_deflate = deflate;
|
||||
}
|
||||
|
||||
static void verify_patched_image(const std::string& src, const std::string& patch,
|
||||
const std::string& tgt) {
|
||||
std::string patched;
|
||||
ASSERT_EQ(0, ApplyImagePatch(reinterpret_cast<const unsigned char*>(src.data()), src.size(),
|
||||
reinterpret_cast<const unsigned char*>(patch.data()), patch.size(),
|
||||
[&patched](const unsigned char* data, size_t len) {
|
||||
patched.append(reinterpret_cast<const char*>(data), len);
|
||||
return len;
|
||||
}));
|
||||
ASSERT_EQ(tgt, patched);
|
||||
}
|
||||
|
||||
TEST(ImgdiffTest, invalid_args) {
|
||||
// Insufficient inputs.
|
||||
ASSERT_EQ(2, imgdiff(1, (const char* []){ "imgdiff" }));
|
||||
|
@ -124,11 +132,7 @@ TEST(ImgdiffTest, image_mode_smoke) {
|
|||
ASSERT_EQ(0U, num_deflate);
|
||||
ASSERT_EQ(1U, num_raw);
|
||||
|
||||
std::string patched;
|
||||
ASSERT_EQ(0, ApplyImagePatch(reinterpret_cast<const unsigned char*>(src.data()), src.size(),
|
||||
reinterpret_cast<const unsigned char*>(patch.data()), patch.size(),
|
||||
MemorySink, &patched));
|
||||
ASSERT_EQ(tgt, patched);
|
||||
verify_patched_image(src, patch, tgt);
|
||||
}
|
||||
|
||||
TEST(ImgdiffTest, zip_mode_smoke_store) {
|
||||
|
@ -177,11 +181,7 @@ TEST(ImgdiffTest, zip_mode_smoke_store) {
|
|||
ASSERT_EQ(0U, num_deflate);
|
||||
ASSERT_EQ(1U, num_raw);
|
||||
|
||||
std::string patched;
|
||||
ASSERT_EQ(0, ApplyImagePatch(reinterpret_cast<const unsigned char*>(src.data()), src.size(),
|
||||
reinterpret_cast<const unsigned char*>(patch.data()), patch.size(),
|
||||
MemorySink, &patched));
|
||||
ASSERT_EQ(tgt, patched);
|
||||
verify_patched_image(src, patch, tgt);
|
||||
}
|
||||
|
||||
TEST(ImgdiffTest, zip_mode_smoke_compressed) {
|
||||
|
@ -230,11 +230,7 @@ TEST(ImgdiffTest, zip_mode_smoke_compressed) {
|
|||
ASSERT_EQ(1U, num_deflate);
|
||||
ASSERT_EQ(2U, num_raw);
|
||||
|
||||
std::string patched;
|
||||
ASSERT_EQ(0, ApplyImagePatch(reinterpret_cast<const unsigned char*>(src.data()), src.size(),
|
||||
reinterpret_cast<const unsigned char*>(patch.data()), patch.size(),
|
||||
MemorySink, &patched));
|
||||
ASSERT_EQ(tgt, patched);
|
||||
verify_patched_image(src, patch, tgt);
|
||||
}
|
||||
|
||||
TEST(ImgdiffTest, zip_mode_smoke_trailer_zeros) {
|
||||
|
@ -286,11 +282,7 @@ TEST(ImgdiffTest, zip_mode_smoke_trailer_zeros) {
|
|||
ASSERT_EQ(1U, num_deflate);
|
||||
ASSERT_EQ(2U, num_raw);
|
||||
|
||||
std::string patched;
|
||||
ASSERT_EQ(0, ApplyImagePatch(reinterpret_cast<const unsigned char*>(src.data()), src.size(),
|
||||
reinterpret_cast<const unsigned char*>(patch.data()), patch.size(),
|
||||
MemorySink, &patched));
|
||||
ASSERT_EQ(tgt, patched);
|
||||
verify_patched_image(src, patch, tgt);
|
||||
}
|
||||
|
||||
TEST(ImgdiffTest, image_mode_simple) {
|
||||
|
@ -333,11 +325,7 @@ TEST(ImgdiffTest, image_mode_simple) {
|
|||
ASSERT_EQ(1U, num_deflate);
|
||||
ASSERT_EQ(2U, num_raw);
|
||||
|
||||
std::string patched;
|
||||
ASSERT_EQ(0, ApplyImagePatch(reinterpret_cast<const unsigned char*>(src.data()), src.size(),
|
||||
reinterpret_cast<const unsigned char*>(patch.data()), patch.size(),
|
||||
MemorySink, &patched));
|
||||
ASSERT_EQ(tgt, patched);
|
||||
verify_patched_image(src, patch, tgt);
|
||||
}
|
||||
|
||||
TEST(ImgdiffTest, image_mode_different_num_chunks) {
|
||||
|
@ -413,11 +401,7 @@ TEST(ImgdiffTest, image_mode_merge_chunks) {
|
|||
ASSERT_EQ(1U, num_deflate);
|
||||
ASSERT_EQ(2U, num_raw);
|
||||
|
||||
std::string patched;
|
||||
ASSERT_EQ(0, ApplyImagePatch(reinterpret_cast<const unsigned char*>(src.data()), src.size(),
|
||||
reinterpret_cast<const unsigned char*>(patch.data()), patch.size(),
|
||||
MemorySink, &patched));
|
||||
ASSERT_EQ(tgt, patched);
|
||||
verify_patched_image(src, patch, tgt);
|
||||
}
|
||||
|
||||
TEST(ImgdiffTest, image_mode_spurious_magic) {
|
||||
|
@ -454,11 +438,7 @@ TEST(ImgdiffTest, image_mode_spurious_magic) {
|
|||
ASSERT_EQ(0U, num_deflate);
|
||||
ASSERT_EQ(1U, num_raw);
|
||||
|
||||
std::string patched;
|
||||
ASSERT_EQ(0, ApplyImagePatch(reinterpret_cast<const unsigned char*>(src.data()), src.size(),
|
||||
reinterpret_cast<const unsigned char*>(patch.data()), patch.size(),
|
||||
MemorySink, &patched));
|
||||
ASSERT_EQ(tgt, patched);
|
||||
verify_patched_image(src, patch, tgt);
|
||||
}
|
||||
|
||||
TEST(ImgdiffTest, image_mode_short_input1) {
|
||||
|
@ -494,11 +474,7 @@ TEST(ImgdiffTest, image_mode_short_input1) {
|
|||
ASSERT_EQ(0U, num_deflate);
|
||||
ASSERT_EQ(1U, num_raw);
|
||||
|
||||
std::string patched;
|
||||
ASSERT_EQ(0, ApplyImagePatch(reinterpret_cast<const unsigned char*>(src.data()), src.size(),
|
||||
reinterpret_cast<const unsigned char*>(patch.data()), patch.size(),
|
||||
MemorySink, &patched));
|
||||
ASSERT_EQ(tgt, patched);
|
||||
verify_patched_image(src, patch, tgt);
|
||||
}
|
||||
|
||||
TEST(ImgdiffTest, image_mode_short_input2) {
|
||||
|
@ -534,11 +510,7 @@ TEST(ImgdiffTest, image_mode_short_input2) {
|
|||
ASSERT_EQ(0U, num_deflate);
|
||||
ASSERT_EQ(1U, num_raw);
|
||||
|
||||
std::string patched;
|
||||
ASSERT_EQ(0, ApplyImagePatch(reinterpret_cast<const unsigned char*>(src.data()), src.size(),
|
||||
reinterpret_cast<const unsigned char*>(patch.data()), patch.size(),
|
||||
MemorySink, &patched));
|
||||
ASSERT_EQ(tgt, patched);
|
||||
verify_patched_image(src, patch, tgt);
|
||||
}
|
||||
|
||||
TEST(ImgdiffTest, image_mode_single_entry_long) {
|
||||
|
@ -577,9 +549,5 @@ TEST(ImgdiffTest, image_mode_single_entry_long) {
|
|||
ASSERT_EQ(0U, num_deflate);
|
||||
ASSERT_EQ(0U, num_raw);
|
||||
|
||||
std::string patched;
|
||||
ASSERT_EQ(0, ApplyImagePatch(reinterpret_cast<const unsigned char*>(src.data()), src.size(),
|
||||
reinterpret_cast<const unsigned char*>(patch.data()), patch.size(),
|
||||
MemorySink, &patched));
|
||||
ASSERT_EQ(tgt, patched);
|
||||
verify_patched_image(src, patch, tgt);
|
||||
}
|
||||
|
|
|
@ -240,57 +240,54 @@ struct RangeSinkState {
|
|||
size_t p_remain;
|
||||
};
|
||||
|
||||
static ssize_t RangeSinkWrite(const uint8_t* data, ssize_t size, void* token) {
|
||||
RangeSinkState* rss = reinterpret_cast<RangeSinkState*>(token);
|
||||
static size_t RangeSinkWrite(const uint8_t* data, size_t size, RangeSinkState* rss) {
|
||||
if (rss->p_remain == 0) {
|
||||
LOG(ERROR) << "range sink write overrun";
|
||||
return 0;
|
||||
}
|
||||
|
||||
size_t written = 0;
|
||||
while (size > 0) {
|
||||
size_t write_now = size;
|
||||
|
||||
if (rss->p_remain < write_now) {
|
||||
write_now = rss->p_remain;
|
||||
}
|
||||
|
||||
if (write_all(rss->fd, data, write_now) == -1) {
|
||||
break;
|
||||
}
|
||||
|
||||
data += write_now;
|
||||
size -= write_now;
|
||||
|
||||
rss->p_remain -= write_now;
|
||||
written += write_now;
|
||||
|
||||
if (rss->p_remain == 0) {
|
||||
LOG(ERROR) << "range sink write overrun";
|
||||
return 0;
|
||||
// Move to the next block.
|
||||
++rss->p_block;
|
||||
if (rss->p_block < rss->tgt.count) {
|
||||
rss->p_remain =
|
||||
(rss->tgt.pos[rss->p_block * 2 + 1] - rss->tgt.pos[rss->p_block * 2]) * BLOCKSIZE;
|
||||
|
||||
off64_t offset = static_cast<off64_t>(rss->tgt.pos[rss->p_block * 2]) * BLOCKSIZE;
|
||||
if (!discard_blocks(rss->fd, offset, rss->p_remain)) {
|
||||
break;
|
||||
}
|
||||
|
||||
if (!check_lseek(rss->fd, offset, SEEK_SET)) {
|
||||
break;
|
||||
}
|
||||
|
||||
} else {
|
||||
// We can't write any more; return how many bytes have been written so far.
|
||||
break;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
ssize_t written = 0;
|
||||
while (size > 0) {
|
||||
size_t write_now = size;
|
||||
|
||||
if (rss->p_remain < write_now) {
|
||||
write_now = rss->p_remain;
|
||||
}
|
||||
|
||||
if (write_all(rss->fd, data, write_now) == -1) {
|
||||
break;
|
||||
}
|
||||
|
||||
data += write_now;
|
||||
size -= write_now;
|
||||
|
||||
rss->p_remain -= write_now;
|
||||
written += write_now;
|
||||
|
||||
if (rss->p_remain == 0) {
|
||||
// move to the next block
|
||||
++rss->p_block;
|
||||
if (rss->p_block < rss->tgt.count) {
|
||||
rss->p_remain = (rss->tgt.pos[rss->p_block * 2 + 1] -
|
||||
rss->tgt.pos[rss->p_block * 2]) * BLOCKSIZE;
|
||||
|
||||
off64_t offset = static_cast<off64_t>(rss->tgt.pos[rss->p_block*2]) * BLOCKSIZE;
|
||||
if (!discard_blocks(rss->fd, offset, rss->p_remain)) {
|
||||
break;
|
||||
}
|
||||
|
||||
if (!check_lseek(rss->fd, offset, SEEK_SET)) {
|
||||
break;
|
||||
}
|
||||
|
||||
} else {
|
||||
// we can't write any more; return how many bytes have
|
||||
// been written so far.
|
||||
break;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
return written;
|
||||
return written;
|
||||
}
|
||||
|
||||
// All of the data for all the 'new' transfers is contained in one
|
||||
|
@ -338,7 +335,7 @@ static bool receive_new_data(const uint8_t* data, size_t size, void* cookie) {
|
|||
|
||||
// At this point nti->rss is set, and we own it. The main
|
||||
// thread is waiting for it to disappear from nti.
|
||||
ssize_t written = RangeSinkWrite(data, size, nti->rss);
|
||||
size_t written = RangeSinkWrite(data, size, nti->rss);
|
||||
data += written;
|
||||
size -= written;
|
||||
|
||||
|
@ -1259,92 +1256,95 @@ static int PerformCommandNew(CommandParameters& params) {
|
|||
}
|
||||
|
||||
static int PerformCommandDiff(CommandParameters& params) {
|
||||
// <offset> <length>
|
||||
if (params.cpos + 1 >= params.tokens.size()) {
|
||||
LOG(ERROR) << "missing patch offset or length for " << params.cmdname;
|
||||
return -1;
|
||||
}
|
||||
|
||||
// <offset> <length>
|
||||
if (params.cpos + 1 >= params.tokens.size()) {
|
||||
LOG(ERROR) << "missing patch offset or length for " << params.cmdname;
|
||||
return -1;
|
||||
}
|
||||
size_t offset;
|
||||
if (!android::base::ParseUint(params.tokens[params.cpos++], &offset)) {
|
||||
LOG(ERROR) << "invalid patch offset";
|
||||
return -1;
|
||||
}
|
||||
|
||||
size_t offset;
|
||||
if (!android::base::ParseUint(params.tokens[params.cpos++], &offset)) {
|
||||
LOG(ERROR) << "invalid patch offset";
|
||||
return -1;
|
||||
}
|
||||
size_t len;
|
||||
if (!android::base::ParseUint(params.tokens[params.cpos++], &len)) {
|
||||
LOG(ERROR) << "invalid patch len";
|
||||
return -1;
|
||||
}
|
||||
|
||||
size_t len;
|
||||
if (!android::base::ParseUint(params.tokens[params.cpos++], &len)) {
|
||||
LOG(ERROR) << "invalid patch len";
|
||||
return -1;
|
||||
}
|
||||
RangeSet tgt;
|
||||
size_t blocks = 0;
|
||||
bool overlap = false;
|
||||
int status = LoadSrcTgtVersion3(params, tgt, &blocks, false, &overlap);
|
||||
|
||||
RangeSet tgt;
|
||||
size_t blocks = 0;
|
||||
bool overlap = false;
|
||||
int status = LoadSrcTgtVersion3(params, tgt, &blocks, false, &overlap);
|
||||
if (status == -1) {
|
||||
LOG(ERROR) << "failed to read blocks for diff";
|
||||
return -1;
|
||||
}
|
||||
|
||||
if (status == -1) {
|
||||
LOG(ERROR) << "failed to read blocks for diff";
|
||||
return -1;
|
||||
}
|
||||
if (status == 0) {
|
||||
params.foundwrites = true;
|
||||
} else if (params.foundwrites) {
|
||||
LOG(WARNING) << "warning: commands executed out of order [" << params.cmdname << "]";
|
||||
}
|
||||
|
||||
if (params.canwrite) {
|
||||
if (status == 0) {
|
||||
params.foundwrites = true;
|
||||
} else if (params.foundwrites) {
|
||||
LOG(WARNING) << "warning: commands executed out of order [" << params.cmdname << "]";
|
||||
}
|
||||
LOG(INFO) << "patching " << blocks << " blocks to " << tgt.size;
|
||||
Value patch_value(
|
||||
VAL_BLOB, std::string(reinterpret_cast<const char*>(params.patch_start + offset), len));
|
||||
RangeSinkState rss(tgt);
|
||||
rss.fd = params.fd;
|
||||
rss.p_block = 0;
|
||||
rss.p_remain = (tgt.pos[1] - tgt.pos[0]) * BLOCKSIZE;
|
||||
|
||||
if (params.canwrite) {
|
||||
if (status == 0) {
|
||||
LOG(INFO) << "patching " << blocks << " blocks to " << tgt.size;
|
||||
Value patch_value(VAL_BLOB,
|
||||
std::string(reinterpret_cast<const char*>(params.patch_start + offset), len));
|
||||
RangeSinkState rss(tgt);
|
||||
rss.fd = params.fd;
|
||||
rss.p_block = 0;
|
||||
rss.p_remain = (tgt.pos[1] - tgt.pos[0]) * BLOCKSIZE;
|
||||
off64_t offset = static_cast<off64_t>(tgt.pos[0]) * BLOCKSIZE;
|
||||
if (!discard_blocks(params.fd, offset, rss.p_remain)) {
|
||||
return -1;
|
||||
}
|
||||
|
||||
off64_t offset = static_cast<off64_t>(tgt.pos[0]) * BLOCKSIZE;
|
||||
if (!discard_blocks(params.fd, offset, rss.p_remain)) {
|
||||
return -1;
|
||||
}
|
||||
if (!check_lseek(params.fd, offset, SEEK_SET)) {
|
||||
return -1;
|
||||
}
|
||||
|
||||
if (!check_lseek(params.fd, offset, SEEK_SET)) {
|
||||
return -1;
|
||||
}
|
||||
|
||||
if (params.cmdname[0] == 'i') { // imgdiff
|
||||
if (ApplyImagePatch(params.buffer.data(), blocks * BLOCKSIZE, &patch_value,
|
||||
&RangeSinkWrite, &rss, nullptr, nullptr) != 0) {
|
||||
LOG(ERROR) << "Failed to apply image patch.";
|
||||
return -1;
|
||||
}
|
||||
} else {
|
||||
if (ApplyBSDiffPatch(params.buffer.data(), blocks * BLOCKSIZE, &patch_value,
|
||||
0, &RangeSinkWrite, &rss, nullptr) != 0) {
|
||||
LOG(ERROR) << "Failed to apply bsdiff patch.";
|
||||
return -1;
|
||||
}
|
||||
}
|
||||
|
||||
// We expect the output of the patcher to fill the tgt ranges exactly.
|
||||
if (rss.p_block != tgt.count || rss.p_remain != 0) {
|
||||
LOG(ERROR) << "range sink underrun?";
|
||||
}
|
||||
} else {
|
||||
LOG(INFO) << "skipping " << blocks << " blocks already patched to " << tgt.size
|
||||
<< " [" << params.cmdline << "]";
|
||||
if (params.cmdname[0] == 'i') { // imgdiff
|
||||
if (ApplyImagePatch(
|
||||
params.buffer.data(), blocks * BLOCKSIZE, &patch_value,
|
||||
std::bind(&RangeSinkWrite, std::placeholders::_1, std::placeholders::_2, &rss),
|
||||
nullptr, nullptr) != 0) {
|
||||
LOG(ERROR) << "Failed to apply image patch.";
|
||||
return -1;
|
||||
}
|
||||
} else {
|
||||
if (ApplyBSDiffPatch(
|
||||
params.buffer.data(), blocks * BLOCKSIZE, &patch_value, 0,
|
||||
std::bind(&RangeSinkWrite, std::placeholders::_1, std::placeholders::_2, &rss),
|
||||
nullptr) != 0) {
|
||||
LOG(ERROR) << "Failed to apply bsdiff patch.";
|
||||
return -1;
|
||||
}
|
||||
}
|
||||
|
||||
// We expect the output of the patcher to fill the tgt ranges exactly.
|
||||
if (rss.p_block != tgt.count || rss.p_remain != 0) {
|
||||
LOG(ERROR) << "range sink underrun?";
|
||||
}
|
||||
} else {
|
||||
LOG(INFO) << "skipping " << blocks << " blocks already patched to " << tgt.size << " ["
|
||||
<< params.cmdline << "]";
|
||||
}
|
||||
}
|
||||
|
||||
if (!params.freestash.empty()) {
|
||||
FreeStash(params.stashbase, params.freestash);
|
||||
params.freestash.clear();
|
||||
}
|
||||
if (!params.freestash.empty()) {
|
||||
FreeStash(params.stashbase, params.freestash);
|
||||
params.freestash.clear();
|
||||
}
|
||||
|
||||
params.written += tgt.size;
|
||||
params.written += tgt.size;
|
||||
|
||||
return 0;
|
||||
return 0;
|
||||
}
|
||||
|
||||
static int PerformCommandErase(CommandParameters& params) {
|
||||
|
|
Loading…
Reference in a new issue