tequilaOS/platform_bootable_recovery
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix wrong key indexes in package verification logs.

Browse source 
If the verification fails with the key, 'continue' will be performed and
the increment of the index at the end of the loop will be skipped.
This CL fixes it.

Test: check the log and see correct key indexes.
Change-Id: I3d1b2b8b4189f5fedbf8828f5e8e0d0b2e277c6a
This commit is contained in:
Jacky Liu 2021-12-29 12:09:06 +08:00
parent 86df64785a
commit 5ffad4b00b
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
otautil/verifier.cpp
View file

@ -257,8 +257,8 @@ int verify_file(VerifierInterface* package, const std::vector<Certificate>& keys
// Check to make sure at least one of the keys matches the signature. Since any key can match,
// we need to try each before determining a verification failure has happened.
size_t i = 0;
for (const auto& key : keys) {
for (size_t i = 0; i < keys.size(); i++) {
const auto& key = keys[i];
const uint8_t* hash;
int hash_nid;
switch (key.hash_len) {
@ -296,7 +296,6 @@ int verify_file(VerifierInterface* package, const std::vector<Certificate>& keys
} else {
LOG(INFO) << "Unknown key type " << key.key_type;
}
i++;
}
if (need_sha1) {