From 6929e4e5dcb158f4538fa1a0b91b1ad925cef9cb Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Tue, 19 Mar 2024 01:42:58 +0000 Subject: [PATCH] Fix connect() retry loop. This would succeed eventually anyway: the first time round the connect() succeeds, returns 0, and we go around the loop again; the second time the connect() fails (because we're already connected), returns -1, and we set success to true and exit the loop. But this means that the intended retry functionality is broken. Change-Id: If631d59e23b12e9aa952cdb528160b19b9a94b1c --- tests/unit/uncrypt_test.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit/uncrypt_test.cpp b/tests/unit/uncrypt_test.cpp index e97d589a..88fd16a2 100644 --- a/tests/unit/uncrypt_test.cpp +++ b/tests/unit/uncrypt_test.cpp @@ -96,7 +96,7 @@ class UncryptTest : public ::testing::Test { // Connect to the uncrypt socket. bool success = false; for (int retry = 0; retry < SOCKET_CONNECTION_MAX_RETRY; retry++) { - if (connect(sockfd, reinterpret_cast(&un), sizeof(sockaddr_un)) != 0) { + if (connect(sockfd, reinterpret_cast(&un), sizeof(sockaddr_un)) == 0) { success = true; break; }