refactor applypatch and friends
Change the applypatch function to take meaningful arguments instead of argc and argv. Move all the parsing of arguments into main.c (for the standalone binary) and into install.c (for the updater function). applypatch() takes patches as Value objects, so we can pass in blobs extracted from the package without ever writing them to temp files. The patching code is changed to read the patch from memory instead of a file. A bunch of compiler warnings (mostly about signed vs unsigned types) are fixed. Support for the IMGDIFF1 format is dropped. (We've been generating IMGDIFF2 packages for some time now.) Change-Id: I217563c500012750f27110db821928a06211323f
This commit is contained in:
parent
583fc12c3d
commit
c4351c7910
12 changed files with 1285 additions and 1311 deletions
|
@ -29,6 +29,7 @@ include $(CLEAR_VARS)
|
|||
|
||||
LOCAL_SRC_FILES := main.c
|
||||
LOCAL_MODULE := applypatch
|
||||
LOCAL_C_INCLUDES += bootable/recovery
|
||||
LOCAL_STATIC_LIBRARIES += libapplypatch libmtdutils libmincrypt libbz
|
||||
LOCAL_SHARED_LIBRARIES += libz libcutils libstdc++ libc
|
||||
|
||||
|
@ -40,6 +41,7 @@ LOCAL_SRC_FILES := main.c
|
|||
LOCAL_MODULE := applypatch_static
|
||||
LOCAL_FORCE_STATIC_EXECUTABLE := true
|
||||
LOCAL_MODULE_TAGS := eng
|
||||
LOCAL_C_INCLUDES += bootable/recovery
|
||||
LOCAL_STATIC_LIBRARIES += libapplypatch libmtdutils libmincrypt libbz
|
||||
LOCAL_STATIC_LIBRARIES += libz libcutils libstdc++ libc
|
||||
|
||||
|
|
|
@ -28,6 +28,7 @@
|
|||
#include "mincrypt/sha.h"
|
||||
#include "applypatch.h"
|
||||
#include "mtdutils/mtdutils.h"
|
||||
#include "edify/expr.h"
|
||||
|
||||
int SaveFileContents(const char* filename, FileContents file);
|
||||
int LoadMTDContents(const char* filename, FileContents* file);
|
||||
|
@ -63,10 +64,10 @@ int LoadFileContents(const char* filename, FileContents* file) {
|
|||
return -1;
|
||||
}
|
||||
|
||||
size_t bytes_read = fread(file->data, 1, file->size, f);
|
||||
ssize_t bytes_read = fread(file->data, 1, file->size, f);
|
||||
if (bytes_read != file->size) {
|
||||
printf("short read of \"%s\" (%d bytes of %d)\n",
|
||||
filename, bytes_read, file->size);
|
||||
printf("short read of \"%s\" (%ld bytes of %ld)\n",
|
||||
filename, (long)bytes_read, (long)file->size);
|
||||
free(file->data);
|
||||
file->data = NULL;
|
||||
return -1;
|
||||
|
@ -268,10 +269,11 @@ int SaveFileContents(const char* filename, FileContents file) {
|
|||
return -1;
|
||||
}
|
||||
|
||||
size_t bytes_written = FileSink(file.data, file.size, &fd);
|
||||
ssize_t bytes_written = FileSink(file.data, file.size, &fd);
|
||||
if (bytes_written != file.size) {
|
||||
printf("short write of \"%s\" (%d bytes of %d) (%s)\n",
|
||||
filename, bytes_written, file.size, strerror(errno));
|
||||
printf("short write of \"%s\" (%ld bytes of %ld) (%s)\n",
|
||||
filename, (long)bytes_written, (long)file.size,
|
||||
strerror(errno));
|
||||
close(fd);
|
||||
return -1;
|
||||
}
|
||||
|
@ -375,61 +377,31 @@ int ParseSha1(const char* str, uint8_t* digest) {
|
|||
++pd;
|
||||
}
|
||||
}
|
||||
if (*ps != '\0' && *ps != ':') return -1;
|
||||
if (*ps != '\0') return -1;
|
||||
return 0;
|
||||
}
|
||||
|
||||
// Parse arguments (which should be of the form "<sha1>" or
|
||||
// "<sha1>:<filename>" into the array *patches, returning the number
|
||||
// of Patch objects in *num_patches. Return 0 on success.
|
||||
int ParseShaArgs(int argc, char** argv, Patch** patches, int* num_patches) {
|
||||
*num_patches = argc;
|
||||
*patches = malloc(*num_patches * sizeof(Patch));
|
||||
|
||||
int i;
|
||||
for (i = 0; i < *num_patches; ++i) {
|
||||
if (ParseSha1(argv[i], (*patches)[i].sha1) != 0) {
|
||||
printf("failed to parse sha1 \"%s\"\n", argv[i]);
|
||||
return -1;
|
||||
}
|
||||
if (argv[i][SHA_DIGEST_SIZE*2] == '\0') {
|
||||
(*patches)[i].patch_filename = NULL;
|
||||
} else if (argv[i][SHA_DIGEST_SIZE*2] == ':') {
|
||||
(*patches)[i].patch_filename = argv[i] + (SHA_DIGEST_SIZE*2+1);
|
||||
} else {
|
||||
printf("failed to parse filename \"%s\"\n", argv[i]);
|
||||
return -1;
|
||||
}
|
||||
}
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
// Search an array of Patch objects for one matching the given sha1.
|
||||
// Return the Patch object on success, or NULL if no match is found.
|
||||
const Patch* FindMatchingPatch(uint8_t* sha1, Patch* patches, int num_patches) {
|
||||
// Search an array of sha1 strings for one matching the given sha1.
|
||||
// Return the index of the match on success, or -1 if no match is
|
||||
// found.
|
||||
int FindMatchingPatch(uint8_t* sha1, char** const patch_sha1_str,
|
||||
int num_patches) {
|
||||
int i;
|
||||
uint8_t patch_sha1[SHA_DIGEST_SIZE];
|
||||
for (i = 0; i < num_patches; ++i) {
|
||||
if (memcmp(patches[i].sha1, sha1, SHA_DIGEST_SIZE) == 0) {
|
||||
return patches+i;
|
||||
if (ParseSha1(patch_sha1_str[i], patch_sha1) == 0 &&
|
||||
memcmp(patch_sha1, sha1, SHA_DIGEST_SIZE) == 0) {
|
||||
return i;
|
||||
}
|
||||
}
|
||||
return NULL;
|
||||
return -1;
|
||||
}
|
||||
|
||||
// Returns 0 if the contents of the file (argv[2]) or the cached file
|
||||
// match any of the sha1's on the command line (argv[3:]). Returns
|
||||
// nonzero otherwise.
|
||||
int CheckMode(int argc, char** argv) {
|
||||
if (argc < 3) {
|
||||
printf("no filename given\n");
|
||||
return 2;
|
||||
}
|
||||
|
||||
int num_patches;
|
||||
Patch* patches;
|
||||
if (ParseShaArgs(argc-3, argv+3, &patches, &num_patches) != 0) { return 1; }
|
||||
|
||||
int applypatch_check(const char* filename,
|
||||
int num_patches, char** const patch_sha1_str) {
|
||||
FileContents file;
|
||||
file.data = NULL;
|
||||
|
||||
|
@ -437,11 +409,11 @@ int CheckMode(int argc, char** argv) {
|
|||
// LoadFileContents is successful. (Useful for reading MTD
|
||||
// partitions, where the filename encodes the sha1s; no need to
|
||||
// check them twice.)
|
||||
if (LoadFileContents(argv[2], &file) != 0 ||
|
||||
if (LoadFileContents(filename, &file) != 0 ||
|
||||
(num_patches > 0 &&
|
||||
FindMatchingPatch(file.sha1, patches, num_patches) == NULL)) {
|
||||
FindMatchingPatch(file.sha1, patch_sha1_str, num_patches) < 0)) {
|
||||
printf("file \"%s\" doesn't have any of expected "
|
||||
"sha1 sums; checking cache\n", argv[2]);
|
||||
"sha1 sums; checking cache\n", filename);
|
||||
|
||||
free(file.data);
|
||||
|
||||
|
@ -456,9 +428,9 @@ int CheckMode(int argc, char** argv) {
|
|||
return 1;
|
||||
}
|
||||
|
||||
if (FindMatchingPatch(file.sha1, patches, num_patches) == NULL) {
|
||||
printf("cache bits don't match any sha1 for \"%s\"\n",
|
||||
argv[2]);
|
||||
if (FindMatchingPatch(file.sha1, patch_sha1_str, num_patches) < 0) {
|
||||
printf("cache bits don't match any sha1 for \"%s\"\n", filename);
|
||||
free(file.data);
|
||||
return 1;
|
||||
}
|
||||
}
|
||||
|
@ -484,7 +456,6 @@ ssize_t FileSink(unsigned char* data, ssize_t len, void* token) {
|
|||
}
|
||||
done += wrote;
|
||||
}
|
||||
printf("wrote %d bytes to output\n", (int)done);
|
||||
return done;
|
||||
}
|
||||
|
||||
|
@ -515,111 +486,66 @@ size_t FreeSpaceForFile(const char* filename) {
|
|||
return sf.f_bsize * sf.f_bfree;
|
||||
}
|
||||
|
||||
// This program applies binary patches to files in a way that is safe
|
||||
// (the original file is not touched until we have the desired
|
||||
// replacement for it) and idempotent (it's okay to run this program
|
||||
// multiple times).
|
||||
//
|
||||
// - if the sha1 hash of <tgt-file> is <tgt-sha1>, does nothing and exits
|
||||
// successfully.
|
||||
//
|
||||
// - otherwise, if the sha1 hash of <src-file> is <src-sha1>, applies the
|
||||
// bsdiff <patch> to <src-file> to produce a new file (the type of patch
|
||||
// is automatically detected from the file header). If that new
|
||||
// file has sha1 hash <tgt-sha1>, moves it to replace <tgt-file>, and
|
||||
// exits successfully. Note that if <src-file> and <tgt-file> are
|
||||
// not the same, <src-file> is NOT deleted on success. <tgt-file>
|
||||
// may be the string "-" to mean "the same as src-file".
|
||||
//
|
||||
// - otherwise, or if any error is encountered, exits with non-zero
|
||||
// status.
|
||||
//
|
||||
// <src-file> (or <file> in check mode) may refer to an MTD partition
|
||||
// to read the source data. See the comments for the
|
||||
// LoadMTDContents() function above for the format of such a filename.
|
||||
//
|
||||
//
|
||||
// As you might guess from the arguments, this function used to be
|
||||
// main(); it was split out this way so applypatch could be built as a
|
||||
// static library and linked into other executables as well. In the
|
||||
// future only the library form will exist; we will not need to build
|
||||
// this as a standalone executable.
|
||||
//
|
||||
// The arguments to this function are just the command-line of the
|
||||
// standalone executable:
|
||||
//
|
||||
// <src-file> <tgt-file> <tgt-sha1> <tgt-size> [<src-sha1>:<patch> ...]
|
||||
// to apply a patch. Returns 0 on success, 1 on failure.
|
||||
//
|
||||
// "-c" <file> [<sha1> ...]
|
||||
// to check a file's contents against zero or more sha1s. Returns
|
||||
// 0 if it matches any of them, 1 if it doesn't.
|
||||
//
|
||||
// "-s" <bytes>
|
||||
// returns 0 if enough free space is available on /cache; 1 if it
|
||||
// does not.
|
||||
//
|
||||
// "-l"
|
||||
// shows open-source license information and returns 0.
|
||||
//
|
||||
// This function returns 2 if the arguments are not understood (in the
|
||||
// standalone executable, this causes the usage message to be
|
||||
// printed).
|
||||
//
|
||||
// TODO: make the interface more sensible for use as a library.
|
||||
|
||||
int applypatch(int argc, char** argv) {
|
||||
if (argc < 2) {
|
||||
return 2;
|
||||
}
|
||||
|
||||
if (strncmp(argv[1], "-l", 3) == 0) {
|
||||
return ShowLicenses();
|
||||
}
|
||||
|
||||
if (strncmp(argv[1], "-c", 3) == 0) {
|
||||
return CheckMode(argc, argv);
|
||||
}
|
||||
|
||||
if (strncmp(argv[1], "-s", 3) == 0) {
|
||||
if (argc != 3) {
|
||||
return 2;
|
||||
}
|
||||
size_t bytes = strtol(argv[2], NULL, 10);
|
||||
int CacheSizeCheck(size_t bytes) {
|
||||
if (MakeFreeSpaceOnCache(bytes) < 0) {
|
||||
printf("unable to make %ld bytes available on /cache\n", (long)bytes);
|
||||
return 1;
|
||||
} else {
|
||||
return 0;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
uint8_t target_sha1[SHA_DIGEST_SIZE];
|
||||
|
||||
const char* source_filename = argv[1];
|
||||
const char* target_filename = argv[2];
|
||||
// This function applies binary patches to files in a way that is safe
|
||||
// (the original file is not touched until we have the desired
|
||||
// replacement for it) and idempotent (it's okay to run this program
|
||||
// multiple times).
|
||||
//
|
||||
// - if the sha1 hash of <target_filename> is <target_sha1_string>,
|
||||
// does nothing and exits successfully.
|
||||
//
|
||||
// - otherwise, if the sha1 hash of <source_filename> is one of the
|
||||
// entries in <patch_sha1_str>, the corresponding patch from
|
||||
// <patch_data> (which must be a VAL_BLOB) is applied to produce a
|
||||
// new file (the type of patch is automatically detected from the
|
||||
// blob daat). If that new file has sha1 hash <target_sha1_str>,
|
||||
// moves it to replace <target_filename>, and exits successfully.
|
||||
// Note that if <source_filename> and <target_filename> are not the
|
||||
// same, <source_filename> is NOT deleted on success.
|
||||
// <target_filename> may be the string "-" to mean "the same as
|
||||
// source_filename".
|
||||
//
|
||||
// - otherwise, or if any error is encountered, exits with non-zero
|
||||
// status.
|
||||
//
|
||||
// <source_filename> may refer to an MTD partition to read the source
|
||||
// data. See the comments for the LoadMTDContents() function above
|
||||
// for the format of such a filename.
|
||||
|
||||
int applypatch(const char* source_filename,
|
||||
const char* target_filename,
|
||||
const char* target_sha1_str,
|
||||
size_t target_size,
|
||||
int num_patches,
|
||||
char** const patch_sha1_str,
|
||||
Value** patch_data) {
|
||||
printf("\napplying patch to %s\n", source_filename);
|
||||
|
||||
if (target_filename[0] == '-' &&
|
||||
target_filename[1] == '\0') {
|
||||
target_filename = source_filename;
|
||||
}
|
||||
|
||||
printf("\napplying patch to %s\n", source_filename);
|
||||
|
||||
if (ParseSha1(argv[3], target_sha1) != 0) {
|
||||
printf("failed to parse tgt-sha1 \"%s\"\n", argv[3]);
|
||||
uint8_t target_sha1[SHA_DIGEST_SIZE];
|
||||
if (ParseSha1(target_sha1_str, target_sha1) != 0) {
|
||||
printf("failed to parse tgt-sha1 \"%s\"\n", target_sha1_str);
|
||||
return 1;
|
||||
}
|
||||
|
||||
unsigned long target_size = strtoul(argv[4], NULL, 0);
|
||||
|
||||
int num_patches;
|
||||
Patch* patches;
|
||||
if (ParseShaArgs(argc-5, argv+5, &patches, &num_patches) < 0) { return 1; }
|
||||
|
||||
FileContents copy_file;
|
||||
FileContents source_file;
|
||||
const char* source_patch_filename = NULL;
|
||||
const char* copy_patch_filename = NULL;
|
||||
const Value* source_patch_value = NULL;
|
||||
const Value* copy_patch_value = NULL;
|
||||
int made_copy = 0;
|
||||
|
||||
// We try to load the target file into the source_file object.
|
||||
|
@ -643,14 +569,14 @@ int applypatch(int argc, char** argv) {
|
|||
}
|
||||
|
||||
if (source_file.data != NULL) {
|
||||
const Patch* to_use =
|
||||
FindMatchingPatch(source_file.sha1, patches, num_patches);
|
||||
if (to_use != NULL) {
|
||||
source_patch_filename = to_use->patch_filename;
|
||||
int to_use = FindMatchingPatch(source_file.sha1,
|
||||
patch_sha1_str, num_patches);
|
||||
if (to_use >= 0) {
|
||||
source_patch_value = patch_data[to_use];
|
||||
}
|
||||
}
|
||||
|
||||
if (source_patch_filename == NULL) {
|
||||
if (source_patch_value == NULL) {
|
||||
free(source_file.data);
|
||||
printf("source file is bad; trying copy\n");
|
||||
|
||||
|
@ -660,13 +586,13 @@ int applypatch(int argc, char** argv) {
|
|||
return 1;
|
||||
}
|
||||
|
||||
const Patch* to_use =
|
||||
FindMatchingPatch(copy_file.sha1, patches, num_patches);
|
||||
if (to_use != NULL) {
|
||||
copy_patch_filename = to_use->patch_filename;
|
||||
int to_use = FindMatchingPatch(copy_file.sha1,
|
||||
patch_sha1_str, num_patches);
|
||||
if (to_use > 0) {
|
||||
copy_patch_value = patch_data[to_use];
|
||||
}
|
||||
|
||||
if (copy_patch_filename == NULL) {
|
||||
if (copy_patch_value == NULL) {
|
||||
// fail.
|
||||
printf("copy file doesn't match source SHA-1s either\n");
|
||||
return 1;
|
||||
|
@ -729,7 +655,7 @@ int applypatch(int argc, char** argv) {
|
|||
retry = 0;
|
||||
}
|
||||
|
||||
if (!enough_space && source_patch_filename != NULL) {
|
||||
if (!enough_space && source_patch_value != NULL) {
|
||||
// Using the original source, but not enough free space. First
|
||||
// copy the source file to cache, then delete it from the original
|
||||
// location.
|
||||
|
@ -759,13 +685,18 @@ int applypatch(int argc, char** argv) {
|
|||
}
|
||||
}
|
||||
|
||||
const char* patch_filename;
|
||||
if (source_patch_filename != NULL) {
|
||||
const Value* patch;
|
||||
if (source_patch_value != NULL) {
|
||||
source_to_use = &source_file;
|
||||
patch_filename = source_patch_filename;
|
||||
patch = source_patch_value;
|
||||
} else {
|
||||
source_to_use = ©_file;
|
||||
patch_filename = copy_patch_filename;
|
||||
patch = copy_patch_value;
|
||||
}
|
||||
|
||||
if (patch->type != VAL_BLOB) {
|
||||
printf("patch is not a blob\n");
|
||||
return 1;
|
||||
}
|
||||
|
||||
SinkFn sink = NULL;
|
||||
|
@ -800,37 +731,21 @@ int applypatch(int argc, char** argv) {
|
|||
token = &output;
|
||||
}
|
||||
|
||||
#define MAX_HEADER_LENGTH 8
|
||||
unsigned char header[MAX_HEADER_LENGTH];
|
||||
FILE* patchf = fopen(patch_filename, "rb");
|
||||
if (patchf == NULL) {
|
||||
printf("failed to open patch file %s: %s\n",
|
||||
patch_filename, strerror(errno));
|
||||
return 1;
|
||||
}
|
||||
int header_bytes_read = fread(header, 1, MAX_HEADER_LENGTH, patchf);
|
||||
fclose(patchf);
|
||||
char* header = patch->data;
|
||||
ssize_t header_bytes_read = patch->size;
|
||||
|
||||
SHA_init(&ctx);
|
||||
|
||||
int result;
|
||||
|
||||
if (header_bytes_read >= 4 &&
|
||||
header[0] == 0xd6 && header[1] == 0xc3 &&
|
||||
header[2] == 0xc4 && header[3] == 0) {
|
||||
// xdelta3 patches begin "VCD" (with the high bits set) followed
|
||||
// by a zero byte (the version number).
|
||||
printf("error: xdelta3 patches no longer supported\n");
|
||||
return 1;
|
||||
} else if (header_bytes_read >= 8 &&
|
||||
if (header_bytes_read >= 8 &&
|
||||
memcmp(header, "BSDIFF40", 8) == 0) {
|
||||
result = ApplyBSDiffPatch(source_to_use->data, source_to_use->size,
|
||||
patch_filename, 0, sink, token, &ctx);
|
||||
patch, 0, sink, token, &ctx);
|
||||
} else if (header_bytes_read >= 8 &&
|
||||
memcmp(header, "IMGDIFF", 7) == 0 &&
|
||||
(header[7] == '1' || header[7] == '2')) {
|
||||
memcmp(header, "IMGDIFF2", 8) == 0) {
|
||||
result = ApplyImagePatch(source_to_use->data, source_to_use->size,
|
||||
patch_filename, sink, token, &ctx);
|
||||
patch, sink, token, &ctx);
|
||||
} else {
|
||||
printf("Unknown patch file format\n");
|
||||
return 1;
|
||||
|
|
|
@ -19,6 +19,7 @@
|
|||
|
||||
#include <sys/stat.h>
|
||||
#include "mincrypt/sha.h"
|
||||
#include "edify/expr.h"
|
||||
|
||||
typedef struct _Patch {
|
||||
uint8_t sha1[SHA_DIGEST_SIZE];
|
||||
|
@ -42,8 +43,21 @@ typedef struct _FileContents {
|
|||
typedef ssize_t (*SinkFn)(unsigned char*, ssize_t, void*);
|
||||
|
||||
// applypatch.c
|
||||
int ShowLicenses();
|
||||
size_t FreeSpaceForFile(const char* filename);
|
||||
int applypatch(int argc, char** argv);
|
||||
int CacheSizeCheck(size_t bytes);
|
||||
int ParseSha1(const char* str, uint8_t* digest);
|
||||
|
||||
int applypatch(const char* source_filename,
|
||||
const char* target_filename,
|
||||
const char* target_sha1_str,
|
||||
size_t target_size,
|
||||
int num_patches,
|
||||
char** const patch_sha1_str,
|
||||
Value** patch_data);
|
||||
int applypatch_check(const char* filename,
|
||||
int num_patches,
|
||||
char** const patch_sha1_str);
|
||||
|
||||
// Read a file into memory; store it and its associated metadata in
|
||||
// *file. Return 0 on success.
|
||||
|
@ -53,15 +67,15 @@ void FreeFileContents(FileContents* file);
|
|||
// bsdiff.c
|
||||
void ShowBSDiffLicense();
|
||||
int ApplyBSDiffPatch(const unsigned char* old_data, ssize_t old_size,
|
||||
const char* patch_filename, ssize_t offset,
|
||||
const Value* patch, ssize_t patch_offset,
|
||||
SinkFn sink, void* token, SHA_CTX* ctx);
|
||||
int ApplyBSDiffPatchMem(const unsigned char* old_data, ssize_t old_size,
|
||||
const char* patch_filename, ssize_t patch_offset,
|
||||
const Value* patch, ssize_t patch_offset,
|
||||
unsigned char** new_data, ssize_t* new_size);
|
||||
|
||||
// imgpatch.c
|
||||
int ApplyImagePatch(const unsigned char* old_data, ssize_t old_size,
|
||||
const char* patch_filename,
|
||||
const Value* patch,
|
||||
SinkFn sink, void* token, SHA_CTX* ctx);
|
||||
|
||||
// freecache.c
|
||||
|
|
|
@ -11,7 +11,7 @@
|
|||
# the tests.
|
||||
|
||||
EMULATOR_PORT=5580
|
||||
DATA_DIR=$ANDROID_BUILD_TOP/build/tools/applypatch/testdata
|
||||
DATA_DIR=$ANDROID_BUILD_TOP/bootable/recovery/applypatch/testdata
|
||||
|
||||
# This must be the filename that applypatch uses for its copies.
|
||||
CACHE_TEMP_SOURCE=/cache/saved.file
|
||||
|
@ -81,6 +81,7 @@ cleanup() {
|
|||
testname "removing test files"
|
||||
run_command rm $WORK_DIR/bloat.dat
|
||||
run_command rm $WORK_DIR/old.file
|
||||
run_command rm $WORK_DIR/foo
|
||||
run_command rm $WORK_DIR/patch.bsdiff
|
||||
run_command rm $WORK_DIR/applypatch
|
||||
run_command rm $CACHE_TEMP_SOURCE
|
||||
|
@ -88,10 +89,12 @@ cleanup() {
|
|||
|
||||
[ "$pid_emulator" == "" ] || kill $pid_emulator
|
||||
|
||||
if [ $# == 0 ]; then
|
||||
rm -rf $tmpdir
|
||||
fi
|
||||
}
|
||||
|
||||
cleanup
|
||||
cleanup leave_tmp
|
||||
|
||||
$ADB push $ANDROID_PRODUCT_OUT/system/bin/applypatch $WORK_DIR/applypatch
|
||||
|
||||
|
@ -153,6 +156,8 @@ run_command $WORK_DIR/applypatch -c $WORK_DIR/old.file $BAD2_SHA1 $BAD1_SHA1 &&
|
|||
|
||||
$ADB push $DATA_DIR/old.file $WORK_DIR
|
||||
$ADB push $DATA_DIR/patch.bsdiff $WORK_DIR
|
||||
echo hello > $tmpdir/foo
|
||||
$ADB push $tmpdir/foo $WORK_DIR
|
||||
|
||||
# Check that the partition has enough space to apply the patch without
|
||||
# copying. If it doesn't, we'll be testing the low-space condition
|
||||
|
|
|
@ -81,20 +81,35 @@ static off_t offtin(u_char *buf)
|
|||
return y;
|
||||
}
|
||||
|
||||
int FillBuffer(unsigned char* buffer, int size, bz_stream* stream) {
|
||||
stream->next_out = (char*)buffer;
|
||||
stream->avail_out = size;
|
||||
while (stream->avail_out > 0) {
|
||||
int bzerr = BZ2_bzDecompress(stream);
|
||||
if (bzerr != BZ_OK && bzerr != BZ_STREAM_END) {
|
||||
printf("bz error %d decompressing\n", bzerr);
|
||||
return -1;
|
||||
}
|
||||
if (stream->avail_out > 0) {
|
||||
printf("need %d more bytes\n", stream->avail_out);
|
||||
}
|
||||
}
|
||||
return 0;
|
||||
}
|
||||
|
||||
int ApplyBSDiffPatch(const unsigned char* old_data, ssize_t old_size,
|
||||
const char* patch_filename, ssize_t patch_offset,
|
||||
const Value* patch, ssize_t patch_offset,
|
||||
SinkFn sink, void* token, SHA_CTX* ctx) {
|
||||
|
||||
unsigned char* new_data;
|
||||
ssize_t new_size;
|
||||
if (ApplyBSDiffPatchMem(old_data, old_size, patch_filename, patch_offset,
|
||||
if (ApplyBSDiffPatchMem(old_data, old_size, patch, patch_offset,
|
||||
&new_data, &new_size) != 0) {
|
||||
return -1;
|
||||
}
|
||||
|
||||
if (sink(new_data, new_size, token) < new_size) {
|
||||
fprintf(stderr, "short write of output: %d (%s)\n", errno, strerror(errno));
|
||||
printf("short write of output: %d (%s)\n", errno, strerror(errno));
|
||||
return 1;
|
||||
}
|
||||
if (ctx) {
|
||||
|
@ -106,16 +121,9 @@ int ApplyBSDiffPatch(const unsigned char* old_data, ssize_t old_size,
|
|||
}
|
||||
|
||||
int ApplyBSDiffPatchMem(const unsigned char* old_data, ssize_t old_size,
|
||||
const char* patch_filename, ssize_t patch_offset,
|
||||
const Value* patch, ssize_t patch_offset,
|
||||
unsigned char** new_data, ssize_t* new_size) {
|
||||
|
||||
FILE* f;
|
||||
if ((f = fopen(patch_filename, "rb")) == NULL) {
|
||||
fprintf(stderr, "failed to open patch file\n");
|
||||
return 1;
|
||||
}
|
||||
|
||||
// File format:
|
||||
// Patch data format:
|
||||
// 0 8 "BSDIFF40"
|
||||
// 8 8 X
|
||||
// 16 8 Y
|
||||
|
@ -127,16 +135,9 @@ int ApplyBSDiffPatchMem(const unsigned char* old_data, ssize_t old_size,
|
|||
// from oldfile to x bytes from the diff block; copy y bytes from the
|
||||
// extra block; seek forwards in oldfile by z bytes".
|
||||
|
||||
fseek(f, patch_offset, SEEK_SET);
|
||||
|
||||
unsigned char header[32];
|
||||
if (fread(header, 1, 32, f) < 32) {
|
||||
fprintf(stderr, "failed to read patch file header\n");
|
||||
return 1;
|
||||
}
|
||||
|
||||
unsigned char* header = (unsigned char*) patch->data + patch_offset;
|
||||
if (memcmp(header, "BSDIFF40", 8) != 0) {
|
||||
fprintf(stderr, "corrupt bsdiff patch file header (magic number)\n");
|
||||
printf("corrupt bsdiff patch file header (magic number)\n");
|
||||
return 1;
|
||||
}
|
||||
|
||||
|
@ -146,40 +147,46 @@ int ApplyBSDiffPatchMem(const unsigned char* old_data, ssize_t old_size,
|
|||
*new_size = offtin(header+24);
|
||||
|
||||
if (ctrl_len < 0 || data_len < 0 || *new_size < 0) {
|
||||
fprintf(stderr, "corrupt patch file header (data lengths)\n");
|
||||
printf("corrupt patch file header (data lengths)\n");
|
||||
return 1;
|
||||
}
|
||||
|
||||
fclose(f);
|
||||
|
||||
int bzerr;
|
||||
|
||||
#define OPEN_AT(f, bzf, offset) \
|
||||
FILE* f; \
|
||||
BZFILE* bzf; \
|
||||
if ((f = fopen(patch_filename, "rb")) == NULL) { \
|
||||
fprintf(stderr, "failed to open patch file\n"); \
|
||||
return 1; \
|
||||
} \
|
||||
if (fseeko(f, offset+patch_offset, SEEK_SET)) { \
|
||||
fprintf(stderr, "failed to seek in patch file\n"); \
|
||||
return 1; \
|
||||
} \
|
||||
if ((bzf = BZ2_bzReadOpen(&bzerr, f, 0, 0, NULL, 0)) == NULL) { \
|
||||
fprintf(stderr, "failed to bzReadOpen in patch file (%d)\n", bzerr); \
|
||||
return 1; \
|
||||
bz_stream cstream;
|
||||
cstream.next_in = patch->data + patch_offset + 32;
|
||||
cstream.avail_in = ctrl_len;
|
||||
cstream.bzalloc = NULL;
|
||||
cstream.bzfree = NULL;
|
||||
cstream.opaque = NULL;
|
||||
if ((bzerr = BZ2_bzDecompressInit(&cstream, 0, 0)) != BZ_OK) {
|
||||
printf("failed to bzinit control stream (%d)\n", bzerr);
|
||||
}
|
||||
|
||||
OPEN_AT(cpf, cpfbz2, 32);
|
||||
OPEN_AT(dpf, dpfbz2, 32+ctrl_len);
|
||||
OPEN_AT(epf, epfbz2, 32+ctrl_len+data_len);
|
||||
bz_stream dstream;
|
||||
dstream.next_in = patch->data + patch_offset + 32 + ctrl_len;
|
||||
dstream.avail_in = data_len;
|
||||
dstream.bzalloc = NULL;
|
||||
dstream.bzfree = NULL;
|
||||
dstream.opaque = NULL;
|
||||
if ((bzerr = BZ2_bzDecompressInit(&dstream, 0, 0)) != BZ_OK) {
|
||||
printf("failed to bzinit diff stream (%d)\n", bzerr);
|
||||
}
|
||||
|
||||
#undef OPEN_AT
|
||||
bz_stream estream;
|
||||
estream.next_in = patch->data + patch_offset + 32 + ctrl_len + data_len;
|
||||
estream.avail_in = patch->size - (patch_offset + 32 + ctrl_len + data_len);
|
||||
estream.bzalloc = NULL;
|
||||
estream.bzfree = NULL;
|
||||
estream.opaque = NULL;
|
||||
if ((bzerr = BZ2_bzDecompressInit(&estream, 0, 0)) != BZ_OK) {
|
||||
printf("failed to bzinit extra stream (%d)\n", bzerr);
|
||||
}
|
||||
|
||||
*new_data = malloc(*new_size);
|
||||
if (*new_data == NULL) {
|
||||
fprintf(stderr, "failed to allocate %d bytes of memory for output file\n",
|
||||
(int)*new_size);
|
||||
printf("failed to allocate %ld bytes of memory for output file\n",
|
||||
(long)*new_size);
|
||||
return 1;
|
||||
}
|
||||
|
||||
|
@ -187,28 +194,26 @@ int ApplyBSDiffPatchMem(const unsigned char* old_data, ssize_t old_size,
|
|||
off_t ctrl[3];
|
||||
off_t len_read;
|
||||
int i;
|
||||
unsigned char buf[8];
|
||||
unsigned char buf[24];
|
||||
while (newpos < *new_size) {
|
||||
// Read control data
|
||||
for (i = 0; i < 3; ++i) {
|
||||
len_read = BZ2_bzRead(&bzerr, cpfbz2, buf, 8);
|
||||
if (len_read < 8 || !(bzerr == BZ_OK || bzerr == BZ_STREAM_END)) {
|
||||
fprintf(stderr, "corrupt patch (read control)\n");
|
||||
if (FillBuffer(buf, 24, &cstream) != 0) {
|
||||
printf("error while reading control stream\n");
|
||||
return 1;
|
||||
}
|
||||
ctrl[i] = offtin(buf);
|
||||
}
|
||||
ctrl[0] = offtin(buf);
|
||||
ctrl[1] = offtin(buf+8);
|
||||
ctrl[2] = offtin(buf+16);
|
||||
|
||||
// Sanity check
|
||||
if (newpos + ctrl[0] > *new_size) {
|
||||
fprintf(stderr, "corrupt patch (new file overrun)\n");
|
||||
printf("corrupt patch (new file overrun)\n");
|
||||
return 1;
|
||||
}
|
||||
|
||||
// Read diff string
|
||||
len_read = BZ2_bzRead(&bzerr, dpfbz2, *new_data + newpos, ctrl[0]);
|
||||
if (len_read < ctrl[0] || !(bzerr == BZ_OK || bzerr == BZ_STREAM_END)) {
|
||||
fprintf(stderr, "corrupt patch (read diff)\n");
|
||||
if (FillBuffer(*new_data + newpos, ctrl[0], &dstream) != 0) {
|
||||
printf("error while reading diff stream\n");
|
||||
return 1;
|
||||
}
|
||||
|
||||
|
@ -225,14 +230,13 @@ int ApplyBSDiffPatchMem(const unsigned char* old_data, ssize_t old_size,
|
|||
|
||||
// Sanity check
|
||||
if (newpos + ctrl[1] > *new_size) {
|
||||
fprintf(stderr, "corrupt patch (new file overrun)\n");
|
||||
printf("corrupt patch (new file overrun)\n");
|
||||
return 1;
|
||||
}
|
||||
|
||||
// Read extra string
|
||||
len_read = BZ2_bzRead(&bzerr, epfbz2, *new_data + newpos, ctrl[1]);
|
||||
if (len_read < ctrl[1] || !(bzerr == BZ_OK || bzerr == BZ_STREAM_END)) {
|
||||
fprintf(stderr, "corrupt patch (read extra)\n");
|
||||
if (FillBuffer(*new_data + newpos, ctrl[1], &estream) != 0) {
|
||||
printf("error while reading extra stream\n");
|
||||
return 1;
|
||||
}
|
||||
|
||||
|
@ -241,12 +245,8 @@ int ApplyBSDiffPatchMem(const unsigned char* old_data, ssize_t old_size,
|
|||
oldpos += ctrl[2];
|
||||
}
|
||||
|
||||
BZ2_bzReadClose(&bzerr, cpfbz2);
|
||||
BZ2_bzReadClose(&bzerr, dpfbz2);
|
||||
BZ2_bzReadClose(&bzerr, epfbz2);
|
||||
fclose(cpf);
|
||||
fclose(dpf);
|
||||
fclose(epf);
|
||||
|
||||
BZ2_bzDecompressEnd(&cstream);
|
||||
BZ2_bzDecompressEnd(&dstream);
|
||||
BZ2_bzDecompressEnd(&estream);
|
||||
return 0;
|
||||
}
|
||||
|
|
|
@ -36,24 +36,19 @@
|
|||
* Return 0 on success.
|
||||
*/
|
||||
int ApplyImagePatch(const unsigned char* old_data, ssize_t old_size,
|
||||
const char* patch_filename,
|
||||
const Value* patch,
|
||||
SinkFn sink, void* token, SHA_CTX* ctx) {
|
||||
FILE* f;
|
||||
if ((f = fopen(patch_filename, "rb")) == NULL) {
|
||||
printf("failed to open patch file\n");
|
||||
ssize_t pos = 12;
|
||||
char* header = patch->data;
|
||||
if (patch->size < 12) {
|
||||
printf("patch too short to contain header\n");
|
||||
return -1;
|
||||
}
|
||||
|
||||
unsigned char header[12];
|
||||
if (fread(header, 1, 12, f) != 12) {
|
||||
printf("failed to read patch file header\n");
|
||||
return -1;
|
||||
}
|
||||
|
||||
// IMGDIFF1 uses CHUNK_NORMAL and CHUNK_GZIP.
|
||||
// IMGDIFF2 uses CHUNK_NORMAL, CHUNK_DEFLATE, and CHUNK_RAW.
|
||||
if (memcmp(header, "IMGDIFF", 7) != 0 ||
|
||||
(header[7] != '1' && header[7] != '2')) {
|
||||
// (IMGDIFF1, which is no longer supported, used CHUNK_NORMAL and
|
||||
// CHUNK_GZIP.)
|
||||
if (memcmp(header, "IMGDIFF2", 8) != 0) {
|
||||
printf("corrupt patch file header (magic number)\n");
|
||||
return -1;
|
||||
}
|
||||
|
@ -63,17 +58,17 @@ int ApplyImagePatch(const unsigned char* old_data, ssize_t old_size,
|
|||
int i;
|
||||
for (i = 0; i < num_chunks; ++i) {
|
||||
// each chunk's header record starts with 4 bytes.
|
||||
unsigned char chunk[4];
|
||||
if (fread(chunk, 1, 4, f) != 4) {
|
||||
if (pos + 4 > patch->size) {
|
||||
printf("failed to read chunk %d record\n", i);
|
||||
return -1;
|
||||
}
|
||||
|
||||
int type = Read4(chunk);
|
||||
int type = Read4(patch->data + pos);
|
||||
pos += 4;
|
||||
|
||||
if (type == CHUNK_NORMAL) {
|
||||
unsigned char normal_header[24];
|
||||
if (fread(normal_header, 1, 24, f) != 24) {
|
||||
char* normal_header = patch->data + pos;
|
||||
pos += 24;
|
||||
if (pos > patch->size) {
|
||||
printf("failed to read chunk %d normal header data\n", i);
|
||||
return -1;
|
||||
}
|
||||
|
@ -82,172 +77,34 @@ int ApplyImagePatch(const unsigned char* old_data, ssize_t old_size,
|
|||
size_t src_len = Read8(normal_header+8);
|
||||
size_t patch_offset = Read8(normal_header+16);
|
||||
|
||||
printf("CHUNK %d: normal patch offset %d\n", i, patch_offset);
|
||||
|
||||
ApplyBSDiffPatch(old_data + src_start, src_len,
|
||||
patch_filename, patch_offset,
|
||||
sink, token, ctx);
|
||||
} else if (type == CHUNK_GZIP) {
|
||||
// This branch is basically a duplicate of the CHUNK_DEFLATE
|
||||
// branch, with a bit of extra processing for the gzip header
|
||||
// and footer. I've avoided factoring the common code out since
|
||||
// this branch will just be deleted when we drop support for
|
||||
// IMGDIFF1.
|
||||
|
||||
// gzip chunks have an additional 64 + gzip_header_len + 8 bytes
|
||||
// in their chunk header.
|
||||
unsigned char* gzip = malloc(64);
|
||||
if (fread(gzip, 1, 64, f) != 64) {
|
||||
printf("failed to read chunk %d initial gzip header data\n",
|
||||
i);
|
||||
return -1;
|
||||
}
|
||||
size_t gzip_header_len = Read4(gzip+60);
|
||||
gzip = realloc(gzip, 64 + gzip_header_len + 8);
|
||||
if (fread(gzip+64, 1, gzip_header_len+8, f) != gzip_header_len+8) {
|
||||
printf("failed to read chunk %d remaining gzip header data\n",
|
||||
i);
|
||||
return -1;
|
||||
}
|
||||
|
||||
size_t src_start = Read8(gzip);
|
||||
size_t src_len = Read8(gzip+8);
|
||||
size_t patch_offset = Read8(gzip+16);
|
||||
|
||||
size_t expanded_len = Read8(gzip+24);
|
||||
size_t target_len = Read8(gzip+32);
|
||||
int gz_level = Read4(gzip+40);
|
||||
int gz_method = Read4(gzip+44);
|
||||
int gz_windowBits = Read4(gzip+48);
|
||||
int gz_memLevel = Read4(gzip+52);
|
||||
int gz_strategy = Read4(gzip+56);
|
||||
|
||||
printf("CHUNK %d: gzip patch offset %d\n", i, patch_offset);
|
||||
|
||||
// Decompress the source data; the chunk header tells us exactly
|
||||
// how big we expect it to be when decompressed.
|
||||
|
||||
unsigned char* expanded_source = malloc(expanded_len);
|
||||
if (expanded_source == NULL) {
|
||||
printf("failed to allocate %d bytes for expanded_source\n",
|
||||
expanded_len);
|
||||
return -1;
|
||||
}
|
||||
|
||||
z_stream strm;
|
||||
strm.zalloc = Z_NULL;
|
||||
strm.zfree = Z_NULL;
|
||||
strm.opaque = Z_NULL;
|
||||
strm.avail_in = src_len - (gzip_header_len + 8);
|
||||
strm.next_in = (unsigned char*)(old_data + src_start + gzip_header_len);
|
||||
strm.avail_out = expanded_len;
|
||||
strm.next_out = expanded_source;
|
||||
|
||||
int ret;
|
||||
ret = inflateInit2(&strm, -15);
|
||||
if (ret != Z_OK) {
|
||||
printf("failed to init source inflation: %d\n", ret);
|
||||
return -1;
|
||||
}
|
||||
|
||||
// Because we've provided enough room to accommodate the output
|
||||
// data, we expect one call to inflate() to suffice.
|
||||
ret = inflate(&strm, Z_SYNC_FLUSH);
|
||||
if (ret != Z_STREAM_END) {
|
||||
printf("source inflation returned %d\n", ret);
|
||||
return -1;
|
||||
}
|
||||
// We should have filled the output buffer exactly.
|
||||
if (strm.avail_out != 0) {
|
||||
printf("source inflation short by %d bytes\n", strm.avail_out);
|
||||
return -1;
|
||||
}
|
||||
inflateEnd(&strm);
|
||||
|
||||
// Next, apply the bsdiff patch (in memory) to the uncompressed
|
||||
// data.
|
||||
unsigned char* uncompressed_target_data;
|
||||
ssize_t uncompressed_target_size;
|
||||
if (ApplyBSDiffPatchMem(expanded_source, expanded_len,
|
||||
patch_filename, patch_offset,
|
||||
&uncompressed_target_data,
|
||||
&uncompressed_target_size) != 0) {
|
||||
return -1;
|
||||
}
|
||||
|
||||
// Now compress the target data and append it to the output.
|
||||
|
||||
// start with the gzip header.
|
||||
sink(gzip+64, gzip_header_len, token);
|
||||
SHA_update(ctx, gzip+64, gzip_header_len);
|
||||
|
||||
// we're done with the expanded_source data buffer, so we'll
|
||||
// reuse that memory to receive the output of deflate.
|
||||
unsigned char* temp_data = expanded_source;
|
||||
ssize_t temp_size = expanded_len;
|
||||
if (temp_size < 32768) {
|
||||
// ... unless the buffer is too small, in which case we'll
|
||||
// allocate a fresh one.
|
||||
free(temp_data);
|
||||
temp_data = malloc(32768);
|
||||
temp_size = 32768;
|
||||
}
|
||||
|
||||
// now the deflate stream
|
||||
strm.zalloc = Z_NULL;
|
||||
strm.zfree = Z_NULL;
|
||||
strm.opaque = Z_NULL;
|
||||
strm.avail_in = uncompressed_target_size;
|
||||
strm.next_in = uncompressed_target_data;
|
||||
ret = deflateInit2(&strm, gz_level, gz_method, gz_windowBits,
|
||||
gz_memLevel, gz_strategy);
|
||||
do {
|
||||
strm.avail_out = temp_size;
|
||||
strm.next_out = temp_data;
|
||||
ret = deflate(&strm, Z_FINISH);
|
||||
size_t have = temp_size - strm.avail_out;
|
||||
|
||||
if (sink(temp_data, have, token) != have) {
|
||||
printf("failed to write %d compressed bytes to output\n",
|
||||
have);
|
||||
return -1;
|
||||
}
|
||||
SHA_update(ctx, temp_data, have);
|
||||
} while (ret != Z_STREAM_END);
|
||||
deflateEnd(&strm);
|
||||
|
||||
// lastly, the gzip footer.
|
||||
sink(gzip+64+gzip_header_len, 8, token);
|
||||
SHA_update(ctx, gzip+64+gzip_header_len, 8);
|
||||
|
||||
free(temp_data);
|
||||
free(uncompressed_target_data);
|
||||
free(gzip);
|
||||
patch, patch_offset, sink, token, ctx);
|
||||
} else if (type == CHUNK_RAW) {
|
||||
unsigned char raw_header[4];
|
||||
if (fread(raw_header, 1, 4, f) != 4) {
|
||||
char* raw_header = patch->data + pos;
|
||||
pos += 4;
|
||||
if (pos > patch->size) {
|
||||
printf("failed to read chunk %d raw header data\n", i);
|
||||
return -1;
|
||||
}
|
||||
|
||||
size_t data_len = Read4(raw_header);
|
||||
ssize_t data_len = Read4(raw_header);
|
||||
|
||||
printf("CHUNK %d: raw data %d\n", i, data_len);
|
||||
|
||||
unsigned char* temp = malloc(data_len);
|
||||
if (fread(temp, 1, data_len, f) != data_len) {
|
||||
if (pos + data_len > patch->size) {
|
||||
printf("failed to read chunk %d raw data\n", i);
|
||||
return -1;
|
||||
}
|
||||
SHA_update(ctx, temp, data_len);
|
||||
if (sink(temp, data_len, token) != data_len) {
|
||||
SHA_update(ctx, patch->data + pos, data_len);
|
||||
if (sink((unsigned char*)patch->data + pos,
|
||||
data_len, token) != data_len) {
|
||||
printf("failed to write chunk %d raw data\n", i);
|
||||
return -1;
|
||||
}
|
||||
pos += data_len;
|
||||
} else if (type == CHUNK_DEFLATE) {
|
||||
// deflate chunks have an additional 60 bytes in their chunk header.
|
||||
unsigned char deflate_header[60];
|
||||
if (fread(deflate_header, 1, 60, f) != 60) {
|
||||
char* deflate_header = patch->data + pos;
|
||||
pos += 60;
|
||||
if (pos > patch->size) {
|
||||
printf("failed to read chunk %d deflate header data\n", i);
|
||||
return -1;
|
||||
}
|
||||
|
@ -263,8 +120,6 @@ int ApplyImagePatch(const unsigned char* old_data, ssize_t old_size,
|
|||
int memLevel = Read4(deflate_header+52);
|
||||
int strategy = Read4(deflate_header+56);
|
||||
|
||||
printf("CHUNK %d: deflate patch offset %d\n", i, patch_offset);
|
||||
|
||||
// Decompress the source data; the chunk header tells us exactly
|
||||
// how big we expect it to be when decompressed.
|
||||
|
||||
|
@ -310,7 +165,7 @@ int ApplyImagePatch(const unsigned char* old_data, ssize_t old_size,
|
|||
unsigned char* uncompressed_target_data;
|
||||
ssize_t uncompressed_target_size;
|
||||
if (ApplyBSDiffPatchMem(expanded_source, expanded_len,
|
||||
patch_filename, patch_offset,
|
||||
patch, patch_offset,
|
||||
&uncompressed_target_data,
|
||||
&uncompressed_target_size) != 0) {
|
||||
return -1;
|
||||
|
@ -341,11 +196,11 @@ int ApplyImagePatch(const unsigned char* old_data, ssize_t old_size,
|
|||
strm.avail_out = temp_size;
|
||||
strm.next_out = temp_data;
|
||||
ret = deflate(&strm, Z_FINISH);
|
||||
size_t have = temp_size - strm.avail_out;
|
||||
ssize_t have = temp_size - strm.avail_out;
|
||||
|
||||
if (sink(temp_data, have, token) != have) {
|
||||
printf("failed to write %d compressed bytes to output\n",
|
||||
have);
|
||||
printf("failed to write %ld compressed bytes to output\n",
|
||||
(long)have);
|
||||
return -1;
|
||||
}
|
||||
SHA_update(ctx, temp_data, have);
|
||||
|
|
|
@ -15,8 +15,126 @@
|
|||
*/
|
||||
|
||||
#include <stdio.h>
|
||||
#include <stdlib.h>
|
||||
#include <string.h>
|
||||
#include <unistd.h>
|
||||
|
||||
extern int applypatch(int argc, char** argv);
|
||||
#include "applypatch.h"
|
||||
#include "edify/expr.h"
|
||||
#include "mincrypt/sha.h"
|
||||
|
||||
int CheckMode(int argc, char** argv) {
|
||||
if (argc < 3) {
|
||||
return 2;
|
||||
}
|
||||
return applypatch_check(argv[2], argc-3, argv+3);
|
||||
}
|
||||
|
||||
int SpaceMode(int argc, char** argv) {
|
||||
if (argc != 3) {
|
||||
return 2;
|
||||
}
|
||||
char* endptr;
|
||||
size_t bytes = strtol(argv[2], &endptr, 10);
|
||||
if (bytes == 0 && endptr == argv[2]) {
|
||||
printf("can't parse \"%s\" as byte count\n\n", argv[2]);
|
||||
return 1;
|
||||
}
|
||||
return CacheSizeCheck(bytes);
|
||||
}
|
||||
|
||||
// Parse arguments (which should be of the form "<sha1>" or
|
||||
// "<sha1>:<filename>" into the new parallel arrays *sha1s and
|
||||
// *patches (loading file contents into the patches). Returns 0 on
|
||||
// success.
|
||||
static int ParsePatchArgs(int argc, char** argv,
|
||||
char*** sha1s, Value*** patches, int* num_patches) {
|
||||
*num_patches = argc;
|
||||
*sha1s = malloc(*num_patches * sizeof(char*));
|
||||
*patches = malloc(*num_patches * sizeof(Value*));
|
||||
memset(*patches, 0, *num_patches * sizeof(Value*));
|
||||
|
||||
uint8_t digest[SHA_DIGEST_SIZE];
|
||||
|
||||
int i;
|
||||
for (i = 0; i < *num_patches; ++i) {
|
||||
char* colon = strchr(argv[i], ':');
|
||||
if (colon != NULL) {
|
||||
*colon = '\0';
|
||||
++colon;
|
||||
}
|
||||
|
||||
if (ParseSha1(argv[i], digest) != 0) {
|
||||
printf("failed to parse sha1 \"%s\"\n", argv[i]);
|
||||
return -1;
|
||||
}
|
||||
|
||||
(*sha1s)[i] = argv[i];
|
||||
if (colon == NULL) {
|
||||
(*patches)[i] = NULL;
|
||||
} else {
|
||||
FileContents fc;
|
||||
if (LoadFileContents(colon, &fc) != 0) {
|
||||
goto abort;
|
||||
}
|
||||
(*patches)[i] = malloc(sizeof(Value));
|
||||
(*patches)[i]->type = VAL_BLOB;
|
||||
(*patches)[i]->size = fc.size;
|
||||
(*patches)[i]->data = (char*)fc.data;
|
||||
}
|
||||
}
|
||||
|
||||
return 0;
|
||||
|
||||
abort:
|
||||
for (i = 0; i < *num_patches; ++i) {
|
||||
Value* p = (*patches)[i];
|
||||
if (p != NULL) {
|
||||
free(p->data);
|
||||
free(p);
|
||||
}
|
||||
}
|
||||
free(*sha1s);
|
||||
free(*patches);
|
||||
return -1;
|
||||
}
|
||||
|
||||
int PatchMode(int argc, char** argv) {
|
||||
if (argc < 6) {
|
||||
return 2;
|
||||
}
|
||||
|
||||
char* endptr;
|
||||
size_t target_size = strtol(argv[4], &endptr, 10);
|
||||
if (target_size == 0 && endptr == argv[4]) {
|
||||
printf("can't parse \"%s\" as byte count\n\n", argv[4]);
|
||||
return 1;
|
||||
}
|
||||
|
||||
char** sha1s;
|
||||
Value** patches;
|
||||
int num_patches;
|
||||
if (ParsePatchArgs(argc-5, argv+5, &sha1s, &patches, &num_patches) != 0) {
|
||||
printf("failed to parse patch args\n");
|
||||
return 1;
|
||||
}
|
||||
|
||||
int result = applypatch(argv[1], argv[2], argv[3], target_size,
|
||||
num_patches, sha1s, patches);
|
||||
|
||||
int i;
|
||||
for (i = 0; i < num_patches; ++i) {
|
||||
Value* p = patches[i];
|
||||
if (p != NULL) {
|
||||
free(p->data);
|
||||
free(p);
|
||||
}
|
||||
}
|
||||
free(sha1s);
|
||||
free(patches);
|
||||
|
||||
return result;
|
||||
}
|
||||
|
||||
// This program applies binary patches to files in a way that is safe
|
||||
// (the original file is not touched until we have the desired
|
||||
|
@ -42,8 +160,8 @@ extern int applypatch(int argc, char** argv);
|
|||
// LoadMTDContents() function above for the format of such a filename.
|
||||
|
||||
int main(int argc, char** argv) {
|
||||
int result = applypatch(argc, argv);
|
||||
if (result == 2) {
|
||||
if (argc < 2) {
|
||||
usage:
|
||||
printf(
|
||||
"usage: %s <src-file> <tgt-file> <tgt-sha1> <tgt-size> "
|
||||
"[<src-sha1>:<patch> ...]\n"
|
||||
|
@ -55,6 +173,23 @@ int main(int argc, char** argv) {
|
|||
" MTD:<partition>:<len_1>:<sha1_1>:<len_2>:<sha1_2>:...\n"
|
||||
"to specify reading from or writing to an MTD partition.\n\n",
|
||||
argv[0], argv[0], argv[0], argv[0]);
|
||||
return 2;
|
||||
}
|
||||
|
||||
int result;
|
||||
|
||||
if (strncmp(argv[1], "-l", 3) == 0) {
|
||||
result = ShowLicenses();
|
||||
} else if (strncmp(argv[1], "-c", 3) == 0) {
|
||||
result = CheckMode(argc, argv);
|
||||
} else if (strncmp(argv[1], "-s", 3) == 0) {
|
||||
result = SpaceMode(argc, argv);
|
||||
} else {
|
||||
result = PatchMode(argc, argv);
|
||||
}
|
||||
|
||||
if (result == 2) {
|
||||
goto usage;
|
||||
}
|
||||
return result;
|
||||
}
|
||||
|
|
|
@ -38,19 +38,22 @@ void Write8(long long value, FILE* f) {
|
|||
fputc((value >> 56) & 0xff, f);
|
||||
}
|
||||
|
||||
int Read2(unsigned char* p) {
|
||||
int Read2(void* pv) {
|
||||
unsigned char* p = pv;
|
||||
return (int)(((unsigned int)p[1] << 8) |
|
||||
(unsigned int)p[0]);
|
||||
}
|
||||
|
||||
int Read4(unsigned char* p) {
|
||||
int Read4(void* pv) {
|
||||
unsigned char* p = pv;
|
||||
return (int)(((unsigned int)p[3] << 24) |
|
||||
((unsigned int)p[2] << 16) |
|
||||
((unsigned int)p[1] << 8) |
|
||||
(unsigned int)p[0]);
|
||||
}
|
||||
|
||||
long long Read8(unsigned char* p) {
|
||||
long long Read8(void* pv) {
|
||||
unsigned char* p = pv;
|
||||
return (long long)(((unsigned long long)p[7] << 56) |
|
||||
((unsigned long long)p[6] << 48) |
|
||||
((unsigned long long)p[5] << 40) |
|
||||
|
|
|
@ -23,8 +23,8 @@
|
|||
|
||||
void Write4(int value, FILE* f);
|
||||
void Write8(long long value, FILE* f);
|
||||
int Read2(unsigned char* p);
|
||||
int Read4(unsigned char* p);
|
||||
long long Read8(unsigned char* p);
|
||||
int Read2(void* p);
|
||||
int Read4(void* p);
|
||||
long long Read8(void* p);
|
||||
|
||||
#endif // _BUILD_TOOLS_APPLYPATCH_UTILS_H
|
||||
|
|
|
@ -42,11 +42,12 @@ int expect(const char* expr_str, const char* expected, int* errors) {
|
|||
|
||||
State state;
|
||||
state.cookie = NULL;
|
||||
state.script = expr_str;
|
||||
state.script = strdup(expr_str);
|
||||
state.errmsg = NULL;
|
||||
|
||||
result = Evaluate(&state, e);
|
||||
free(state.errmsg);
|
||||
free(state.script);
|
||||
if (result == NULL && expected != NULL) {
|
||||
fprintf(stderr, "error evaluating \"%s\"\n", expr_str);
|
||||
++*errors;
|
||||
|
|
|
@ -33,4 +33,6 @@ typedef struct {
|
|||
} \
|
||||
} while (0)
|
||||
|
||||
int yylex();
|
||||
|
||||
#endif
|
||||
|
|
|
@ -705,52 +705,124 @@ done:
|
|||
return StringValue(result);
|
||||
}
|
||||
|
||||
// apply_patch(srcfile, tgtfile, tgtsha1, tgtsize, sha1:patch, ...)
|
||||
// apply_patch_check(file, sha1, ...)
|
||||
// apply_patch_space(bytes)
|
||||
Value* ApplyPatchSpaceFn(const char* name, State* state,
|
||||
int argc, Expr* argv[]) {
|
||||
char* bytes_str;
|
||||
if (ReadArgs(state, argv, 1, &bytes_str) < 0) {
|
||||
return NULL;
|
||||
}
|
||||
|
||||
char* endptr;
|
||||
size_t bytes = strtol(bytes_str, &endptr, 10);
|
||||
if (bytes == 0 && endptr == bytes_str) {
|
||||
ErrorAbort(state, "%s(): can't parse \"%s\" as byte count\n\n",
|
||||
name, bytes_str);
|
||||
free(bytes_str);
|
||||
return NULL;
|
||||
}
|
||||
|
||||
return StringValue(strdup(CacheSizeCheck(bytes) ? "" : "t"));
|
||||
}
|
||||
|
||||
|
||||
// apply_patch(srcfile, tgtfile, tgtsha1, tgtsize, sha1_1, patch_1, ...)
|
||||
Value* ApplyPatchFn(const char* name, State* state, int argc, Expr* argv[]) {
|
||||
printf("in applypatchfn (%s)\n", name);
|
||||
|
||||
char* prepend = NULL;
|
||||
if (strstr(name, "check") != NULL) {
|
||||
prepend = "-c";
|
||||
} else if (strstr(name, "space") != NULL) {
|
||||
prepend = "-s";
|
||||
if (argc < 6 || (argc % 2) == 1) {
|
||||
return ErrorAbort(state, "%s(): expected at least 6 args and an "
|
||||
"even number, got %d",
|
||||
name, argc);
|
||||
}
|
||||
|
||||
char** args = ReadVarArgs(state, argc, argv);
|
||||
if (args == NULL) return NULL;
|
||||
|
||||
// insert the "program name" argv[0] and a copy of the "prepend"
|
||||
// string (if any) at the start of the args.
|
||||
|
||||
int extra = 1 + (prepend != NULL ? 1 : 0);
|
||||
char** temp = malloc((argc+extra) * sizeof(char*));
|
||||
memcpy(temp+extra, args, argc * sizeof(char*));
|
||||
temp[0] = strdup("updater");
|
||||
if (prepend) {
|
||||
temp[1] = strdup(prepend);
|
||||
char* source_filename;
|
||||
char* target_filename;
|
||||
char* target_sha1;
|
||||
char* target_size_str;
|
||||
if (ReadArgs(state, argv, 4, &source_filename, &target_filename,
|
||||
&target_sha1, &target_size_str) < 0) {
|
||||
return NULL;
|
||||
}
|
||||
free(args);
|
||||
args = temp;
|
||||
argc += extra;
|
||||
|
||||
printf("calling applypatch\n");
|
||||
fflush(stdout);
|
||||
int result = applypatch(argc, args);
|
||||
printf("applypatch returned %d\n", result);
|
||||
char* endptr;
|
||||
size_t target_size = strtol(target_size_str, &endptr, 10);
|
||||
if (target_size == 0 && endptr == target_size_str) {
|
||||
ErrorAbort(state, "%s(): can't parse \"%s\" as byte count",
|
||||
name, target_size_str);
|
||||
free(source_filename);
|
||||
free(target_filename);
|
||||
free(target_sha1);
|
||||
free(target_size_str);
|
||||
return NULL;
|
||||
}
|
||||
|
||||
int patchcount = (argc-4) / 2;
|
||||
Value** patches = ReadValueVarArgs(state, argc-4, argv+4);
|
||||
|
||||
int i;
|
||||
for (i = 0; i < argc; ++i) {
|
||||
free(args[i]);
|
||||
for (i = 0; i < patchcount; ++i) {
|
||||
if (patches[i*2]->type != VAL_STRING) {
|
||||
ErrorAbort(state, "%s(): sha-1 #%d is not string", name, i);
|
||||
break;
|
||||
}
|
||||
if (patches[i*2+1]->type != VAL_BLOB) {
|
||||
ErrorAbort(state, "%s(): patch #%d is not blob", name, i);
|
||||
break;
|
||||
}
|
||||
}
|
||||
if (i != patchcount) {
|
||||
for (i = 0; i < patchcount*2; ++i) {
|
||||
FreeValue(patches[i]);
|
||||
}
|
||||
free(patches);
|
||||
return NULL;
|
||||
}
|
||||
free(args);
|
||||
|
||||
switch (result) {
|
||||
case 0: return StringValue(strdup("t"));
|
||||
case 1: return StringValue(strdup(""));
|
||||
default: return ErrorAbort(state, "applypatch couldn't parse args");
|
||||
char** patch_sha_str = malloc(patchcount * sizeof(char*));
|
||||
for (i = 0; i < patchcount; ++i) {
|
||||
patch_sha_str[i] = patches[i*2]->data;
|
||||
patches[i*2]->data = NULL;
|
||||
FreeValue(patches[i*2]);
|
||||
patches[i] = patches[i*2+1];
|
||||
}
|
||||
|
||||
int result = applypatch(source_filename, target_filename,
|
||||
target_sha1, target_size,
|
||||
patchcount, patch_sha_str, patches);
|
||||
|
||||
for (i = 0; i < patchcount; ++i) {
|
||||
FreeValue(patches[i]);
|
||||
}
|
||||
free(patch_sha_str);
|
||||
free(patches);
|
||||
|
||||
return StringValue(strdup(result == 0 ? "t" : ""));
|
||||
}
|
||||
|
||||
// apply_patch_check(file, [sha1_1, ...])
|
||||
Value* ApplyPatchCheckFn(const char* name, State* state,
|
||||
int argc, Expr* argv[]) {
|
||||
if (argc < 1) {
|
||||
return ErrorAbort(state, "%s(): expected at least 1 arg, got %d",
|
||||
name, argc);
|
||||
}
|
||||
|
||||
char* filename;
|
||||
if (ReadArgs(state, argv, 1, &filename) < 0) {
|
||||
return NULL;
|
||||
}
|
||||
|
||||
int patchcount = argc-1;
|
||||
char** sha1s = ReadVarArgs(state, argc-1, argv+1);
|
||||
|
||||
int result = applypatch_check(filename, patchcount, sha1s);
|
||||
|
||||
int i;
|
||||
for (i = 0; i < patchcount; ++i) {
|
||||
free(sha1s[i]);
|
||||
}
|
||||
free(sha1s);
|
||||
|
||||
return StringValue(strdup(result == 0 ? "t" : ""));
|
||||
}
|
||||
|
||||
Value* UIPrintFn(const char* name, State* state, int argc, Expr* argv[]) {
|
||||
|
@ -831,36 +903,6 @@ Value* RunProgramFn(const char* name, State* state, int argc, Expr* argv[]) {
|
|||
return StringValue(strdup(buffer));
|
||||
}
|
||||
|
||||
// Take a string 'str' of 40 hex digits and parse it into the 20
|
||||
// byte array 'digest'. 'str' may contain only the digest or be of
|
||||
// the form "<digest>:<anything>". Return 0 on success, -1 on any
|
||||
// error.
|
||||
static int ParseSha1(const char* str, uint8_t* digest) {
|
||||
int i;
|
||||
const char* ps = str;
|
||||
uint8_t* pd = digest;
|
||||
for (i = 0; i < SHA_DIGEST_SIZE * 2; ++i, ++ps) {
|
||||
int digit;
|
||||
if (*ps >= '0' && *ps <= '9') {
|
||||
digit = *ps - '0';
|
||||
} else if (*ps >= 'a' && *ps <= 'f') {
|
||||
digit = *ps - 'a' + 10;
|
||||
} else if (*ps >= 'A' && *ps <= 'F') {
|
||||
digit = *ps - 'A' + 10;
|
||||
} else {
|
||||
return -1;
|
||||
}
|
||||
if (i % 2 == 0) {
|
||||
*pd = digit << 4;
|
||||
} else {
|
||||
*pd |= digit;
|
||||
++pd;
|
||||
}
|
||||
}
|
||||
if (*ps != '\0') return -1;
|
||||
return 0;
|
||||
}
|
||||
|
||||
// Take a sha-1 digest and return it as a newly-allocated hex string.
|
||||
static char* PrintSha1(uint8_t* digest) {
|
||||
char* buffer = malloc(SHA_DIGEST_SIZE*2 + 1);
|
||||
|
@ -981,8 +1023,8 @@ void RegisterInstallFunctions() {
|
|||
RegisterFunction("write_raw_image", WriteRawImageFn);
|
||||
|
||||
RegisterFunction("apply_patch", ApplyPatchFn);
|
||||
RegisterFunction("apply_patch_check", ApplyPatchFn);
|
||||
RegisterFunction("apply_patch_space", ApplyPatchFn);
|
||||
RegisterFunction("apply_patch_check", ApplyPatchCheckFn);
|
||||
RegisterFunction("apply_patch_space", ApplyPatchSpaceFn);
|
||||
|
||||
RegisterFunction("read_file", ReadFileFn);
|
||||
RegisterFunction("sha1_check", Sha1CheckFn);
|
||||
|
|
Loading…
Reference in a new issue