Merge "otafault: Clean up header inclusion."

am: d9373cf621

Change-Id: I1096e13532b7dbb6686479c8909a0252b31fc5f2

otafault/Android.mk

@@ -18,8 +18,6 @@ include $(CLEAR_VARS)
 
 otafault_static_libs := \
     libziparchive \
-    libz \
-    libselinux \
     libbase \
     liblog
 

otafault/config.cpp

@@ -14,16 +14,14 @@
  * limitations under the License.
  */
 
+#include "config.h"
+
 #include <map>
 #include <string>
 
-#include <stdio.h>
-#include <unistd.h>
-
 #include <android-base/stringprintf.h>
 #include <ziparchive/zip_archive.h>
 
-#include "config.h"
 #include "ota_io.h"
 
 #define OTAIO_MAX_FNAME_SIZE 128

otafault/config.h

@@ -15,13 +15,13 @@
  */
 
 /*
- * Read configuration files in the OTA package to determine which files, if any, will trigger errors.
+ * Read configuration files in the OTA package to determine which files, if any, will trigger
+ * errors.
  *
- * OTA packages can be modified to trigger errors by adding a top-level
+ * OTA packages can be modified to trigger errors by adding a top-level directory called
- * directory called .libotafault, which may optionally contain up to three
+ * .libotafault, which may optionally contain up to three files called READ, WRITE, and FSYNC.
- * files called READ, WRITE, and FSYNC. Each one of these optional files
+ * Each one of these optional files contains the name of a single file on the device disk which
- * contains the name of a single file on the device disk which will cause
+ * will cause an IO error on the first call of the appropriate I/O action to that file.
- * an IO error on the first call of the appropriate I/O action to that file.
  *
  * Example:
  * ota.zip
@@ -29,9 +29,9 @@
  *   .libotafault
  *     WRITE
  *
- * If the contents of the file WRITE were /system/build.prop, the first write
+ * If the contents of the file WRITE were /system/build.prop, the first write action to
- * action to /system/build.prop would fail with EIO. Note that READ and
+ * /system/build.prop would fail with EIO. Note that READ and FSYNC files are absent, so these
- * FSYNC files are absent, so these actions will not cause an error.
+ * actions will not cause an error.
  */
 
 #ifndef _UPDATER_OTA_IO_CFG_H_
@@ -39,8 +39,6 @@
 
 #include <string>
 
-#include <stdbool.h>
-
 #include <ziparchive/zip_archive.h>
 
 #define OTAIO_BASE_DIR ".libotafault"

otafault/ota_io.cpp

@@ -18,15 +18,17 @@
 
 #include <errno.h>
 #include <fcntl.h>
+#include <stdint.h>
 #include <stdio.h>
 #include <sys/stat.h>
+#include <sys/types.h>
 #include <unistd.h>
 
 #include <map>
-#include <memory>
 #include <mutex>
 
 #include <android-base/thread_annotations.h>
+
 #include "config.h"
 
 static std::mutex filename_mutex;

otafault/ota_io.h

@@ -23,8 +23,9 @@
 #ifndef _UPDATER_OTA_IO_H_
 #define _UPDATER_OTA_IO_H_
 
+#include <stddef.h>
 #include <stdio.h>
-#include <sys/stat.h>
+#include <sys/stat.h>  // mode_t
 
 #include <memory>
 

otafault/test.cpp

@@ -14,9 +14,10 @@
  * limitations under the License.
  */
 
-#include <errno.h>
 #include <fcntl.h>
 #include <stdio.h>
+#include <sys/stat.h>
+#include <sys/types.h>
 #include <unistd.h>
 
 #include "ota_io.h"