0e844b0289
Author: Tom Marshall <tdm.code@gmail.com> Date: Wed Oct 25 20:27:08 2017 +0200 Revert "kill package_extract_dir" changes for P: - bring back the mkdir_recursively variant which takes a timestamp. - add libziparchive dependency - fix otautil header paths changes for Q: - change ziputil naming convention to lowercase This reverts commit53c38b1538
. Change-Id: I71c488e96a1f23aace3c38fc283aae0165129a12 Author: Tom Marshall <tdm.code@gmail.com> Date: Thu Dec 14 22:37:17 2017 +0100 Revert "Remove the obsolete package_extract_dir() test" This reverts commitbb7e005a79
. Change-Id: I643235d6605d7da2a189eca10ec999b25c23e1f9 Author: Tom Marshall <tdm.code@gmail.com> Date: Wed Aug 23 18:14:00 2017 +0000 Revert "updater: Remove some obsoleted functions for file-based OTA." This reverts commit63d786cf22
. These functions will be used for third party OTA zips, so keep them. Change-Id: I24b67ba4c86f8f86d0a41429a395fece1a383efd Author: Stricted <info@stricted.net> Date: Mon Mar 12 18:11:56 2018 +0100 recovery: updater: Fix SymlinkFn args Change-Id: If2ba1b7a8b5ac471a2db84f352273fd0ea7c81a2 Author: Simon Shields <simon@lineageos.org> Date: Thu Aug 9 01:17:21 2018 +1000 Revert "updater: Remove dead make_parents()." This reverts commit5902691764
. Change-Id: I69eadf1a091f6ecd45531789dedf72a178a055ba Author: Simon Shields <simon@lineageos.org> Date: Thu Aug 9 01:20:40 2018 +1000 Revert "otautil: Delete dirUnlinkHierarchy()." changes for P: - Fix missing PATH_MAX macro from limits.h This reverts commit7934985e0c
. Change-Id: I67ce71a1644b58a393dce45a6c3dee97830b9ee4 Author: XiNGRZ <chenxingyu92@gmail.com> Date: Tue Dec 3 14:31:56 2019 +0800 updater: Fix lost capabilities of set_metadata This was broken since Android O. During a file-based incremental OTA, capability flags were cleared but not being set again properly, leading some critical processes (e.g. surfaceflinger and pm-service) fails. For more details, see:65b8d749f7
Change-Id: I20e616cd83ec1cd1b79717a6703919316ad77938 [mikeioannina]: Squash for Q and run through clang-format [Chippa_a]: Adapt for Android R updater and libziparchive API Change-Id: I91973bc9e9f8d100688c0112fda9043fd45eb86a
141 lines
4.2 KiB
C++
141 lines
4.2 KiB
C++
/*
|
|
* Copyright 2016 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#include <errno.h>
|
|
#include <sys/stat.h>
|
|
#include <unistd.h>
|
|
|
|
#include <string>
|
|
|
|
#include <android-base/file.h>
|
|
#include <gtest/gtest.h>
|
|
|
|
#include "otautil/dirutil.h"
|
|
|
|
TEST(DirUtilTest, create_invalid) {
|
|
// Requesting to create an empty dir is invalid.
|
|
ASSERT_EQ(-1, mkdir_recursively("", 0755, false, nullptr));
|
|
ASSERT_EQ(ENOENT, errno);
|
|
|
|
// Requesting to strip the name with no slash present.
|
|
ASSERT_EQ(-1, mkdir_recursively("abc", 0755, true, nullptr));
|
|
ASSERT_EQ(ENOENT, errno);
|
|
|
|
// Creating a dir that already exists.
|
|
TemporaryDir td;
|
|
ASSERT_EQ(0, mkdir_recursively(td.path, 0755, false, nullptr));
|
|
|
|
// "///" is a valid dir.
|
|
ASSERT_EQ(0, mkdir_recursively("///", 0755, false, nullptr));
|
|
|
|
// Request to create a dir, but a file with the same name already exists.
|
|
TemporaryFile tf;
|
|
ASSERT_EQ(-1, mkdir_recursively(tf.path, 0755, false, nullptr));
|
|
ASSERT_EQ(ENOTDIR, errno);
|
|
}
|
|
|
|
TEST(DirUtilTest, create_smoke) {
|
|
TemporaryDir td;
|
|
std::string prefix(td.path);
|
|
std::string path = prefix + "/a/b";
|
|
constexpr mode_t mode = 0755;
|
|
ASSERT_EQ(0, mkdir_recursively(path, mode, false, nullptr));
|
|
|
|
// Verify.
|
|
struct stat sb;
|
|
ASSERT_EQ(0, stat(path.c_str(), &sb)) << strerror(errno);
|
|
ASSERT_TRUE(S_ISDIR(sb.st_mode));
|
|
constexpr mode_t mask = S_IRWXU | S_IRWXG | S_IRWXO;
|
|
ASSERT_EQ(mode, sb.st_mode & mask);
|
|
|
|
// Clean up.
|
|
ASSERT_EQ(0, rmdir((prefix + "/a/b").c_str()));
|
|
ASSERT_EQ(0, rmdir((prefix + "/a").c_str()));
|
|
}
|
|
|
|
TEST(DirUtilTest, create_strip_filename) {
|
|
TemporaryDir td;
|
|
std::string prefix(td.path);
|
|
std::string path = prefix + "/a/b";
|
|
ASSERT_EQ(0, mkdir_recursively(path, 0755, true, nullptr));
|
|
|
|
// Verify that "../a" exists but not "../a/b".
|
|
struct stat sb;
|
|
ASSERT_EQ(0, stat((prefix + "/a").c_str(), &sb)) << strerror(errno);
|
|
ASSERT_TRUE(S_ISDIR(sb.st_mode));
|
|
|
|
ASSERT_EQ(-1, stat(path.c_str(), &sb));
|
|
ASSERT_EQ(ENOENT, errno);
|
|
|
|
// Clean up.
|
|
ASSERT_EQ(0, rmdir((prefix + "/a").c_str()));
|
|
}
|
|
|
|
TEST(DirUtilTest, create_mode) {
|
|
TemporaryDir td;
|
|
std::string prefix(td.path);
|
|
std::string path = prefix + "/a/b";
|
|
constexpr mode_t mode = 0751;
|
|
ASSERT_EQ(0, mkdir_recursively(path, mode, false, nullptr));
|
|
|
|
// Verify the mode for "../a/b".
|
|
struct stat sb;
|
|
ASSERT_EQ(0, stat(path.c_str(), &sb)) << strerror(errno);
|
|
ASSERT_TRUE(S_ISDIR(sb.st_mode));
|
|
constexpr mode_t mask = S_IRWXU | S_IRWXG | S_IRWXO;
|
|
ASSERT_EQ(mode, sb.st_mode & mask);
|
|
|
|
// Verify the mode for "../a".
|
|
ASSERT_EQ(0, stat((prefix + "/a").c_str(), &sb)) << strerror(errno);
|
|
ASSERT_TRUE(S_ISDIR(sb.st_mode));
|
|
ASSERT_EQ(mode, sb.st_mode & mask);
|
|
|
|
// Clean up.
|
|
ASSERT_EQ(0, rmdir((prefix + "/a/b").c_str()));
|
|
ASSERT_EQ(0, rmdir((prefix + "/a").c_str()));
|
|
}
|
|
|
|
TEST(DirUtilTest, unlink_invalid) {
|
|
// File doesn't exist.
|
|
ASSERT_EQ(-1, dirUnlinkHierarchy("doesntexist"));
|
|
|
|
// Nonexistent directory.
|
|
TemporaryDir td;
|
|
std::string path(td.path);
|
|
ASSERT_EQ(-1, dirUnlinkHierarchy((path + "/a").c_str()));
|
|
ASSERT_EQ(ENOENT, errno);
|
|
}
|
|
|
|
TEST(DirUtilTest, unlink_smoke) {
|
|
// Unlink a file.
|
|
TemporaryFile tf;
|
|
ASSERT_EQ(0, dirUnlinkHierarchy(tf.path));
|
|
ASSERT_EQ(-1, access(tf.path, F_OK));
|
|
|
|
TemporaryDir td;
|
|
std::string path(td.path);
|
|
constexpr mode_t mode = 0700;
|
|
ASSERT_EQ(0, mkdir((path + "/a").c_str(), mode));
|
|
ASSERT_EQ(0, mkdir((path + "/a/b").c_str(), mode));
|
|
ASSERT_EQ(0, mkdir((path + "/a/b/c").c_str(), mode));
|
|
ASSERT_EQ(0, mkdir((path + "/a/d").c_str(), mode));
|
|
|
|
// Remove "../a" recursively.
|
|
ASSERT_EQ(0, dirUnlinkHierarchy((path + "/a").c_str()));
|
|
|
|
// Verify it's gone.
|
|
ASSERT_EQ(-1, access((path + "/a").c_str(), F_OK));
|
|
}
|