platform_bootable_recovery/updater
Tao Bao 730646199b updater: Don't zero out CommandParameters with memset(3).
[1] switched a few things to android::base::unique_fd including
CommandParameters.fd. However, we were using memset(3) to zero out the
struct, which effectively assigned unique_fd(0) to fd. When it called
fd.reset(), file descriptor 0 was unintentionally closed. When FD 0 was
later reassigned via open(2), it led to lseek(2) errors: "Bad file
descriptor".

This CL switches to using braced-init (i.e. '= {}') instead, so that the
default constructor unique_fd(-1) would be called.

[1]: commit bcabd09293

Bug: 28391985
Change-Id: If1f99932b15552714c399e65c8b80550344b758a
2016-04-26 17:36:13 -07:00
..
Android.mk Convert recovery to use BoringSSL instead of mincrypt. 2016-04-06 15:54:17 +02:00
blockimg.cpp updater: Don't zero out CommandParameters with memset(3). 2016-04-26 17:36:13 -07:00
blockimg.h installer for new block OTA system 2014-08-19 16:53:39 -07:00
install.cpp Fix google-runtime-int warnings. 2016-04-18 12:29:30 -07:00
install.h updater: Add a function to check first block 2016-01-07 11:19:48 -08:00
updater.cpp Move selinux dependencies out of header files. 2016-04-01 18:24:39 -07:00
updater.h Move selinux dependencies out of header files. 2016-04-01 18:24:39 -07:00