No description
ed13819a0d
run_fuse_sideload() is passing the block size as the max_read option, so it will only handle a request that involves at most two blocks at a time. However, the minimal allowed value was set to 1024 prior to this CL, which is inconsistent with the kernel code (fs/fuse/inode.c) that sets it to the greater of 4096 and the passed-in max_read option. This would fail the calls with a block size / max_read less than 4096 due to the wrongly computed block indices. Note that we didn't observe real issue in practice, because we have been using 64 KiB block sizes for both of adb and sdcard sideload calls. The issue only shows up in my local CL (to come later) that uses 1024 block size in run_fuse_sideload() tests. Test: recovery_component_test Test: adb sideload with the new recovery image on angler Change-Id: Id9f0cfea13d0d193dcb7cd41a1553a23739545f2 |
||
|---|---|---|
| applypatch | ||
| boot_control | ||
| bootloader_message | ||
| edify | ||
| etc | ||
| fonts | ||
| minadbd | ||
| minui | ||
| otafault | ||
| otautil | ||
| private | ||
| res-hdpi/images | ||
| res-mdpi/images | ||
| res-xhdpi/images | ||
| res-xxhdpi/images | ||
| res-xxxhdpi/images | ||
| tests | ||
| tools | ||
| uncrypt | ||
| update_verifier | ||
| updater | ||
| .clang-format | ||
| adb_install.cpp | ||
| adb_install.h | ||
| Android.mk | ||
| asn1_decoder.cpp | ||
| asn1_decoder.h | ||
| bootloader.h | ||
| CleanSpec.mk | ||
| common.h | ||
| default_device.cpp | ||
| device.cpp | ||
| device.h | ||
| error_code.h | ||
| fuse_sdcard_provider.cpp | ||
| fuse_sdcard_provider.h | ||
| fuse_sideload.cpp | ||
| fuse_sideload.h | ||
| install.cpp | ||
| install.h | ||
| interlace-frames.py | ||
| mounts.cpp | ||
| mounts.h | ||
| NOTICE | ||
| print_sha1.h | ||
| README.md | ||
| recovery-persist.cpp | ||
| recovery-persist.rc | ||
| recovery-refresh.cpp | ||
| recovery-refresh.rc | ||
| recovery.cpp | ||
| res-560dpi | ||
| roots.cpp | ||
| roots.h | ||
| rotate_logs.cpp | ||
| rotate_logs.h | ||
| screen_ui.cpp | ||
| screen_ui.h | ||
| stub_ui.h | ||
| ui.cpp | ||
| ui.h | ||
| verifier.cpp | ||
| verifier.h | ||
| wear_touch.cpp | ||
| wear_touch.h | ||
| wear_ui.cpp | ||
| wear_ui.h | ||
The Recovery Image
Quick turn-around testing
mm -j && m ramdisk-nodeps && m recoveryimage-nodeps
# To boot into the new recovery image
# without flashing the recovery partition:
adb reboot bootloader
fastboot boot $ANDROID_PRODUCT_OUT/recovery.img
Running the tests
# After setting up environment and lunch.
mmma -j bootable/recovery
# Running the tests on device.
adb root
adb sync data
# 32-bit device
adb shell /data/nativetest/recovery_unit_test/recovery_unit_test
adb shell /data/nativetest/recovery_component_test/recovery_component_test
# Or 64-bit device
adb shell /data/nativetest64/recovery_unit_test/recovery_unit_test
adb shell /data/nativetest64/recovery_component_test/recovery_component_test
Running the manual tests
recovery-refresh and recovery-persist executables exist only on systems without
/cache partition. And we need to follow special steps to run tests for them.
-
Execute the test on an A/B device first. The test should fail but it will log some contents to pmsg.
-
Reboot the device immediately and run the test again. The test should save the contents of pmsg buffer into /data/misc/recovery/inject.txt. Test will pass if this file has expected contents.
ResourceTest validates whether the png files are qualified as background text
image under recovery.
1. `adb sync data` to make sure the test-dir has the images to test.
2. The test will automatically pickup and verify all `_text.png` files in
the test dir.