2017-02-28 00:08:36 +01:00
|
|
|
#!/usr/bin/env python
|
|
|
|
|
|
|
|
# Copyright (C) 2017 The Android Open Source Project
|
|
|
|
#
|
|
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
# you may not use this file except in compliance with the License.
|
|
|
|
# You may obtain a copy of the License at
|
|
|
|
#
|
|
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
#
|
|
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
# See the License for the specific language governing permissions and
|
|
|
|
# limitations under the License.
|
|
|
|
|
|
|
|
"""
|
|
|
|
Validate a given (signed) target_files.zip.
|
|
|
|
|
|
|
|
It performs checks to ensure the integrity of the input zip.
|
|
|
|
- It verifies the file consistency between the ones in IMAGES/system.img (read
|
|
|
|
via IMAGES/system.map) and the ones under unpacked folder of SYSTEM/. The
|
|
|
|
same check also applies to the vendor image if present.
|
|
|
|
"""
|
|
|
|
|
|
|
|
import logging
|
|
|
|
import os.path
|
2017-06-21 02:00:55 +02:00
|
|
|
import re
|
2017-02-28 00:08:36 +01:00
|
|
|
import sys
|
|
|
|
|
releasetools: Make validate_target_files.py pylint clean.
C: 73, 0: Wrong hanging indentation (add 4 spaces).
file_name, actual_sha1, expected_sha1)
^ | (bad-continuation)
C:171, 0: Wrong continued indentation (add 20 spaces).
'SYSTEM/etc/recovery.img', expected_recovery_sha1)
^ | (bad-continuation)
C:185, 0: Wrong continued indentation (add 20 spaces).
file_path='IMAGES/boot.img', expected_sha1=boot_info[3])
^ | (bad-continuation)
C:191, 0: Wrong continued indentation (add 20 spaces).
file_path='IMAGES/recovery.img',
^ | (bad-continuation)
C:192, 0: Wrong continued indentation (add 20 spaces).
expected_sha1=expected_recovery_sha1)
^ | (bad-continuation)
W: 67,15: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
W:150,17: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
W:153,15: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
W:194,15: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
C: 27, 0: standard import "import logging" comes before "import common" (wrong-import-order)
C: 28, 0: standard import "import os.path" comes before "import common" (wrong-import-order)
C: 29, 0: standard import "import re" comes before "import common" (wrong-import-order)
C: 31, 0: standard import "import sys" comes before "import common" (wrong-import-order)
Test: pylint --rcfile=pylintrc validate_target_files.py
Test: Run validate_target_files.py with a target-files.zip.
Change-Id: Ie64acdb4cee4326938c4ad5a34b575d7b82478c0
2018-02-01 21:00:19 +01:00
|
|
|
import common
|
|
|
|
import sparse_img
|
|
|
|
|
2017-02-28 00:08:36 +01:00
|
|
|
|
|
|
|
def _GetImage(which, tmpdir):
|
|
|
|
assert which in ('system', 'vendor')
|
|
|
|
|
|
|
|
path = os.path.join(tmpdir, 'IMAGES', which + '.img')
|
|
|
|
mappath = os.path.join(tmpdir, 'IMAGES', which + '.map')
|
|
|
|
|
|
|
|
# Map file must exist (allowed to be empty).
|
|
|
|
assert os.path.exists(path) and os.path.exists(mappath)
|
|
|
|
|
|
|
|
clobbered_blocks = '0'
|
|
|
|
return sparse_img.SparseImage(path, mappath, clobbered_blocks)
|
|
|
|
|
|
|
|
|
2017-08-31 00:54:59 +02:00
|
|
|
def _ReadFile(file_name, unpacked_name, round_up=False):
|
|
|
|
"""Constructs and returns a File object. Rounds up its size if needed."""
|
2017-02-28 00:08:36 +01:00
|
|
|
|
|
|
|
def RoundUpTo4K(value):
|
|
|
|
rounded_up = value + 4095
|
|
|
|
return rounded_up - (rounded_up % 4096)
|
|
|
|
|
2017-06-21 02:00:55 +02:00
|
|
|
assert os.path.exists(unpacked_name)
|
|
|
|
with open(unpacked_name, 'r') as f:
|
|
|
|
file_data = f.read()
|
|
|
|
file_size = len(file_data)
|
|
|
|
if round_up:
|
|
|
|
file_size_rounded_up = RoundUpTo4K(file_size)
|
|
|
|
file_data += '\0' * (file_size_rounded_up - file_size)
|
2017-08-31 00:54:59 +02:00
|
|
|
return common.File(file_name, file_data)
|
2017-06-21 02:00:55 +02:00
|
|
|
|
|
|
|
|
|
|
|
def ValidateFileAgainstSha1(input_tmp, file_name, file_path, expected_sha1):
|
|
|
|
"""Check if the file has the expected SHA-1."""
|
|
|
|
|
releasetools: Make validate_target_files.py pylint clean.
C: 73, 0: Wrong hanging indentation (add 4 spaces).
file_name, actual_sha1, expected_sha1)
^ | (bad-continuation)
C:171, 0: Wrong continued indentation (add 20 spaces).
'SYSTEM/etc/recovery.img', expected_recovery_sha1)
^ | (bad-continuation)
C:185, 0: Wrong continued indentation (add 20 spaces).
file_path='IMAGES/boot.img', expected_sha1=boot_info[3])
^ | (bad-continuation)
C:191, 0: Wrong continued indentation (add 20 spaces).
file_path='IMAGES/recovery.img',
^ | (bad-continuation)
C:192, 0: Wrong continued indentation (add 20 spaces).
expected_sha1=expected_recovery_sha1)
^ | (bad-continuation)
W: 67,15: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
W:150,17: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
W:153,15: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
W:194,15: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
C: 27, 0: standard import "import logging" comes before "import common" (wrong-import-order)
C: 28, 0: standard import "import os.path" comes before "import common" (wrong-import-order)
C: 29, 0: standard import "import re" comes before "import common" (wrong-import-order)
C: 31, 0: standard import "import sys" comes before "import common" (wrong-import-order)
Test: pylint --rcfile=pylintrc validate_target_files.py
Test: Run validate_target_files.py with a target-files.zip.
Change-Id: Ie64acdb4cee4326938c4ad5a34b575d7b82478c0
2018-02-01 21:00:19 +01:00
|
|
|
logging.info('Validating the SHA-1 of %s', file_name)
|
2017-06-21 02:00:55 +02:00
|
|
|
unpacked_name = os.path.join(input_tmp, file_path)
|
|
|
|
assert os.path.exists(unpacked_name)
|
2017-08-31 00:54:59 +02:00
|
|
|
actual_sha1 = _ReadFile(file_name, unpacked_name, False).sha1
|
2017-06-21 02:00:55 +02:00
|
|
|
assert actual_sha1 == expected_sha1, \
|
|
|
|
'SHA-1 mismatches for {}. actual {}, expected {}'.format(
|
releasetools: Make validate_target_files.py pylint clean.
C: 73, 0: Wrong hanging indentation (add 4 spaces).
file_name, actual_sha1, expected_sha1)
^ | (bad-continuation)
C:171, 0: Wrong continued indentation (add 20 spaces).
'SYSTEM/etc/recovery.img', expected_recovery_sha1)
^ | (bad-continuation)
C:185, 0: Wrong continued indentation (add 20 spaces).
file_path='IMAGES/boot.img', expected_sha1=boot_info[3])
^ | (bad-continuation)
C:191, 0: Wrong continued indentation (add 20 spaces).
file_path='IMAGES/recovery.img',
^ | (bad-continuation)
C:192, 0: Wrong continued indentation (add 20 spaces).
expected_sha1=expected_recovery_sha1)
^ | (bad-continuation)
W: 67,15: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
W:150,17: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
W:153,15: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
W:194,15: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
C: 27, 0: standard import "import logging" comes before "import common" (wrong-import-order)
C: 28, 0: standard import "import os.path" comes before "import common" (wrong-import-order)
C: 29, 0: standard import "import re" comes before "import common" (wrong-import-order)
C: 31, 0: standard import "import sys" comes before "import common" (wrong-import-order)
Test: pylint --rcfile=pylintrc validate_target_files.py
Test: Run validate_target_files.py with a target-files.zip.
Change-Id: Ie64acdb4cee4326938c4ad5a34b575d7b82478c0
2018-02-01 21:00:19 +01:00
|
|
|
file_name, actual_sha1, expected_sha1)
|
2017-06-21 02:00:55 +02:00
|
|
|
|
|
|
|
|
|
|
|
def ValidateFileConsistency(input_zip, input_tmp):
|
|
|
|
"""Compare the files from image files and unpacked folders."""
|
|
|
|
|
2017-02-28 00:08:36 +01:00
|
|
|
def CheckAllFiles(which):
|
|
|
|
logging.info('Checking %s image.', which)
|
|
|
|
image = _GetImage(which, input_tmp)
|
|
|
|
prefix = '/' + which
|
|
|
|
for entry in image.file_map:
|
|
|
|
if not entry.startswith(prefix):
|
|
|
|
continue
|
|
|
|
|
|
|
|
# Read the blocks that the file resides. Note that it will contain the
|
|
|
|
# bytes past the file length, which is expected to be padded with '\0's.
|
|
|
|
ranges = image.file_map[entry]
|
|
|
|
blocks_sha1 = image.RangeSha1(ranges)
|
|
|
|
|
|
|
|
# The filename under unpacked directory, such as SYSTEM/bin/sh.
|
|
|
|
unpacked_name = os.path.join(
|
|
|
|
input_tmp, which.upper(), entry[(len(prefix) + 1):])
|
2017-08-31 00:54:59 +02:00
|
|
|
unpacked_file = _ReadFile(entry, unpacked_name, True)
|
|
|
|
file_size = unpacked_file.size
|
|
|
|
|
|
|
|
# block.map may contain less blocks, because mke2fs may skip allocating
|
|
|
|
# blocks if they contain all zeros. We can't reconstruct such a file from
|
|
|
|
# its block list. (Bug: 65213616)
|
|
|
|
if file_size > ranges.size() * 4096:
|
|
|
|
logging.warning(
|
|
|
|
'Skipping %s that has less blocks: file size %d-byte,'
|
|
|
|
' ranges %s (%d-byte)', entry, file_size, ranges,
|
|
|
|
ranges.size() * 4096)
|
|
|
|
continue
|
2017-02-28 00:08:36 +01:00
|
|
|
|
2017-08-31 00:54:59 +02:00
|
|
|
file_sha1 = unpacked_file.sha1
|
2017-02-28 00:08:36 +01:00
|
|
|
assert blocks_sha1 == file_sha1, \
|
|
|
|
'file: %s, range: %s, blocks_sha1: %s, file_sha1: %s' % (
|
|
|
|
entry, ranges, blocks_sha1, file_sha1)
|
|
|
|
|
|
|
|
logging.info('Validating file consistency.')
|
|
|
|
|
|
|
|
# Verify IMAGES/system.img.
|
|
|
|
CheckAllFiles('system')
|
|
|
|
|
|
|
|
# Verify IMAGES/vendor.img if applicable.
|
|
|
|
if 'VENDOR/' in input_zip.namelist():
|
|
|
|
CheckAllFiles('vendor')
|
|
|
|
|
|
|
|
# Not checking IMAGES/system_other.img since it doesn't have the map file.
|
|
|
|
|
|
|
|
|
2017-06-21 02:00:55 +02:00
|
|
|
def ValidateInstallRecoveryScript(input_tmp, info_dict):
|
|
|
|
"""Validate the SHA-1 embedded in install-recovery.sh.
|
|
|
|
|
|
|
|
install-recovery.sh is written in common.py and has the following format:
|
|
|
|
|
|
|
|
1. full recovery:
|
|
|
|
...
|
|
|
|
if ! applypatch -c type:device:size:SHA-1; then
|
|
|
|
applypatch /system/etc/recovery.img type:device sha1 size && ...
|
|
|
|
...
|
|
|
|
|
|
|
|
2. recovery from boot:
|
|
|
|
...
|
|
|
|
applypatch [-b bonus_args] boot_info recovery_info recovery_sha1 \
|
|
|
|
recovery_size patch_info && ...
|
|
|
|
...
|
|
|
|
|
|
|
|
For full recovery, we want to calculate the SHA-1 of /system/etc/recovery.img
|
|
|
|
and compare it against the one embedded in the script. While for recovery
|
|
|
|
from boot, we want to check the SHA-1 for both recovery.img and boot.img
|
|
|
|
under IMAGES/.
|
|
|
|
"""
|
|
|
|
|
|
|
|
script_path = 'SYSTEM/bin/install-recovery.sh'
|
|
|
|
if not os.path.exists(os.path.join(input_tmp, script_path)):
|
releasetools: Make validate_target_files.py pylint clean.
C: 73, 0: Wrong hanging indentation (add 4 spaces).
file_name, actual_sha1, expected_sha1)
^ | (bad-continuation)
C:171, 0: Wrong continued indentation (add 20 spaces).
'SYSTEM/etc/recovery.img', expected_recovery_sha1)
^ | (bad-continuation)
C:185, 0: Wrong continued indentation (add 20 spaces).
file_path='IMAGES/boot.img', expected_sha1=boot_info[3])
^ | (bad-continuation)
C:191, 0: Wrong continued indentation (add 20 spaces).
file_path='IMAGES/recovery.img',
^ | (bad-continuation)
C:192, 0: Wrong continued indentation (add 20 spaces).
expected_sha1=expected_recovery_sha1)
^ | (bad-continuation)
W: 67,15: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
W:150,17: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
W:153,15: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
W:194,15: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
C: 27, 0: standard import "import logging" comes before "import common" (wrong-import-order)
C: 28, 0: standard import "import os.path" comes before "import common" (wrong-import-order)
C: 29, 0: standard import "import re" comes before "import common" (wrong-import-order)
C: 31, 0: standard import "import sys" comes before "import common" (wrong-import-order)
Test: pylint --rcfile=pylintrc validate_target_files.py
Test: Run validate_target_files.py with a target-files.zip.
Change-Id: Ie64acdb4cee4326938c4ad5a34b575d7b82478c0
2018-02-01 21:00:19 +01:00
|
|
|
logging.info('%s does not exist in input_tmp', script_path)
|
2017-06-21 02:00:55 +02:00
|
|
|
return
|
|
|
|
|
releasetools: Make validate_target_files.py pylint clean.
C: 73, 0: Wrong hanging indentation (add 4 spaces).
file_name, actual_sha1, expected_sha1)
^ | (bad-continuation)
C:171, 0: Wrong continued indentation (add 20 spaces).
'SYSTEM/etc/recovery.img', expected_recovery_sha1)
^ | (bad-continuation)
C:185, 0: Wrong continued indentation (add 20 spaces).
file_path='IMAGES/boot.img', expected_sha1=boot_info[3])
^ | (bad-continuation)
C:191, 0: Wrong continued indentation (add 20 spaces).
file_path='IMAGES/recovery.img',
^ | (bad-continuation)
C:192, 0: Wrong continued indentation (add 20 spaces).
expected_sha1=expected_recovery_sha1)
^ | (bad-continuation)
W: 67,15: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
W:150,17: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
W:153,15: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
W:194,15: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
C: 27, 0: standard import "import logging" comes before "import common" (wrong-import-order)
C: 28, 0: standard import "import os.path" comes before "import common" (wrong-import-order)
C: 29, 0: standard import "import re" comes before "import common" (wrong-import-order)
C: 31, 0: standard import "import sys" comes before "import common" (wrong-import-order)
Test: pylint --rcfile=pylintrc validate_target_files.py
Test: Run validate_target_files.py with a target-files.zip.
Change-Id: Ie64acdb4cee4326938c4ad5a34b575d7b82478c0
2018-02-01 21:00:19 +01:00
|
|
|
logging.info('Checking %s', script_path)
|
2017-06-21 02:00:55 +02:00
|
|
|
with open(os.path.join(input_tmp, script_path), 'r') as script:
|
|
|
|
lines = script.read().strip().split('\n')
|
|
|
|
assert len(lines) >= 6
|
|
|
|
check_cmd = re.search(r'if ! applypatch -c \w+:.+:\w+:(\w+);',
|
|
|
|
lines[1].strip())
|
|
|
|
expected_recovery_check_sha1 = check_cmd.group(1)
|
|
|
|
patch_cmd = re.search(r'(applypatch.+)&&', lines[2].strip())
|
|
|
|
applypatch_argv = patch_cmd.group(1).strip().split()
|
|
|
|
|
|
|
|
full_recovery_image = info_dict.get("full_recovery_image") == "true"
|
|
|
|
if full_recovery_image:
|
|
|
|
assert len(applypatch_argv) == 5
|
|
|
|
# Check we have the same expected SHA-1 of recovery.img in both check mode
|
|
|
|
# and patch mode.
|
|
|
|
expected_recovery_sha1 = applypatch_argv[3].strip()
|
|
|
|
assert expected_recovery_check_sha1 == expected_recovery_sha1
|
|
|
|
ValidateFileAgainstSha1(input_tmp, 'recovery.img',
|
releasetools: Make validate_target_files.py pylint clean.
C: 73, 0: Wrong hanging indentation (add 4 spaces).
file_name, actual_sha1, expected_sha1)
^ | (bad-continuation)
C:171, 0: Wrong continued indentation (add 20 spaces).
'SYSTEM/etc/recovery.img', expected_recovery_sha1)
^ | (bad-continuation)
C:185, 0: Wrong continued indentation (add 20 spaces).
file_path='IMAGES/boot.img', expected_sha1=boot_info[3])
^ | (bad-continuation)
C:191, 0: Wrong continued indentation (add 20 spaces).
file_path='IMAGES/recovery.img',
^ | (bad-continuation)
C:192, 0: Wrong continued indentation (add 20 spaces).
expected_sha1=expected_recovery_sha1)
^ | (bad-continuation)
W: 67,15: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
W:150,17: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
W:153,15: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
W:194,15: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
C: 27, 0: standard import "import logging" comes before "import common" (wrong-import-order)
C: 28, 0: standard import "import os.path" comes before "import common" (wrong-import-order)
C: 29, 0: standard import "import re" comes before "import common" (wrong-import-order)
C: 31, 0: standard import "import sys" comes before "import common" (wrong-import-order)
Test: pylint --rcfile=pylintrc validate_target_files.py
Test: Run validate_target_files.py with a target-files.zip.
Change-Id: Ie64acdb4cee4326938c4ad5a34b575d7b82478c0
2018-02-01 21:00:19 +01:00
|
|
|
'SYSTEM/etc/recovery.img', expected_recovery_sha1)
|
2017-06-21 02:00:55 +02:00
|
|
|
else:
|
|
|
|
# We're patching boot.img to get recovery.img where bonus_args is optional
|
|
|
|
if applypatch_argv[1] == "-b":
|
|
|
|
assert len(applypatch_argv) == 8
|
|
|
|
boot_info_index = 3
|
|
|
|
else:
|
|
|
|
assert len(applypatch_argv) == 6
|
|
|
|
boot_info_index = 1
|
|
|
|
|
|
|
|
# boot_info: boot_type:boot_device:boot_size:boot_sha1
|
|
|
|
boot_info = applypatch_argv[boot_info_index].strip().split(':')
|
|
|
|
assert len(boot_info) == 4
|
|
|
|
ValidateFileAgainstSha1(input_tmp, file_name='boot.img',
|
releasetools: Make validate_target_files.py pylint clean.
C: 73, 0: Wrong hanging indentation (add 4 spaces).
file_name, actual_sha1, expected_sha1)
^ | (bad-continuation)
C:171, 0: Wrong continued indentation (add 20 spaces).
'SYSTEM/etc/recovery.img', expected_recovery_sha1)
^ | (bad-continuation)
C:185, 0: Wrong continued indentation (add 20 spaces).
file_path='IMAGES/boot.img', expected_sha1=boot_info[3])
^ | (bad-continuation)
C:191, 0: Wrong continued indentation (add 20 spaces).
file_path='IMAGES/recovery.img',
^ | (bad-continuation)
C:192, 0: Wrong continued indentation (add 20 spaces).
expected_sha1=expected_recovery_sha1)
^ | (bad-continuation)
W: 67,15: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
W:150,17: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
W:153,15: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
W:194,15: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
C: 27, 0: standard import "import logging" comes before "import common" (wrong-import-order)
C: 28, 0: standard import "import os.path" comes before "import common" (wrong-import-order)
C: 29, 0: standard import "import re" comes before "import common" (wrong-import-order)
C: 31, 0: standard import "import sys" comes before "import common" (wrong-import-order)
Test: pylint --rcfile=pylintrc validate_target_files.py
Test: Run validate_target_files.py with a target-files.zip.
Change-Id: Ie64acdb4cee4326938c4ad5a34b575d7b82478c0
2018-02-01 21:00:19 +01:00
|
|
|
file_path='IMAGES/boot.img',
|
|
|
|
expected_sha1=boot_info[3])
|
2017-06-21 02:00:55 +02:00
|
|
|
|
|
|
|
recovery_sha1_index = boot_info_index + 2
|
|
|
|
expected_recovery_sha1 = applypatch_argv[recovery_sha1_index]
|
|
|
|
assert expected_recovery_check_sha1 == expected_recovery_sha1
|
|
|
|
ValidateFileAgainstSha1(input_tmp, file_name='recovery.img',
|
releasetools: Make validate_target_files.py pylint clean.
C: 73, 0: Wrong hanging indentation (add 4 spaces).
file_name, actual_sha1, expected_sha1)
^ | (bad-continuation)
C:171, 0: Wrong continued indentation (add 20 spaces).
'SYSTEM/etc/recovery.img', expected_recovery_sha1)
^ | (bad-continuation)
C:185, 0: Wrong continued indentation (add 20 spaces).
file_path='IMAGES/boot.img', expected_sha1=boot_info[3])
^ | (bad-continuation)
C:191, 0: Wrong continued indentation (add 20 spaces).
file_path='IMAGES/recovery.img',
^ | (bad-continuation)
C:192, 0: Wrong continued indentation (add 20 spaces).
expected_sha1=expected_recovery_sha1)
^ | (bad-continuation)
W: 67,15: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
W:150,17: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
W:153,15: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
W:194,15: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
C: 27, 0: standard import "import logging" comes before "import common" (wrong-import-order)
C: 28, 0: standard import "import os.path" comes before "import common" (wrong-import-order)
C: 29, 0: standard import "import re" comes before "import common" (wrong-import-order)
C: 31, 0: standard import "import sys" comes before "import common" (wrong-import-order)
Test: pylint --rcfile=pylintrc validate_target_files.py
Test: Run validate_target_files.py with a target-files.zip.
Change-Id: Ie64acdb4cee4326938c4ad5a34b575d7b82478c0
2018-02-01 21:00:19 +01:00
|
|
|
file_path='IMAGES/recovery.img',
|
|
|
|
expected_sha1=expected_recovery_sha1)
|
2017-06-21 02:00:55 +02:00
|
|
|
|
releasetools: Make validate_target_files.py pylint clean.
C: 73, 0: Wrong hanging indentation (add 4 spaces).
file_name, actual_sha1, expected_sha1)
^ | (bad-continuation)
C:171, 0: Wrong continued indentation (add 20 spaces).
'SYSTEM/etc/recovery.img', expected_recovery_sha1)
^ | (bad-continuation)
C:185, 0: Wrong continued indentation (add 20 spaces).
file_path='IMAGES/boot.img', expected_sha1=boot_info[3])
^ | (bad-continuation)
C:191, 0: Wrong continued indentation (add 20 spaces).
file_path='IMAGES/recovery.img',
^ | (bad-continuation)
C:192, 0: Wrong continued indentation (add 20 spaces).
expected_sha1=expected_recovery_sha1)
^ | (bad-continuation)
W: 67,15: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
W:150,17: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
W:153,15: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
W:194,15: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
C: 27, 0: standard import "import logging" comes before "import common" (wrong-import-order)
C: 28, 0: standard import "import os.path" comes before "import common" (wrong-import-order)
C: 29, 0: standard import "import re" comes before "import common" (wrong-import-order)
C: 31, 0: standard import "import sys" comes before "import common" (wrong-import-order)
Test: pylint --rcfile=pylintrc validate_target_files.py
Test: Run validate_target_files.py with a target-files.zip.
Change-Id: Ie64acdb4cee4326938c4ad5a34b575d7b82478c0
2018-02-01 21:00:19 +01:00
|
|
|
logging.info('Done checking %s', script_path)
|
2017-06-21 02:00:55 +02:00
|
|
|
|
|
|
|
|
2017-02-28 00:08:36 +01:00
|
|
|
def main(argv):
|
|
|
|
def option_handler():
|
|
|
|
return True
|
|
|
|
|
|
|
|
args = common.ParseOptions(
|
|
|
|
argv, __doc__, extra_opts="",
|
|
|
|
extra_long_opts=[],
|
|
|
|
extra_option_handler=option_handler)
|
|
|
|
|
|
|
|
if len(args) != 1:
|
|
|
|
common.Usage(__doc__)
|
|
|
|
sys.exit(1)
|
|
|
|
|
|
|
|
logging_format = '%(asctime)s - %(filename)s - %(levelname)-8s: %(message)s'
|
|
|
|
date_format = '%Y/%m/%d %H:%M:%S'
|
|
|
|
logging.basicConfig(level=logging.INFO, format=logging_format,
|
|
|
|
datefmt=date_format)
|
|
|
|
|
|
|
|
logging.info("Unzipping the input target_files.zip: %s", args[0])
|
|
|
|
input_tmp, input_zip = common.UnzipTemp(args[0])
|
|
|
|
|
|
|
|
ValidateFileConsistency(input_zip, input_tmp)
|
|
|
|
|
2017-06-21 02:00:55 +02:00
|
|
|
info_dict = common.LoadInfoDict(input_tmp)
|
|
|
|
ValidateInstallRecoveryScript(input_tmp, info_dict)
|
|
|
|
|
2017-02-28 00:08:36 +01:00
|
|
|
# TODO: Check if the OTA keys have been properly updated (the ones on /system,
|
|
|
|
# in recovery image).
|
|
|
|
|
|
|
|
logging.info("Done.")
|
|
|
|
|
|
|
|
|
|
|
|
if __name__ == '__main__':
|
|
|
|
try:
|
|
|
|
main(sys.argv[1:])
|
|
|
|
finally:
|
|
|
|
common.Cleanup()
|