From 1429291d9fe34952186916ee68ff238024d1bc09 Mon Sep 17 00:00:00 2001 From: Logan Chien Date: Mon, 9 Dec 2019 13:24:35 -0800 Subject: [PATCH] Enable prebuilt ELF check for all targets This commit enables prebuilt ELF checks on ALL targets. If this commit breaks your target, you may triage the breakage by adding the following setting to your `BoardConfig.mk`: BUILD_BROKEN_PREBUILT_ELF_FILES := true And then fix the problem with the instructions: https://source.android.com/devices/architecture/vndk/abi-use-check Bug: 141176116 Bug: 145925470 Test: for t in ${ALL_TARGETS}; do lunch $t; make check-elf-files; done Change-Id: I62e0269074afe1d685cb63d5f8953a2acf03f03e --- core/check_elf_file.mk | 6 ------ 1 file changed, 6 deletions(-) diff --git a/core/check_elf_file.mk b/core/check_elf_file.mk index 7a5de67695..da4168df8a 100644 --- a/core/check_elf_file.mk +++ b/core/check_elf_file.mk @@ -40,13 +40,7 @@ $(check_elf_files_stamp): $(my_prebuilt_src_file) $(my_check_elf_file_shared_lib ifneq ($(strip $(LOCAL_CHECK_ELF_FILES)),false) ifneq ($(strip $(BUILD_BROKEN_PREBUILT_ELF_FILES)),true) -# TODO(b/141176116): Remove the PRODUCT_CHECK_ELF_FILES condition below and -# cover `make droid` targets after everything goes well with `make checkbuild` -# targets. -ifneq ($(PRODUCT_CHECK_ELF_FILES)$(CHECK_ELF_FILES),) $(LOCAL_BUILT_MODULE): $(check_elf_files_stamp) -endif # PRODUCT_CHECK_ELF_FILES or CHECK_ELF_FILES - check-elf-files: $(check_elf_files_stamp) endif # BUILD_BROKEN_PREBUILT_ELF_FILES endif # LOCAL_CHECK_ELF_FILES