tequilaOS/platform_build
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge "Simplify DEFAULT_LOCAL_TIDY_CHECKS."

Browse source
This commit is contained in:
Chih-hung Hsieh 2016-08-08 23:22:13 +00:00 committed by Gerrit Code Review
commit 4d9d191ee7
1 changed files with 25 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

50
core/clang/tidy.mk
View file

@ -19,30 +19,30 @@
# and misc-macro-parentheses, but not google-readability* # and misc-macro-parentheses, but not google-readability*
# or google-runtime-references. # or google-runtime-references.
DEFAULT_GLOBAL_TIDY_CHECKS := \ DEFAULT_GLOBAL_TIDY_CHECKS := \
-*,google*,performance*,misc-macro-parentheses \ $(subst $(space),, \
,-google-readability*,-google-runtime-references -*,google*,performance*,misc-macro-parentheses \
,-google-readability*,-google-runtime-references \
)
# There are too many clang-tidy warnings in external and vendor projects.
# Enable only some google checks for these projects.
DEFAULT_EXTERNAL_VENDOR_TIDY_CHECKS := \
$(subst $(space),, \
-*,google*,-google-build-using-namespace \
,-google-readability*,-google-runtime-references \
,-google-explicit-constructor,-google-runtime-int \
)
# Disable style rules usually not followed by external projects.
# Every word in DEFAULT_LOCAL_TIDY_CHECKS list has the following format: # Every word in DEFAULT_LOCAL_TIDY_CHECKS list has the following format:
# <local_path_prefix>:,<tidy-check-pattern> # <local_path_prefix>:,<tidy-checks>
# The tidy-check-patterns of all matching local_path_prefixes will be used. # The last matched local_path_prefix should be the most specific to be used.
# For example, external/google* projects will have:
# ,-google-build-using-namespace,-google-explicit-constructor
# ,-google-runtime-int,-misc-macro-parentheses,
# ,google-runtime-int,misc-macro-parentheses
# where google-runtime-int and misc-macro-parentheses are enabled at the end.
DEFAULT_LOCAL_TIDY_CHECKS := \ DEFAULT_LOCAL_TIDY_CHECKS := \
external/:,-google-build-using-namespace \ external/:$(DEFAULT_EXTERNAL_VENDOR_TIDY_CHECKS) \
external/:,-google-explicit-constructor,-google-runtime-int \ external/google:$(DEFAULT_GLOBAL_TIDY_CHECKS) \
external/:,-misc-macro-parentheses \ external/webrtc:$(DEFAULT_GLOBAL_TIDY_CHECKS) \
external/google:,google-runtime-int,misc-macro-parentheses \ hardware/qcom:$(DEFAULT_EXTERNAL_VENDOR_TIDY_CHECKS) \
external/webrtc/:,google-runtime-int \ vendor/:$(DEFAULT_EXTERNAL_VENDOR_TIDY_CHECKS) \
hardware/qcom:,-google-build-using-namespace \ vendor/google:$(DEFAULT_GLOBAL_TIDY_CHECKS) \
hardware/qcom:,-google-explicit-constructor,-google-runtime-int \
vendor/lge:,-google-build-using-namespace,-misc-macro-parentheses \
vendor/lge:,-google-explicit-constructor,-google-runtime-int \
vendor/widevine:,-google-build-using-namespace,-misc-macro-parentheses \
vendor/widevine:,-google-explicit-constructor,-google-runtime-int \
# Returns 2nd word of $(1) if $(2) has prefix of the 1st word of $(1). # Returns 2nd word of $(1) if $(2) has prefix of the 1st word of $(1).
define find_default_local_tidy_check2 define find_default_local_tidy_check2
@ -54,11 +54,11 @@ define find_default_local_tidy_check
$(call find_default_local_tidy_check2,$(subst :,$(space),$(1)),$(2)) $(call find_default_local_tidy_check2,$(subst :,$(space),$(1)),$(2))
endef endef
# Returns concatenated tidy check patterns from the # Returns the default tidy check list for local project path $(1).
# DEFAULT_GLOBAL_TIDY_CHECKS and all matched patterns # Match $(1) with all patterns in DEFAULT_LOCAL_TIDY_CHECKS and use the last
# in DEFAULT_LOCAL_TIDY_CHECKS based on given directory path $(1). # most specific pattern.
define default_global_tidy_checks define default_global_tidy_checks
$(subst $(space),, \ $(lastword \
$(DEFAULT_GLOBAL_TIDY_CHECKS) \ $(DEFAULT_GLOBAL_TIDY_CHECKS) \
$(foreach pattern,$(DEFAULT_LOCAL_TIDY_CHECKS), \ $(foreach pattern,$(DEFAULT_LOCAL_TIDY_CHECKS), \
$(call find_default_local_tidy_check,$(pattern),$(1)) \ $(call find_default_local_tidy_check,$(pattern),$(1)) \