diff --git a/tools/aconfig/aconfig/src/codegen/java.rs b/tools/aconfig/aconfig/src/codegen/java.rs index 920d5fac1e..18a4be5094 100644 --- a/tools/aconfig/aconfig/src/codegen/java.rs +++ b/tools/aconfig/aconfig/src/codegen/java.rs @@ -180,8 +180,8 @@ mod tests { import android.compat.annotation.UnsupportedAppUsage; /** @hide */ public interface FeatureFlags { - @com.android.aconfig.annotations.AconfigFlagAccessor @com.android.aconfig.annotations.AssumeFalseForR8 + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage boolean disabledRo(); @com.android.aconfig.annotations.AconfigFlagAccessor @@ -193,20 +193,20 @@ mod tests { @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage boolean disabledRwInOtherNamespace(); - @com.android.aconfig.annotations.AconfigFlagAccessor @com.android.aconfig.annotations.AssumeTrueForR8 + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage boolean enabledFixedRo(); - @com.android.aconfig.annotations.AconfigFlagAccessor @com.android.aconfig.annotations.AssumeTrueForR8 + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage boolean enabledFixedRoExported(); - @com.android.aconfig.annotations.AconfigFlagAccessor @com.android.aconfig.annotations.AssumeTrueForR8 + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage boolean enabledRo(); - @com.android.aconfig.annotations.AconfigFlagAccessor @com.android.aconfig.annotations.AssumeTrueForR8 + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage boolean enabledRoExported(); @com.android.aconfig.annotations.AconfigFlagAccessor @@ -240,8 +240,8 @@ mod tests { /** @hide */ public static final String FLAG_ENABLED_RW = "com.android.aconfig.test.enabled_rw"; - @com.android.aconfig.annotations.AconfigFlagAccessor @com.android.aconfig.annotations.AssumeFalseForR8 + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage public static boolean disabledRo() { return FEATURE_FLAGS.disabledRo(); @@ -261,26 +261,26 @@ mod tests { public static boolean disabledRwInOtherNamespace() { return FEATURE_FLAGS.disabledRwInOtherNamespace(); } - @com.android.aconfig.annotations.AconfigFlagAccessor @com.android.aconfig.annotations.AssumeTrueForR8 + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage public static boolean enabledFixedRo() { return FEATURE_FLAGS.enabledFixedRo(); } - @com.android.aconfig.annotations.AconfigFlagAccessor @com.android.aconfig.annotations.AssumeTrueForR8 + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage public static boolean enabledFixedRoExported() { return FEATURE_FLAGS.enabledFixedRoExported(); } - @com.android.aconfig.annotations.AconfigFlagAccessor @com.android.aconfig.annotations.AssumeTrueForR8 + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage public static boolean enabledRo() { return FEATURE_FLAGS.enabledRo(); } - @com.android.aconfig.annotations.AconfigFlagAccessor @com.android.aconfig.annotations.AssumeTrueForR8 + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage public static boolean enabledRoExported() { return FEATURE_FLAGS.enabledRoExported(); @@ -476,14 +476,14 @@ mod tests { other_namespace_is_cached = true; } - @com.android.aconfig.annotations.AconfigFlagAccessor @Override + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage public boolean disabledRo() { return false; } - @com.android.aconfig.annotations.AconfigFlagAccessor @Override + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage public boolean disabledRw() { if (!aconfig_test_is_cached) { @@ -491,8 +491,8 @@ mod tests { } return disabledRw; } - @com.android.aconfig.annotations.AconfigFlagAccessor @Override + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage public boolean disabledRwExported() { if (!aconfig_test_is_cached) { @@ -500,8 +500,8 @@ mod tests { } return disabledRwExported; } - @com.android.aconfig.annotations.AconfigFlagAccessor @Override + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage public boolean disabledRwInOtherNamespace() { if (!other_namespace_is_cached) { @@ -509,32 +509,32 @@ mod tests { } return disabledRwInOtherNamespace; } - @com.android.aconfig.annotations.AconfigFlagAccessor @Override + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage public boolean enabledFixedRo() { return true; } - @com.android.aconfig.annotations.AconfigFlagAccessor @Override + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage public boolean enabledFixedRoExported() { return true; } - @com.android.aconfig.annotations.AconfigFlagAccessor @Override + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage public boolean enabledRo() { return true; } - @com.android.aconfig.annotations.AconfigFlagAccessor @Override + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage public boolean enabledRoExported() { return true; } - @com.android.aconfig.annotations.AconfigFlagAccessor @Override + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage public boolean enabledRw() { if (!aconfig_test_is_cached) { @@ -592,15 +592,12 @@ mod tests { public static final String FLAG_ENABLED_FIXED_RO_EXPORTED = "com.android.aconfig.test.enabled_fixed_ro_exported"; /** @hide */ public static final String FLAG_ENABLED_RO_EXPORTED = "com.android.aconfig.test.enabled_ro_exported"; - @com.android.aconfig.annotations.AconfigFlagAccessor public static boolean disabledRwExported() { return FEATURE_FLAGS.disabledRwExported(); } - @com.android.aconfig.annotations.AconfigFlagAccessor public static boolean enabledFixedRoExported() { return FEATURE_FLAGS.enabledFixedRoExported(); } - @com.android.aconfig.annotations.AconfigFlagAccessor public static boolean enabledRoExported() { return FEATURE_FLAGS.enabledRoExported(); } @@ -612,11 +609,8 @@ mod tests { package com.android.aconfig.test; /** @hide */ public interface FeatureFlags { - @com.android.aconfig.annotations.AconfigFlagAccessor boolean disabledRwExported(); - @com.android.aconfig.annotations.AconfigFlagAccessor boolean enabledFixedRoExported(); - @com.android.aconfig.annotations.AconfigFlagAccessor boolean enabledRoExported(); } "#; @@ -654,7 +648,6 @@ mod tests { } aconfig_test_is_cached = true; } - @com.android.aconfig.annotations.AconfigFlagAccessor @Override public boolean disabledRwExported() { if (!aconfig_test_is_cached) { @@ -662,7 +655,6 @@ mod tests { } return disabledRwExported; } - @com.android.aconfig.annotations.AconfigFlagAccessor @Override public boolean enabledFixedRoExported() { if (!aconfig_test_is_cached) { @@ -670,7 +662,6 @@ mod tests { } return enabledFixedRoExported; } - @com.android.aconfig.annotations.AconfigFlagAccessor @Override public boolean enabledRoExported() { if (!aconfig_test_is_cached) { @@ -792,64 +783,64 @@ mod tests { import android.compat.annotation.UnsupportedAppUsage; /** @hide */ public final class FeatureFlagsImpl implements FeatureFlags { - @com.android.aconfig.annotations.AconfigFlagAccessor @Override + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage public boolean disabledRo() { throw new UnsupportedOperationException( "Method is not implemented."); } - @com.android.aconfig.annotations.AconfigFlagAccessor @Override + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage public boolean disabledRw() { throw new UnsupportedOperationException( "Method is not implemented."); } - @com.android.aconfig.annotations.AconfigFlagAccessor @Override + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage public boolean disabledRwExported() { throw new UnsupportedOperationException( "Method is not implemented."); } - @com.android.aconfig.annotations.AconfigFlagAccessor @Override + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage public boolean disabledRwInOtherNamespace() { throw new UnsupportedOperationException( "Method is not implemented."); } - @com.android.aconfig.annotations.AconfigFlagAccessor @Override + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage public boolean enabledFixedRo() { throw new UnsupportedOperationException( "Method is not implemented."); } - @com.android.aconfig.annotations.AconfigFlagAccessor @Override + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage public boolean enabledFixedRoExported() { throw new UnsupportedOperationException( "Method is not implemented."); } - @com.android.aconfig.annotations.AconfigFlagAccessor @Override + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage public boolean enabledRo() { throw new UnsupportedOperationException( "Method is not implemented."); } - @com.android.aconfig.annotations.AconfigFlagAccessor @Override + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage public boolean enabledRoExported() { throw new UnsupportedOperationException( "Method is not implemented."); } - @com.android.aconfig.annotations.AconfigFlagAccessor @Override + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage public boolean enabledRw() { throw new UnsupportedOperationException( @@ -901,28 +892,28 @@ mod tests { import android.compat.annotation.UnsupportedAppUsage; /** @hide */ public interface FeatureFlags { - @com.android.aconfig.annotations.AconfigFlagAccessor @com.android.aconfig.annotations.AssumeFalseForR8 + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage boolean disabledRo(); - @com.android.aconfig.annotations.AconfigFlagAccessor @com.android.aconfig.annotations.AssumeFalseForR8 + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage boolean disabledRw(); - @com.android.aconfig.annotations.AconfigFlagAccessor @com.android.aconfig.annotations.AssumeFalseForR8 + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage boolean disabledRwInOtherNamespace(); - @com.android.aconfig.annotations.AconfigFlagAccessor @com.android.aconfig.annotations.AssumeTrueForR8 + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage boolean enabledFixedRo(); - @com.android.aconfig.annotations.AconfigFlagAccessor @com.android.aconfig.annotations.AssumeTrueForR8 + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage boolean enabledRo(); - @com.android.aconfig.annotations.AconfigFlagAccessor @com.android.aconfig.annotations.AssumeTrueForR8 + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage boolean enabledRw(); }"#; @@ -933,38 +924,38 @@ mod tests { import android.compat.annotation.UnsupportedAppUsage; /** @hide */ public final class FeatureFlagsImpl implements FeatureFlags { - @com.android.aconfig.annotations.AconfigFlagAccessor @Override + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage public boolean disabledRo() { return false; } - @com.android.aconfig.annotations.AconfigFlagAccessor @Override + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage public boolean disabledRw() { return false; } - @com.android.aconfig.annotations.AconfigFlagAccessor @Override + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage public boolean disabledRwInOtherNamespace() { return false; } - @com.android.aconfig.annotations.AconfigFlagAccessor @Override + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage public boolean enabledFixedRo() { return true; } - @com.android.aconfig.annotations.AconfigFlagAccessor @Override + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage public boolean enabledRo() { return true; } - @com.android.aconfig.annotations.AconfigFlagAccessor @Override + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage public boolean enabledRw() { return true; @@ -990,38 +981,38 @@ mod tests { public static final String FLAG_ENABLED_RO = "com.android.aconfig.test.enabled_ro"; /** @hide */ public static final String FLAG_ENABLED_RW = "com.android.aconfig.test.enabled_rw"; - @com.android.aconfig.annotations.AconfigFlagAccessor @com.android.aconfig.annotations.AssumeFalseForR8 + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage public static boolean disabledRo() { return FEATURE_FLAGS.disabledRo(); } - @com.android.aconfig.annotations.AconfigFlagAccessor @com.android.aconfig.annotations.AssumeFalseForR8 + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage public static boolean disabledRw() { return FEATURE_FLAGS.disabledRw(); } - @com.android.aconfig.annotations.AconfigFlagAccessor @com.android.aconfig.annotations.AssumeFalseForR8 + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage public static boolean disabledRwInOtherNamespace() { return FEATURE_FLAGS.disabledRwInOtherNamespace(); } - @com.android.aconfig.annotations.AconfigFlagAccessor @com.android.aconfig.annotations.AssumeTrueForR8 + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage public static boolean enabledFixedRo() { return FEATURE_FLAGS.enabledFixedRo(); } - @com.android.aconfig.annotations.AconfigFlagAccessor @com.android.aconfig.annotations.AssumeTrueForR8 + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage public static boolean enabledRo() { return FEATURE_FLAGS.enabledRo(); } - @com.android.aconfig.annotations.AconfigFlagAccessor @com.android.aconfig.annotations.AssumeTrueForR8 + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage public static boolean enabledRw() { return FEATURE_FLAGS.enabledRw(); diff --git a/tools/aconfig/aconfig/templates/FeatureFlags.java.template b/tools/aconfig/aconfig/templates/FeatureFlags.java.template index b90b201ebf..38c8f13aaf 100644 --- a/tools/aconfig/aconfig/templates/FeatureFlags.java.template +++ b/tools/aconfig/aconfig/templates/FeatureFlags.java.template @@ -6,7 +6,6 @@ import android.compat.annotation.UnsupportedAppUsage; /** @hide */ public interface FeatureFlags \{ {{ for item in flag_elements }} - @com.android.aconfig.annotations.AconfigFlagAccessor {{ -if not item.is_read_write }} {{ -if item.default_value }} @com.android.aconfig.annotations.AssumeTrueForR8 @@ -15,6 +14,7 @@ public interface FeatureFlags \{ {{ -endif- }} {{ -endif }} {{ -if not library_exported }} + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage {{ -endif }} boolean {item.method_name}(); diff --git a/tools/aconfig/aconfig/templates/FeatureFlagsImpl.java.template b/tools/aconfig/aconfig/templates/FeatureFlagsImpl.java.template index 704f25bb75..6235e6946c 100644 --- a/tools/aconfig/aconfig/templates/FeatureFlagsImpl.java.template +++ b/tools/aconfig/aconfig/templates/FeatureFlagsImpl.java.template @@ -45,9 +45,9 @@ public final class FeatureFlagsImpl implements FeatureFlags \{ {{ endfor- }} {{ -endif }}{#- end of runtime_lookup_required #} {{ -for flag in flag_elements }} - @com.android.aconfig.annotations.AconfigFlagAccessor @Override {{ -if not library_exported }} + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage {{ -endif }} public boolean {flag.method_name}() \{ @@ -67,9 +67,9 @@ public final class FeatureFlagsImpl implements FeatureFlags \{ /** @hide */ public final class FeatureFlagsImpl implements FeatureFlags \{ {{ for flag in flag_elements }} - @com.android.aconfig.annotations.AconfigFlagAccessor @Override {{ -if not library_exported }} + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage {{ -endif }} public boolean {flag.method_name}() \{ diff --git a/tools/aconfig/aconfig/templates/Flags.java.template b/tools/aconfig/aconfig/templates/Flags.java.template index 55db924595..e2f70b95fa 100644 --- a/tools/aconfig/aconfig/templates/Flags.java.template +++ b/tools/aconfig/aconfig/templates/Flags.java.template @@ -10,7 +10,6 @@ public final class Flags \{ public static final String FLAG_{item.flag_name_constant_suffix} = "{item.device_config_flag}"; {{- endfor }} {{ -for item in flag_elements}} - @com.android.aconfig.annotations.AconfigFlagAccessor {{ -if not item.is_read_write }} {{ -if item.default_value }} @com.android.aconfig.annotations.AssumeTrueForR8 @@ -19,6 +18,7 @@ public final class Flags \{ {{ -endif }} {{ -endif }} {{ -if not library_exported }} + @com.android.aconfig.annotations.AconfigFlagAccessor @UnsupportedAppUsage {{ -endif }} public static boolean {item.method_name}() \{