Remove --blkid_path argument

deapexer doesn't need it.

Bug: 279858383
Test: presubmit
Change-Id: If0ec42b5edd4642f07c96ba641030c4dd6fb4660
This commit is contained in:
Jooyung Han 2023-06-14 15:16:34 +09:00
parent c37e824f56
commit 629490292a
4 changed files with 1 additions and 14 deletions

View file

@ -5297,7 +5297,6 @@ INTERNAL_OTATOOLS_MODULES := \
INTERNAL_OTATOOLS_MODULES += \ INTERNAL_OTATOOLS_MODULES += \
apexer \ apexer \
apex_compression_tool \ apex_compression_tool \
blkid_static \
deapexer \ deapexer \
debugfs_static \ debugfs_static \
dump_apex_info \ dump_apex_info \

View file

@ -65,8 +65,6 @@ class ApexApkSigner(object):
OPTIONS.search_path, "bin", "debugfs_static") OPTIONS.search_path, "bin", "debugfs_static")
self.fsckerofs_path = os.path.join( self.fsckerofs_path = os.path.join(
OPTIONS.search_path, "bin", "fsck.erofs") OPTIONS.search_path, "bin", "fsck.erofs")
self.blkid_path = os.path.join(
OPTIONS.search_path, "bin", "blkid_static")
self.avbtool = avbtool if avbtool else "avbtool" self.avbtool = avbtool if avbtool else "avbtool"
self.sign_tool = sign_tool self.sign_tool = sign_tool
@ -129,15 +127,10 @@ class ApexApkSigner(object):
"Couldn't find location of fsck.erofs: " + "Couldn't find location of fsck.erofs: " +
"Path {} does not exist. ".format(self.fsckerofs_path) + "Path {} does not exist. ".format(self.fsckerofs_path) +
"Make sure bin/fsck.erofs can be found in -p <path>") "Make sure bin/fsck.erofs can be found in -p <path>")
if not os.path.exists(self.blkid_path):
raise ApexSigningError(
"Couldn't find location of blkid: " +
"Path {} does not exist. ".format(self.blkid_path) +
"Make sure bin/blkid can be found in -p <path>")
payload_dir = common.MakeTempDir() payload_dir = common.MakeTempDir()
extract_cmd = ['deapexer', '--debugfs_path', self.debugfs_path, extract_cmd = ['deapexer', '--debugfs_path', self.debugfs_path,
'--fsckerofs_path', self.fsckerofs_path, '--fsckerofs_path', self.fsckerofs_path,
'--blkid_path', self.blkid_path, 'extract', 'extract',
self.apex_path, payload_dir] self.apex_path, payload_dir]
common.RunAndCheckOutput(extract_cmd) common.RunAndCheckOutput(extract_cmd)
assert os.path.exists(self.apex_path) assert os.path.exists(self.apex_path)

View file

@ -232,12 +232,10 @@ def PrepareApexDirectory(inp):
deapexer = 'deapexer' deapexer = 'deapexer'
debugfs_path = 'debugfs' debugfs_path = 'debugfs'
blkid_path = 'blkid'
fsckerofs_path = 'fsck.erofs' fsckerofs_path = 'fsck.erofs'
if OPTIONS.search_path: if OPTIONS.search_path:
debugfs_path = os.path.join(OPTIONS.search_path, 'bin', 'debugfs_static') debugfs_path = os.path.join(OPTIONS.search_path, 'bin', 'debugfs_static')
deapexer_path = os.path.join(OPTIONS.search_path, 'bin', 'deapexer') deapexer_path = os.path.join(OPTIONS.search_path, 'bin', 'deapexer')
blkid_path = os.path.join(OPTIONS.search_path, 'bin', 'blkid_static')
fsckerofs_path = os.path.join(OPTIONS.search_path, 'bin', 'fsck.erofs') fsckerofs_path = os.path.join(OPTIONS.search_path, 'bin', 'fsck.erofs')
if os.path.isfile(deapexer_path): if os.path.isfile(deapexer_path):
deapexer = deapexer_path deapexer = deapexer_path
@ -263,7 +261,6 @@ def PrepareApexDirectory(inp):
cmd = [deapexer, cmd = [deapexer,
'--debugfs_path', debugfs_path, '--debugfs_path', debugfs_path,
'--fsckerofs_path', fsckerofs_path, '--fsckerofs_path', fsckerofs_path,
'--blkid_path', blkid_path,
'extract', 'extract',
apex, apex,
os.path.join(outp, info['name'])] os.path.join(outp, info['name'])]

View file

@ -164,8 +164,6 @@ def MergeDexopt(temp_dir, output_target_files_dir):
'deapexer', 'deapexer',
'--debugfs_path', '--debugfs_path',
'debugfs_static', 'debugfs_static',
'--blkid_path',
'blkid',
'--fsckerofs_path', '--fsckerofs_path',
'fsck.erofs', 'fsck.erofs',
'extract', 'extract',