Merge "Only enable zucchini if configuration file exists"

This commit is contained in:
Treehugger Robot 2022-05-04 02:39:39 +00:00 committed by Gerrit Code Review
commit 7b53ae67f1
2 changed files with 6 additions and 3 deletions

View file

@ -1208,6 +1208,8 @@ def GenerateAbOtaPackage(target_file, output_file, source_file=None):
metadata.postcondition.partition_state)
if not ota_utils.IsZucchiniCompatible(source_file, target_file):
logger.warning(
"Builds doesn't support zucchini, or source/target don't have compatible zucchini versions. Disabling zucchini.")
OPTIONS.enable_zucchini = False
additional_args += ["--enable_zucchini",

View file

@ -697,6 +697,7 @@ def IsZucchiniCompatible(source_file: str, target_file: str):
if os.path.exists(entry_path):
with open(entry_path, "r") as fp:
return fp.read()
else:
return ""
return ReadEntry(source_file, _ZUCCHINI_CONFIG_ENTRY_NAME) == ReadEntry(target_file, _ZUCCHINI_CONFIG_ENTRY_NAME)
return False
sourceEntry = ReadEntry(source_file, _ZUCCHINI_CONFIG_ENTRY_NAME)
targetEntry = ReadEntry(target_file, _ZUCCHINI_CONFIG_ENTRY_NAME)
return sourceEntry and targetEntry and sourceEntry == targetEntry