Fix the signing error on no-system-image targets
Currently when running sign_target_files_apks on a no-system-image target, it will raise the following error: ValueError: max() arg is an empty sequence This is because there is no APK files in the target_files.zip. Fixing this by setting maxsize to zero in this case. Bug: 213028932 Test: lunch gki_arm64-userdebug; make dist Test: sign_target_files_apks \ --gki_signing_key=external/avb/test/data/testkey_rsa4096.pem \ --gki_signing_algorithm=SHA256_RSA4096 \ --gki_signing_extra_args="--prop gki:prop1 --prop gki:prop2" \ ./out/dist/*-target_files-eng.*.zip signed.zip Change-Id: I40daecbc2ff3f89d3e635d1a4a1c1dea31ba9a27
This commit is contained in:
parent
8c861cec97
commit
8d4b72405e
1 changed files with 8 additions and 3 deletions
|
@ -520,9 +520,14 @@ def ProcessTargetFiles(input_tf_zip, output_tf_zip, misc_info,
|
|||
compressed_extension):
|
||||
# maxsize measures the maximum filename length, including the ones to be
|
||||
# skipped.
|
||||
maxsize = max(
|
||||
[len(os.path.basename(i.filename)) for i in input_tf_zip.infolist()
|
||||
if GetApkFileInfo(i.filename, compressed_extension, [])[0]])
|
||||
try:
|
||||
maxsize = max(
|
||||
[len(os.path.basename(i.filename)) for i in input_tf_zip.infolist()
|
||||
if GetApkFileInfo(i.filename, compressed_extension, [])[0]])
|
||||
except ValueError:
|
||||
# Sets this to zero for targets without APK files, e.g., gki_arm64.
|
||||
maxsize = 0
|
||||
|
||||
system_root_image = misc_info.get("system_root_image") == "true"
|
||||
|
||||
for info in input_tf_zip.infolist():
|
||||
|
|
Loading…
Reference in a new issue