From 8b3850d8e5b87c322b9ec53be678b6db2c52b632 Mon Sep 17 00:00:00 2001 From: Kousik Kumar Date: Tue, 4 Feb 2020 18:28:48 -0800 Subject: [PATCH] [DO NOT MERGE] Add exec_strategy as CLI flags to all rewrapper commands Bug: b/148798195 Test: The same change is live in master-build-rbe-testing branch where its not causing any behavior change, and also it works for RemoteExecution where RBE_CXX_EXEC_STRATEGY variable is set. Bug: b/166182389 Change-Id: I5efb1c2ab74dbe70dd70bf43d6262f2063d4d378 Merged-In: I745ed4a91c2b070048c0b1fd0881e5f4f28d0148 --- core/rbe.mk | 33 +++++++++++++++++++++++++++++---- 1 file changed, 29 insertions(+), 4 deletions(-) diff --git a/core/rbe.mk b/core/rbe.mk index 6a923664b7..7886e1ae4b 100644 --- a/core/rbe.mk +++ b/core/rbe.mk @@ -21,8 +21,33 @@ ifneq ($(filter-out false,$(USE_RBE)),) else rbe_dir := $(HOME)/rbe endif + + ifdef RBE_CXX_EXEC_STRATEGY + cxx_rbe_exec_strategy := $(RBE_CXX_EXEC_STRATEGY) + else + cxx_rbe_exec_strategy := "local" + endif + + ifdef RBE_JAVAC_EXEC_STRATEGY + javac_exec_strategy := $(RBE_JAVAC_EXEC_STRATEGY) + else + javac_exec_strategy := "local" + endif + + ifdef RBE_R8_EXEC_STRATEGY + r8_exec_strategy := $(RBE_R8_EXEC_STRATEGY) + else + r8_exec_strategy := "local" + endif + + ifdef RBE_D8_EXEC_STRATEGY + d8_exec_strategy := $(RBE_D8_EXEC_STRATEGY) + else + d8_exec_strategy := "local" + endif + RBE_WRAPPER := $(rbe_dir)/rewrapper - RBE_CXX := --labels=type=compile,lang=cpp,compiler=clang --env_var_whitelist=PWD + RBE_CXX := --labels=type=compile,lang=cpp,compiler=clang --env_var_whitelist=PWD --exec_strategy=$(cxx_rbe_exec_strategy) # Append rewrapper to existing *_WRAPPER variables so it's possible to # use both ccache and rewrapper. @@ -30,15 +55,15 @@ ifneq ($(filter-out false,$(USE_RBE)),) CXX_WRAPPER := $(strip $(CXX_WRAPPER) $(RBE_WRAPPER) $(RBE_CXX)) ifdef RBE_JAVAC - JAVAC_WRAPPER := $(strip $(JAVAC_WRAPPER) $(RBE_WRAPPER) --labels=type=compile,lang=java,compiler=javac,shallow=true) + JAVAC_WRAPPER := $(strip $(JAVAC_WRAPPER) $(RBE_WRAPPER) --labels=type=compile,lang=java,compiler=javac,shallow=true --exec_strategy=$(javac_exec_strategy)) endif ifdef RBE_R8 - R8_WRAPPER := $(strip $(RBE_WRAPPER) --labels=type=compile,compiler=r8,shallow=true) + R8_WRAPPER := $(strip $(RBE_WRAPPER) --labels=type=compile,compiler=r8,shallow=true --exec_strategy=$(r8_exec_strategy)) endif ifdef RBE_D8 - D8_WRAPPER := $(strip $(RBE_WRAPPER) --labels=type=compile,compiler=d8,shallow=true) + D8_WRAPPER := $(strip $(RBE_WRAPPER) --labels=type=compile,compiler=d8,shallow=true --exec_strategy=$(d8_exec_strategy)) endif rbe_dir :=