From 3e1c9115d1e53cee4b77adb8e02bf6cb5a2c189a Mon Sep 17 00:00:00 2001 From: Dan Willemsen Date: Fri, 17 Jul 2020 19:52:55 -0700 Subject: [PATCH] Move some prebuilt build tool configs to Soong Now that they're defined with prebuilt_build_tool, we don't need to set them here. In future changes we can replace more of these definitions with prebuilt_build_tool, as it can centralize the selection of build-from-source or prebuilt for Make, Soong, and user-defined genrules. Test: treehugger Change-Id: I4bb526492ebc6270b6030913c1f5b3f49dc61284 --- core/config.mk | 12 ++---------- core/main.mk | 2 ++ 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/core/config.mk b/core/config.mk index b928af0885..2863e7d055 100644 --- a/core/config.mk +++ b/core/config.mk @@ -587,16 +587,8 @@ SOONG_ZIP := $(SOONG_HOST_OUT_EXECUTABLES)/soong_zip # --------------------------------------------------------------- # Generic tools. -LEX := $(prebuilt_build_tools_bin_noasan)/flex -# The default PKGDATADIR built in the prebuilt bison is a relative path -# prebuilts/build-tools/common/bison. -# To run bison from elsewhere you need to set up enviromental variable -# BISON_PKGDATADIR. -BISON_PKGDATADIR := $(prebuilt_build_tools)/common/bison -BISON := $(prebuilt_build_tools_bin_noasan)/bison -YACC := $(BISON) -d -BISON_DATA := $(wildcard $(BISON_PKGDATADIR)/* $(BISON_PKGDATADIR)/*/*) -M4 :=$= $(prebuilt_build_tools_bin_noasan)/m4 +# These dependencies are now handled via dependencies on prebuilt_build_tool +BISON_DATA :=$= YASM := prebuilts/misc/$(BUILD_OS)-$(HOST_PREBUILT_ARCH)/yasm/yasm diff --git a/core/main.mk b/core/main.mk index f718c9d4b2..cb8aa601da 100644 --- a/core/main.mk +++ b/core/main.mk @@ -33,6 +33,8 @@ endif include $(SOONG_MAKEVARS_MK) +YACC :=$= $(BISON) -d + include $(BUILD_SYSTEM)/clang/config.mk # Write the build number to a file so it can be read back in