From c0f738c974ea94f59d83c90afaa0cfccfe71440a Mon Sep 17 00:00:00 2001 From: Jiyong Park Date: Thu, 21 Jun 2018 14:18:54 +0900 Subject: [PATCH] check-vndk-list is run even when VNDK is not enabled check-vndk-list has not been run when VNDK is not enabled (i.e. BOARD_VNDK_VERSION is unset). This was problematic because there is a chance that a CL which passed pre-submit tests can fail the post-submit tests when the targets selected for the pre-submit tests are all without VNDK enforcement. In order to prevent the case, check-vndk-list is executed regardless of whether BOARD_VNDK_VERSION is set or not. Bug: 110424280 Test: m -j on sailfish Test: m -j on sailfish fails after adding an arbitrary library to VNDK Change-Id: Ia7427be2a297940a9e9c9f46cb058245596171c9 --- target/product/vndk/Android.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/product/vndk/Android.mk b/target/product/vndk/Android.mk index b9ae116184..3e9d8fa0a5 100644 --- a/target/product/vndk/Android.mk +++ b/target/product/vndk/Android.mk @@ -1,4 +1,3 @@ -ifneq ($(BOARD_VNDK_VERSION),) LOCAL_PATH:= $(call my-dir) ##################################################################### @@ -86,6 +85,8 @@ else endif @chmod a+x $@ +ifneq ($(BOARD_VNDK_VERSION),) + include $(CLEAR_VARS) LOCAL_MODULE := vndk_package LOCAL_REQUIRED_MODULES := \