tequilaOS/platform_build
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge "return to using subprocess for running commands" into gingerbread

Browse source
This commit is contained in:
Doug Zongker 2010-09-03 14:31:03 -07:00 committed by Android (Google) Code Review
commit 93d574f8c5
1 changed files with 4 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
tools/releasetools/img_from_target_files
View file

@ -126,19 +126,13 @@ def AddSystem(output_zip):
else:
build_command = ["mkyaffs2image", "-f"]
if OPTIONS.mkyaffs2_extra_flags is not None:
build_command.append(OPTIONS.mkyaffs2_extra_flags);
build_command.extend(OPTIONS.mkyaffs2_extra_flags.split());
build_command.append(os.path.join(OPTIONS.input_tmp, "system"))
build_command.append(img.name)
# p = common.Run(build_command)
# p.communicate()
# assert p.returncode == 0, "build system.img image failed"
# TODO: Why the above common.Run() generate different system.img for crespo?
str_command = " ".join(build_command)
print "running " + str_command
exit_code = os.system(str_command)
assert exit_code == 0, "build system.img image failed"
p = common.Run(build_command)
p.communicate()
assert p.returncode == 0, "build system.img image failed"
img.seek(os.SEEK_SET, 0)
data = img.read()