From 9cd3d8c6543ffb2eef7935d8f832f99675dc630e Mon Sep 17 00:00:00 2001 From: Guang Zhu Date: Tue, 15 Jun 2010 13:31:25 -0700 Subject: [PATCH] improvement for emma filter option the original implementation directly embeds the filter variable into command line; this implies that filter variable cannot contain any whitespaces, otherwise it'll be misintepreted as a new command line argument to emma. the side effect is that user will be forced to cram all filter related java class/package names into one line, which could be very long. with this change, user can use line continuation ("\") or appending ("+=") to break up long filter specs. Change-Id: I2c130033cdb5120251d6f84c3dd906d140d52991 --- core/definitions.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/definitions.mk b/core/definitions.mk index ec712501a1..8ba8eb4534 100644 --- a/core/definitions.mk +++ b/core/definitions.mk @@ -1327,7 +1327,7 @@ endef define transform-classes.jar-to-emma $(hide) java -classpath $(EMMA_JAR) emma instr -outmode fullcopy -outfile \ $(PRIVATE_EMMA_COVERAGE_FILE) -ip $< -d $(PRIVATE_EMMA_INTERMEDIATES_DIR) \ - -ix $(PRIVATE_EMMA_COVERAGE_FILTER) + $(addprefix -ix , $(PRIVATE_EMMA_COVERAGE_FILTER)) endef #TODO: use a smaller -Xmx value for most libraries;