tequilaOS/platform_build
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Refactor metadata tool to support metadata generation for different rules.

Browse source 
Bug: 296873595
Test: Manual test (use go test inside tools/metadata/testdata)

Change-Id: I881fd76213ec78001f9e12ed2fbc860d1503a364
This commit is contained in:
Aditya Choudhary 2023-11-15 11:02:37 +00:00
parent 4277d617f2
commit a96ce3223a
3 changed files with 38 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
tools/metadata/OWNERS Normal file
View file

@ -0,0 +1,4 @@
dariofreni@google.com
joeo@google.com
ronish@google.com
caditya@google.com

56
tools/metadata/generator.go
View file

@ -73,7 +73,7 @@ func readFileToString(filePath string) string {
return string(data)
}
func processProtobuf(
func processTestSpecProtobuf(
filePath string, ownershipMetadataMap *sync.Map, keyLocks *keyToLocksMap,
errCh chan error, wg *sync.WaitGroup,
) {
@ -130,10 +130,11 @@ func processProtobuf(
func main() {
inputFile := flag.String("inputFile", "", "Input file path")
outputFile := flag.String("outputFile", "", "Output file path")
rule := flag.String("rule", "", "Metadata rule (Hint: test_spec or code_metadata)")
flag.Parse()
if *inputFile == "" || *outputFile == "" {
fmt.Println("Usage: metadata -inputFile <input file path> -outputFile <output file path>")
if *inputFile == "" || *outputFile == "" || *rule == "" {
fmt.Println("Usage: metadata -rule <rule> -inputFile <input file path> -outputFile <output file path>")
os.Exit(1)
}
@ -144,26 +145,33 @@ func main() {
errCh := make(chan error, len(filePaths))
var wg sync.WaitGroup
for _, filePath := range filePaths {
wg.Add(1)
go processProtobuf(filePath, ownershipMetadataMap, keyLocks, errCh, &wg)
switch *rule {
case "test_spec":
for _, filePath := range filePaths {
wg.Add(1)
go processTestSpecProtobuf(filePath, ownershipMetadataMap, keyLocks, errCh, &wg)
}
wg.Wait()
close(errCh)
for err := range errCh {
log.Fatal(err)
}
allKeys := getSortedKeys(ownershipMetadataMap)
var allMetadata []*test_spec_proto.TestSpec_OwnershipMetadata
for _, key := range allKeys {
value, _ := ownershipMetadataMap.Load(key)
metadataList := value.([]*test_spec_proto.TestSpec_OwnershipMetadata)
allMetadata = append(allMetadata, metadataList...)
}
writeOutput(*outputFile, allMetadata)
break
case "code_metadata":
default:
log.Fatalf("No specific processing implemented for rule '%s'.\n", *rule)
}
wg.Wait()
close(errCh)
for err := range errCh {
log.Fatal(err)
}
allKeys := getSortedKeys(ownershipMetadataMap)
var allMetadata []*test_spec_proto.TestSpec_OwnershipMetadata
for _, key := range allKeys {
value, _ := ownershipMetadataMap.Load(key)
metadataList := value.([]*test_spec_proto.TestSpec_OwnershipMetadata)
allMetadata = append(allMetadata, metadataList...)
}
writeOutput(*outputFile, allMetadata)
}

4
tools/metadata/testdata/metadata_test.go vendored
View file

@ -10,7 +10,7 @@ import (
func TestMetadata(t *testing.T) {
cmd := exec.Command(
"metadata", "-inputFile", "./inputFiles.txt", "-outputFile",
"metadata", "-rule", "test_spec", "-inputFile", "./inputFiles.txt", "-outputFile",
"./generatedOutputFile.txt",
)
stderr, err := cmd.CombinedOutput()
@ -40,7 +40,7 @@ func TestMetadata(t *testing.T) {
func TestMetadataNegativeCase(t *testing.T) {
cmd := exec.Command(
"metadata", "-inputFile", "./inputFilesNegativeCase.txt", "-outputFile",
"metadata", "-rule", "test_spec", "-inputFile", "./inputFilesNegativeCase.txt", "-outputFile",
"./generatedOutputFileNegativeCase.txt",
)
stderr, err := cmd.CombinedOutput()