From 03d2aa4dd0adf85f240e98563ef399584baedb62 Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Thu, 14 Feb 2013 12:04:48 -0800 Subject: [PATCH] Remove more always-true ARCH_ARM_HAVE_ flags. All the remaining flags appear to be actually used. Change-Id: I0e3d84915487eda4f0e97809fc36624fef5f1848 --- core/combo/TARGET_linux-arm.mk | 17 +---------------- core/combo/arch/arm/armv5te.mk | 4 ---- core/combo/arch/arm/armv7-a-neon.mk | 5 ----- core/combo/arch/arm/armv7-a.mk | 5 ----- target/board/generic/BoardConfig.mk | 1 - 5 files changed, 1 insertion(+), 31 deletions(-) diff --git a/core/combo/TARGET_linux-arm.mk b/core/combo/TARGET_linux-arm.mk index bc781743fa..cb10542df2 100644 --- a/core/combo/TARGET_linux-arm.mk +++ b/core/combo/TARGET_linux-arm.mk @@ -77,18 +77,11 @@ TARGET_arm_CFLAGS := -O2 \ -fstrict-aliasing \ -funswitch-loops -# Modules can choose to compile some source as thumb. As -# non-thumb enabled targets are supported, this is treated -# as a 'hint'. If thumb is not enabled, these files are just -# compiled as ARM. -ifeq ($(ARCH_ARM_HAVE_THUMB_SUPPORT),true) +# Modules can choose to compile some source as thumb. TARGET_thumb_CFLAGS := -mthumb \ -Os \ -fomit-frame-pointer \ -fno-strict-aliasing -else -TARGET_thumb_CFLAGS := $(TARGET_arm_CFLAGS) -endif # Set FORCE_ARM_DEBUGGING to "true" in your buildspec.mk # or in your environment to force a full arm build, even for @@ -147,15 +140,7 @@ TARGET_GLOBAL_LDFLAGS += \ -Wl,--icf=safe \ $(arch_variant_ldflags) -# We only need thumb interworking in cases where thumb support -# is available in the architecture, and just to be sure, (and -# since sometimes thumb-interwork appears to be default), we -# specifically disable when thumb support is unavailable. -ifeq ($(ARCH_ARM_HAVE_THUMB_SUPPORT),true) TARGET_GLOBAL_CFLAGS += -mthumb-interwork -else -TARGET_GLOBAL_CFLAGS += -mno-thumb-interwork -endif TARGET_GLOBAL_CPPFLAGS += -fvisibility-inlines-hidden diff --git a/core/combo/arch/arm/armv5te.mk b/core/combo/arch/arm/armv5te.mk index 1c25e365eb..88e57b7264 100644 --- a/core/combo/arch/arm/armv5te.mk +++ b/core/combo/arch/arm/armv5te.mk @@ -1,10 +1,6 @@ # Configuration for Linux on ARM. # Generating binaries for the ARMv5TE architecture and higher # -ARCH_ARM_HAVE_THUMB_SUPPORT := true -ARCH_ARM_HAVE_FAST_INTERWORKING := true -ARCH_ARM_HAVE_64BIT_DATA := true -ARCH_ARM_HAVE_HALFWORD_MULTIPLY := true # Note: Hard coding the 'tune' value here is probably not ideal, # and a better solution should be found in the future. diff --git a/core/combo/arch/arm/armv7-a-neon.mk b/core/combo/arch/arm/armv7-a-neon.mk index d8ef49933f..78843661a4 100644 --- a/core/combo/arch/arm/armv7-a-neon.mk +++ b/core/combo/arch/arm/armv7-a-neon.mk @@ -1,12 +1,7 @@ # Configuration for Linux on ARM. # Generating binaries for the ARMv7-a architecture and higher with NEON # -ARCH_ARM_HAVE_THUMB_SUPPORT := true -ARCH_ARM_HAVE_FAST_INTERWORKING := true -ARCH_ARM_HAVE_64BIT_DATA := true -ARCH_ARM_HAVE_HALFWORD_MULTIPLY := true ARCH_ARM_HAVE_ARMV7A := true -ARCH_ARM_HAVE_TLS_REGISTER := true ARCH_ARM_HAVE_VFP := true ARCH_ARM_HAVE_VFP_D32 := true ARCH_ARM_HAVE_NEON := true diff --git a/core/combo/arch/arm/armv7-a.mk b/core/combo/arch/arm/armv7-a.mk index 7c33a5acca..4a519770f5 100644 --- a/core/combo/arch/arm/armv7-a.mk +++ b/core/combo/arch/arm/armv7-a.mk @@ -1,12 +1,7 @@ # Configuration for Linux on ARM. # Generating binaries for the ARMv7-a architecture and higher # -ARCH_ARM_HAVE_THUMB_SUPPORT := true -ARCH_ARM_HAVE_FAST_INTERWORKING := true -ARCH_ARM_HAVE_64BIT_DATA := true -ARCH_ARM_HAVE_HALFWORD_MULTIPLY := true ARCH_ARM_HAVE_ARMV7A := true -ARCH_ARM_HAVE_TLS_REGISTER := true ARCH_ARM_HAVE_VFP := true # Note: Hard coding the 'tune' value here is probably not ideal, diff --git a/target/board/generic/BoardConfig.mk b/target/board/generic/BoardConfig.mk index 7a25f30e04..3b032504f8 100644 --- a/target/board/generic/BoardConfig.mk +++ b/target/board/generic/BoardConfig.mk @@ -22,7 +22,6 @@ TARGET_ARCH := arm TARGET_ARCH_VARIANT := armv7-a TARGET_CPU_ABI := armeabi-v7a TARGET_CPU_ABI2 := armeabi -ARCH_ARM_HAVE_TLS_REGISTER := true HAVE_HTC_AUDIO_DRIVER := true BOARD_USES_GENERIC_AUDIO := true