tequilaOS/platform_build
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Buildifier fixes for release_config.bzl

Browse source 
Bug: None
Test: presubmit
Change-Id: I599c317d7a983d6e5d57b3c3153e4786a2ad9314
This commit is contained in:
LaMont Jones 2023-10-12 20:00:32 +00:00
parent c187d5052b
commit fff3ee0a24
1 changed files with 39 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

43
core/release_config.bzl
View file

@ -11,6 +11,9 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and # See the License for the specific language governing permissions and
# limitations under the License. # limitations under the License.
"""
Export build flags (with values) to make.
"""
load("//build/bazel/utils:schema_validation.bzl", "validate") load("//build/bazel/utils:schema_validation.bzl", "validate")
@ -73,7 +76,16 @@ _all_values_schema = {
} }
def flag(name, partitions, default): def flag(name, partitions, default):
"Declare a flag." """Declare a flag.
Args:
name: name of the flag
partitions: the partitions where this should be recorded.
default: the default value of the flag.
Returns:
A dictionary containing the flag declaration.
"""
if not partitions: if not partitions:
fail("At least 1 partition is required") fail("At least 1 partition is required")
if not name.startswith("RELEASE_"): if not name.startswith("RELEASE_"):
@ -96,14 +108,29 @@ def flag(name, partitions, default):
} }
def value(name, value): def value(name, value):
"Define the flag value for a particular configuration." """Define the flag value for a particular configuration.
Args:
name: The name of the flag.
value: The value for the flag.
Returns:
A dictionary containing the name and value to be used.
"""
return { return {
"name": name, "name": name,
"value": value, "value": value,
} }
def _format_value(val): def _format_value(val):
"Format the starlark type correctly for make" """Format the starlark type correctly for make.
Args:
val: The value to format
Returns:
The value, formatted correctly for make.
"""
if type(val) == "NoneType": if type(val) == "NoneType":
return "" return ""
elif type(val) == "bool": elif type(val) == "bool":
@ -112,7 +139,15 @@ def _format_value(val):
return val return val
def release_config(all_flags, all_values): def release_config(all_flags, all_values):
"Return the make variables that should be set for this release config." """Return the make variables that should be set for this release config.
Args:
all_flags: A list of flag objects (from flag() calls).
all_values: A list of value objects (from value() calls).
Returns:
A dictionary of {name: value} variables for make.
"""
validate(all_flags, _all_flags_schema) validate(all_flags, _all_flags_schema)
validate(all_values, _all_values_schema) validate(all_values, _all_values_schema)