Commit graph

60199 commits

Author SHA1 Message Date
Kousik Kumar
7de98747f4 Add RBE_CXX_COMPARE variable to locally disable compare mode for C++ am: 0118dd2f83
Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12599824

Change-Id: I88fc811658a05340c8c16f16bcb388f5f8aba9d5
2020-09-16 19:16:55 +00:00
Paul Scovanner
727715f100 Update Security String to 2020-11-01
Bug: 168709737
Change-Id: I96489891caa4f5248c90be2d8c16327e1991e3bb
2020-09-16 19:16:48 +00:00
Kousik Kumar
73bcc38ac8 Rename wlist to allowlist
The new release of re-client renames env_var_wlist to env_var_allowlist.
We need to make this change as part of the topic so that with the new
release we are able to deprecate this variable.

Bug: b/167677318
Change-Id: I988381f4f72061f7c6eb99d58593f92cfd618b1b
Merged-In: I988381f4f72061f7c6eb99d58593f92cfd618b1b
2020-09-16 18:20:29 +00:00
Kousik Kumar
94bf36bd92 Merge changes Ic8a8adb3,Ia972c74d into qt-dev
* changes:
  Remove double quotes in rbe.mk file
  Add RBE_CXX_COMPARE variable to locally disable compare mode for C++
2020-09-16 17:49:34 +00:00
Kousik Kumar
d4816407eb [automerger skipped] Merge "[DO NOT MERGE] Set RBE_DIR default value to point to prebuilts in tree." into qt-dev am: d9cf148ddb am: 4f66e75729 -s ours am: f473b50efa -s ours am: aab3292375 -s ours
am skip reason: Change-Id I3392a0f7ac6de818d0c5ba2e113fcb035c6fa0ae with SHA-1 8f8d1126aa is in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12593960

Change-Id: Ie248bf7fcbb03611c26ee079a3c3ba14328ff29d
2020-09-16 09:14:21 +00:00
Ramy Medhat
7755852722 [automerger skipped] [DO NOT MERGE] Set RBE_DIR default value to point to prebuilts in tree. am: 83c95dea63 am: 32b7584983 -s ours am: fb318d789b -s ours am: d82cd26b7f -s ours
am skip reason: Change-Id I3392a0f7ac6de818d0c5ba2e113fcb035c6fa0ae with SHA-1 8f8d1126aa is in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12593960

Change-Id: Ibd1e620de733c011f6a2734f3494555e83c709e3
2020-09-16 09:14:19 +00:00
Kousik Kumar
aab3292375 [automerger skipped] Merge "[DO NOT MERGE] Set RBE_DIR default value to point to prebuilts in tree." into qt-dev am: d9cf148ddb am: 4f66e75729 -s ours am: f473b50efa -s ours
am skip reason: Change-Id I3392a0f7ac6de818d0c5ba2e113fcb035c6fa0ae with SHA-1 8f8d1126aa is in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12593960

Change-Id: I97e848e0007b7694a2c48ea1b8e1c27286504d40
2020-09-16 08:25:30 +00:00
Ramy Medhat
d82cd26b7f [automerger skipped] [DO NOT MERGE] Set RBE_DIR default value to point to prebuilts in tree. am: 83c95dea63 am: 32b7584983 -s ours am: fb318d789b -s ours
am skip reason: Change-Id I3392a0f7ac6de818d0c5ba2e113fcb035c6fa0ae with SHA-1 8f8d1126aa is in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12593960

Change-Id: If2219849eb26c03fea6c4c86f875f008142bedf3
2020-09-16 08:25:28 +00:00
Kousik Kumar
f473b50efa [automerger skipped] Merge "[DO NOT MERGE] Set RBE_DIR default value to point to prebuilts in tree." into qt-dev am: d9cf148ddb am: 4f66e75729 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12593960

Change-Id: I75567bd0c2896aa053fd7982d3f278b2a0f9b9b9
2020-09-16 07:44:33 +00:00
Ramy Medhat
fb318d789b [automerger skipped] [DO NOT MERGE] Set RBE_DIR default value to point to prebuilts in tree. am: 83c95dea63 am: 32b7584983 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12593960

Change-Id: I3437bd861db3653bb24158bfcd3d0873f9278b99
2020-09-16 07:44:30 +00:00
Kousik Kumar
4f66e75729 Merge "[DO NOT MERGE] Set RBE_DIR default value to point to prebuilts in tree." into qt-dev am: d9cf148ddb
Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12593960

Change-Id: Ia6bdecaab27de877c36de507d524d236dda90473
2020-09-16 07:10:53 +00:00
Ramy Medhat
32b7584983 [DO NOT MERGE] Set RBE_DIR default value to point to prebuilts in tree. am: 83c95dea63
Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12593960

Change-Id: I3ea1bb99d0cd40b210f51665e48cf65d5eb7d315
2020-09-16 07:10:50 +00:00
Kousik Kumar
d9cf148ddb Merge "[DO NOT MERGE] Set RBE_DIR default value to point to prebuilts in tree." into qt-dev 2020-09-16 05:12:53 +00:00
TreeHugger Robot
8f477fafce Merge "Add function to export default values for RBE related variables" into rvc-dev am: 9bd7223ab7 am: c8111ccc63
Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12445425

Change-Id: Ifba75d30af8af6db2aa427d99eeea7e879d917e3
2020-09-16 03:12:40 +00:00
TreeHugger Robot
5142cae7ad Merge "Set RBE_DIR default value to point to prebuilts in tree." into rvc-dev am: 461c0d4620 am: 772906db16
Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12445424

Change-Id: I2c22ccc23ead183afb30372cf54688b29a44a6b7
2020-09-16 01:31:37 +00:00
TreeHugger Robot
c8111ccc63 Merge "Add function to export default values for RBE related variables" into rvc-dev am: 9bd7223ab7
Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12445425

Change-Id: I6427dcf3ac3c266a67699ca80912e2d954e5c981
2020-09-16 00:37:51 +00:00
TreeHugger Robot
772906db16 Merge "Set RBE_DIR default value to point to prebuilts in tree." into rvc-dev am: 461c0d4620
Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12445424

Change-Id: I94277b21d4d3d8663ddc6d5a6c2596886238d7f4
2020-09-16 00:37:28 +00:00
TreeHugger Robot
9bd7223ab7 Merge "Add function to export default values for RBE related variables" into rvc-dev 2020-09-15 23:30:27 +00:00
TreeHugger Robot
461c0d4620 Merge "Set RBE_DIR default value to point to prebuilts in tree." into rvc-dev 2020-09-15 23:30:18 +00:00
Kousik Kumar
581994cd24 [automerger skipped] [DO NOT MERGE] Add rbesetup.sh script to Q branch am: 45abdb21af am: c22ce3a211 -s ours am: d17cbf752a am: 089427434c
Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12583386

Change-Id: I153dfd34125e4464a57ce385c882269ff84c8915
2020-09-15 20:53:00 +00:00
Kousik Kumar
089427434c [automerger skipped] [DO NOT MERGE] Add rbesetup.sh script to Q branch am: 45abdb21af am: c22ce3a211 -s ours am: d17cbf752a
Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12583386

Change-Id: I21dc24a47380e62c8d611287d9950eb23924a31d
2020-09-15 20:11:19 +00:00
Kousik Kumar
d17cbf752a [automerger skipped] [DO NOT MERGE] Add rbesetup.sh script to Q branch am: 45abdb21af am: c22ce3a211 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12583386

Change-Id: I2e8f70d9c915bf37a201a64bbfbc6aaf5371dc8e
2020-09-15 19:42:00 +00:00
Kousik Kumar
c22ce3a211 [DO NOT MERGE] Add rbesetup.sh script to Q branch am: 45abdb21af
Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12583386

Change-Id: I58c96fc206a382c7887a8c29bb1e0e612b415204
2020-09-15 19:14:55 +00:00
Kousik Kumar
f037e1a969 Remove double quotes in rbe.mk file
These result in weird command line invocations when used with RBE.

Test: Ran an RBE build locally and made sure it still worked as expected
after the change.
Bug: b/163618332

Change-Id: Ic8a8adb3fffb357754384ddbf13684d944a9767e
Merged-In: Ic8a8adb3fffb357754384ddbf13684d944a9767e
2020-09-15 18:43:42 +00:00
Kousik Kumar
0118dd2f83 Add RBE_CXX_COMPARE variable to locally disable compare mode for C++
When we do 64-32 migration, we want compare mode to be present only for
non-c++ actions as it would impact performance on 32-core machines
otherwise.

Bug: b/157414300
Test: Ran a build with "RBE_CXX_LINKS="true" RBE_CXX_LINKS_EXEC_STRATEGY="remote" RBE_CXX_COMPARE="false" RBE_compare="true" use_rbe mmma bionic"
and observed that local-executions happened only for link actions and
not for C++ actions.

Change-Id: Ia972c74d804085196a7b6ec755af63042c6b3909
Merged-In: Ia972c74d804085196a7b6ec755af63042c6b3909
2020-09-15 18:35:32 +00:00
Ramy Medhat
83c95dea63 [DO NOT MERGE] Set RBE_DIR default value to point to prebuilts in tree.
The new default points to prebuilts/remoteexecution-client/live.

Also sets the default exec strategy of Javac/R8/D8 to remote local
fallback.

Bug: b/166182389
Test: simple one action build
Change-Id: I3392a0f7ac6de818d0c5ba2e113fcb035c6fa0ae
Merged-In: I3392a0f7ac6de818d0c5ba2e113fcb035c6fa0ae
2020-09-15 18:32:57 +00:00
Kousik Kumar
2cfdeb283f Merge "Add RBE_CXX_COMPARE variable to locally disable compare mode for C++" into rvc-dev am: f65ffea114 am: de90e23895
Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/11637205

Change-Id: I2f7eb551b842d43f0b51979dfd90bdc9a869768b
2020-09-14 15:09:20 +00:00
Kousik Kumar
de90e23895 Merge "Add RBE_CXX_COMPARE variable to locally disable compare mode for C++" into rvc-dev am: f65ffea114
Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/11637205

Change-Id: I456ebb5cfad7cd65da2ca5853b44e083de464e4e
2020-09-14 14:40:37 +00:00
Kousik Kumar
f65ffea114 Merge "Add RBE_CXX_COMPARE variable to locally disable compare mode for C++" into rvc-dev 2020-09-14 14:25:29 +00:00
Kousik Kumar
45abdb21af [DO NOT MERGE] Add rbesetup.sh script to Q branch
Bug: b/166182389
Merged-In: I2413a3648e9b2ff680cab6fededc07bbdd43378f
Change-Id: I2413a3648e9b2ff680cab6fededc07bbdd43378f
2020-09-14 07:18:34 +00:00
Kousik Kumar
e81130bd5c [automerger skipped] [DO NOT MERGE] Update configuration for RemoteExecution actions am: 136274bfaa am: 97a8b0429a -s ours am: d0737f00ee -s ours am: 2e3f6ef93f -s ours
am skip reason: Change-Id I0231a96f6e4e094e98d0f89728f6ac3e34f78118 with SHA-1 28e7f8cfbc is in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12468477

Change-Id: Id6c0ea67e44f68acff467d9aaec1ca426f2f8250
2020-09-02 13:06:41 +00:00
Kousik Kumar
2e3f6ef93f [automerger skipped] [DO NOT MERGE] Update configuration for RemoteExecution actions am: 136274bfaa am: 97a8b0429a -s ours am: d0737f00ee -s ours
am skip reason: Change-Id I0231a96f6e4e094e98d0f89728f6ac3e34f78118 with SHA-1 28e7f8cfbc is in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12468477

Change-Id: I487c69c9e517ed435ac9c6b259ecf716eca1d3bc
2020-09-02 12:36:08 +00:00
Ramy Medhat
f8cc4dc388 [automerger skipped] [DO NOT MERGE] Modify D8 template to not have inputs under the output directory. am: 0ba998c376 am: a3933f760e -s ours am: a5adf6ac81 -s ours am: 9ef038a190 -s ours
am skip reason: Change-Id I800664acdeffa04ce83a8446bece411f018af2e2 with SHA-1 c3427499ca is in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12468476

Change-Id: I20b73dcb855362e2dda962b9feb7c7b7d8a3e7da
2020-09-02 12:20:43 +00:00
Kousik Kumar
c09e7918b3 [automerger skipped] [DO NOT MERGE] Add exec_strategy as CLI flags to all rewrapper commands am: 8b3850d8e5 am: fc82cb6c31 -s ours am: 79b71cbd76 -s ours am: 90b03f4062 -s ours
am skip reason: Change-Id I745ed4a91c2b070048c0b1fd0881e5f4f28d0148 with SHA-1 d463007dfc is in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12468475

Change-Id: I565b660cce3af9d3ce5e90aeba988422f846ac3f
2020-09-02 12:20:28 +00:00
Ramy Medhat
68c727f79a [automerger skipped] [DO NOT MERGE] Add RBE support for Javac, R8, and D8 if respective env vars are set. am: c9a030aa4d am: 5507116c4a -s ours am: 33466e3836 -s ours am: 5af3f2f587 -s ours
am skip reason: Change-Id I252ff5dd8e372edf8c86e25348c8a2bfab41d70d with SHA-1 a9cc25d785 is in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12468474

Change-Id: Ib298ba798bc96f80de85ce431a38808f29c33e21
2020-09-02 12:20:15 +00:00
Ramy Medhat
ef27a73a95 [automerger skipped] [DO NOT MERGE] Add PWD to environment variable whitelist for RBE builds. am: 77a4879e8c am: 1700189171 -s ours am: 532652723e -s ours am: 77b2bf3b47 -s ours
am skip reason: Change-Id I4b51fbde330c6129654aa74f8a58dccf62cfa11d with SHA-1 e8de0931a1 is in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12468473

Change-Id: I68f95b09e20b57f1b74be3669a25b561a22b2c05
2020-09-02 12:20:00 +00:00
Ramy Medhat
e78fb13adb [automerger skipped] [DO NOT MERGE] Add labels to rewrapper cc compile action. Prevent ccwrapper from being used in links. am: f965526697 am: d0c6aa3e33 -s ours am: 1b09868d21 -s ours am: edf1fbe020 -s ours
am skip reason: Change-Id I8d04069219a9467c3de9a028eb68e3115173f1e2 with SHA-1 e5839f912b is in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12468472

Change-Id: I64ada472e8363103c1015a745ae9a58218150684
2020-09-02 12:19:44 +00:00
Kousik Kumar
d0737f00ee [automerger skipped] [DO NOT MERGE] Update configuration for RemoteExecution actions am: 136274bfaa am: 97a8b0429a -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12468477

Change-Id: I5dfdc502d3c03baf14354d7b23b5ff13f6f9cc86
2020-09-02 12:18:51 +00:00
Ramy Medhat
9ef038a190 [automerger skipped] [DO NOT MERGE] Modify D8 template to not have inputs under the output directory. am: 0ba998c376 am: a3933f760e -s ours am: a5adf6ac81 -s ours
am skip reason: Change-Id I800664acdeffa04ce83a8446bece411f018af2e2 with SHA-1 c3427499ca is in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12468476

Change-Id: I4a28f490d50f85cb91984b18f835cedf1e9d2a2b
2020-09-02 11:54:13 +00:00
Kousik Kumar
90b03f4062 [automerger skipped] [DO NOT MERGE] Add exec_strategy as CLI flags to all rewrapper commands am: 8b3850d8e5 am: fc82cb6c31 -s ours am: 79b71cbd76 -s ours
am skip reason: Change-Id I745ed4a91c2b070048c0b1fd0881e5f4f28d0148 with SHA-1 d463007dfc is in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12468475

Change-Id: If79c32a4f26d2968c9e99bb8c98d2760dc0de3d9
2020-09-02 11:54:05 +00:00
Ramy Medhat
5af3f2f587 [automerger skipped] [DO NOT MERGE] Add RBE support for Javac, R8, and D8 if respective env vars are set. am: c9a030aa4d am: 5507116c4a -s ours am: 33466e3836 -s ours
am skip reason: Change-Id I252ff5dd8e372edf8c86e25348c8a2bfab41d70d with SHA-1 a9cc25d785 is in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12468474

Change-Id: Iee861af7dd869ad430b8a1dcb23023edaa03bb15
2020-09-02 11:53:58 +00:00
Ramy Medhat
77b2bf3b47 [automerger skipped] [DO NOT MERGE] Add PWD to environment variable whitelist for RBE builds. am: 77a4879e8c am: 1700189171 -s ours am: 532652723e -s ours
am skip reason: Change-Id I4b51fbde330c6129654aa74f8a58dccf62cfa11d with SHA-1 e8de0931a1 is in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12468473

Change-Id: I96a3cab81f293649ac23be346f5ff6a0fb8eafcb
2020-09-02 11:53:50 +00:00
Ramy Medhat
edf1fbe020 [automerger skipped] [DO NOT MERGE] Add labels to rewrapper cc compile action. Prevent ccwrapper from being used in links. am: f965526697 am: d0c6aa3e33 -s ours am: 1b09868d21 -s ours
am skip reason: Change-Id I8d04069219a9467c3de9a028eb68e3115173f1e2 with SHA-1 e5839f912b is in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12468472

Change-Id: I54b110bebbc2f31f1ca7bc0be66d2623524ff5d6
2020-09-02 11:53:36 +00:00
Kousik Kumar
97a8b0429a [DO NOT MERGE] Update configuration for RemoteExecution actions am: 136274bfaa
Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12468477

Change-Id: I3433f0d3e24302f14c5fe317b3e49a6497572807
2020-09-02 11:39:39 +00:00
Ramy Medhat
a5adf6ac81 [automerger skipped] [DO NOT MERGE] Modify D8 template to not have inputs under the output directory. am: 0ba998c376 am: a3933f760e -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12468476

Change-Id: I2cd992ff4acdd27e538972308bc7f8a8cab5ee3f
2020-09-02 11:16:22 +00:00
Kousik Kumar
79b71cbd76 [automerger skipped] [DO NOT MERGE] Add exec_strategy as CLI flags to all rewrapper commands am: 8b3850d8e5 am: fc82cb6c31 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12468475

Change-Id: Iad13ef81cf995ac06e85df575b7ab86928997420
2020-09-02 11:16:17 +00:00
Ramy Medhat
33466e3836 [automerger skipped] [DO NOT MERGE] Add RBE support for Javac, R8, and D8 if respective env vars are set. am: c9a030aa4d am: 5507116c4a -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12468474

Change-Id: Ib410589e42eba5eb0cee6e61a52cf8ea30fb771a
2020-09-02 11:16:12 +00:00
Ramy Medhat
532652723e [automerger skipped] [DO NOT MERGE] Add PWD to environment variable whitelist for RBE builds. am: 77a4879e8c am: 1700189171 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12468473

Change-Id: I7e074a1ea0dbede530d5cdd779b23c2a28e80a66
2020-09-02 11:16:07 +00:00
Ramy Medhat
1b09868d21 [automerger skipped] [DO NOT MERGE] Add labels to rewrapper cc compile action. Prevent ccwrapper from being used in links. am: f965526697 am: d0c6aa3e33 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12468472

Change-Id: I4ebd163de5cb15131471359eedfa11714ff0a724
2020-09-02 11:16:02 +00:00
Ramy Medhat
a3933f760e [DO NOT MERGE] Modify D8 template to not have inputs under the output directory. am: 0ba998c376
Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/12468476

Change-Id: I7f218170ca51b9d7e40394cb5a91e31ea0ab26d9
2020-09-02 10:56:06 +00:00