Commit graph

96603 commits

Author SHA1 Message Date
Dennis Shen
b18227e8d8 aconfig: update storage read api
With the update to store flag index instead of flag byte offset in
storage file. We need to update flag read api accordingly.

Bug: b/321077378
Test: atest -c
Change-Id: Iccbf939fc5b7fe0ce0f2c33f7e3aa403c268120a
2024-04-10 16:39:21 +00:00
Dennis Shen
a8ba164422 aconfig: update storage file creation to allow storage files to store
flag index instead of byte offset

Bug: b/321077378
Test: atest -c
Change-Id: I2fbfa09ac880c172fd8e47866d9ec1449718e0b6
2024-04-10 16:37:23 +00:00
Dennis Shen
702408ecbb aconfig: update storage file to store flag index instead of file byte offset
Previously, in package.map, we store the byte offset of the first flag
in a flag package in a flag value file. In flag.map, we store the within
package flag byte offset. Once we know the total offset, we can locate
the flag in the flag value file. However, this offset may not work for
flag info file. Currently we only have boolean flags. Each boolean flag
value and info takes up 1 byte in flag value and flag info file. So the
byte offsets are the same. But in the future, when we add a new flag
value type, or add more contents to flag info file. Then the byte offset
for flag value file and flag info file may not be same.

Instead, we should store index rather than offset. The package map
should store the index of the first flag in this package. The flag map
stores the within package index. Then flag value read api and flag info
read api can then infer the byte offset independently.

Bug: b/321077378
Test: atest -c
Change-Id: Iad89776d5369715ba2d8faaea18261ac3271f13b
2024-04-10 16:36:46 +00:00
Dennis Shen
ba67028405 Merge "aconfig: return stored flag type enum as a part of flag offset info" into main 2024-04-10 15:14:43 +00:00
Dennis Shen
9fa78d373c aconfig: return stored flag type enum as a part of flag offset info
Bug: b/321077378
Test: atest -c
Change-Id: I25bad6b226de570eedfef4b450e09be2ac75c5eb
2024-04-10 15:14:14 +00:00
Dennis Shen
ccfb4c284f Merge changes from topic "flag_info_read_api" into main
* changes:
  aconfig: add flag info read c api
  aconfig: add flag info read rust api
2024-04-10 14:33:36 +00:00
Treehugger Robot
f45c19001f Merge "Drop HOST_CROSS_ARCH special-case in source vs prebuilt mainline selection" into main 2024-04-09 23:37:28 +00:00
Treehugger Robot
85c79a3a3a Merge "Add an option to move 16K ota to vendor partition" into main 2024-04-09 19:26:19 +00:00
Spandan Das
a43378be19 Drop HOST_CROSS_ARCH special-case in source vs prebuilt mainline selection
`PRODUCT_MODULE_BUILD_FROM_SOURCE` has been added explicitly to the
products that have `HOST_CROSS_ARCH=arm64`, so we do not need this
special case here anymore.

Bug: 308188056
Test: presubmits
Change-Id: Ide3dbf9c3674683f2e0546403622cf6b8fe78739
2024-04-09 18:27:11 +00:00
Kelvin Zhang
19805cb372 Add an option to move 16K ota to vendor partition
For GRF devices, the system partition might be shared between different
products using different kernels. Hence putting the 16K boot option OTA
on system partition would not work for such project.

Test: th
Bug: 293313353
Bug: 328166454
Bug: 329808458

Change-Id: I2ba3ad4f28f3569c6b8e275849988328f9d73552
2024-04-09 09:52:04 -07:00
Spandan Das
f52543b2e1 Merge "Drop HOST_CROSS_OS special-case in source vs prebuilt mainline selection" into main 2024-04-09 16:47:33 +00:00
Dennis Shen
cf7f5375be Merge "aconfig: add flag info field to proto" into main 2024-04-09 13:26:57 +00:00
Kiyoung Kim
665827ea7b Merge "Remove BOARD_VNDK_VERSION usage from Kati" into main 2024-04-09 07:31:00 +00:00
Kiyoung Kim
66481ae8e1 Remove BOARD_VNDK_VERSION usage from Kati
As of VNDK deprecation, BOARD_VNDK_VERSION should not be referenced
anymore. This change removes BOARD_VNDK_VERSION references and related
logics from Kati, so VNDK deprecation can be fully set without flag.

Bug: 330100430
Test: AOSP CF build succeeded
Change-Id: I9ea5f1236268b99eb731ebf48afd9e595d06ab1a
2024-04-09 14:47:29 +09:00
Spandan Das
1b58833906 Drop HOST_CROSS_OS special-case in source vs prebuilt mainline selection
We currently do not have many products that cross compile to
linux_bionic, and none of them use google apexes.

One exception is `mainline_sdk` product, but this product exclusively
builds using the `mainline` release config. This release config contains
the necessary RELEASE_APEX_CONTRIBUTIONS_* to provide sources during the
build, so we do not need this additional special-case here

Bug: 308188056
Test: lunch trout_arm64-next-userdebug && get_build_var
PRODUCT_PACKAGES; verified that google apexes do not appear there before
this CL, effectively making this CL a no-op for that product

Change-Id: Ibfdc742b6ae01242be22a3d3f6bb3c0cf551705f
2024-04-09 00:20:22 +00:00
Devin Moore
8f608682e4 Merge "Define PRODUCT_HIDL_ENABLED" into main 2024-04-08 20:08:16 +00:00
Treehugger Robot
cfec7d0f7b Merge changes I1a5615e9,I01a673e7 into main
* changes:
  Remove dependency on non-AB modules
  Make build_image output consistent for partitions w/o build.prop
2024-04-08 19:57:56 +00:00
Daniel Zheng
5f4028b318 Merge "Revert^2 "Turn on V3 cow"" into main 2024-04-08 19:42:29 +00:00
Treehugger Robot
bd7435ad88 Merge "Drop some special casing of source vs prebuilt mainline selection" into main 2024-04-08 19:39:55 +00:00
Treehugger Robot
5f0b1daebf Merge "Remove extra owners from the core build system" into main 2024-04-08 19:23:13 +00:00
Joe Onorato
5be7d6abaf Remove extra owners from the core build system
Change-Id: I8c06889c793a0db3e8359d0b33e735404d55ae4e
2024-04-08 11:59:05 -07:00
Hugo Drumond Jacob
a5a59126c8 Merge "Added automotive-sdv-tests" into main 2024-04-08 18:21:43 +00:00
Kelvin Zhang
7a17cfd81a Remove dependency on non-AB modules
imgdiff is scheduled for removal.

Test: th
Bug: 324360816
Change-Id: I1a5615e9f5f776c16269ac8780187f97edba16f2
2024-04-08 11:08:14 -07:00
Spandan Das
307224c7d4 Drop some special casing of source vs prebuilt mainline selection
soong config vars are no longer needed to support the following two
special cases
1. Santized builds. google hwasan products have been updated to explicitly list
   PRODUCT_MODULE_BUILD_FROM_SOURCE ag/26576335
2. Coverage builds. product specific overrides of build flags are not
   possible, so apex_contributions.go has been special cased to ignore
   prebuilts. Since RELEASE_APEX_CONTRIBUTIONS_* are now used to select
   prebuilts of mainline modules, we can drop the special-case of
   coverage builds in this .mk file

Bug: 308188056
Bug: 325666427
Test: lunch cf_x86_64_phone-next-userdebug && EMMA_INSTRUMENT=true m
nothing; # verified that no path exists between droid and the prebuilt
bt apex

Change-Id: Ide50e4463615fef5f540130f6a6bce50c00eddb8
2024-04-08 18:02:01 +00:00
Daniel Zheng
a69a26c5b3 Revert^2 "Turn on V3 cow"
e59e31cb9d

Change-Id: Ia31a34856c89348c5efb7f9ff5498e1b0ff45134
2024-04-08 17:39:50 +00:00
Thiago Amanajás
fdf6d4a744 Merge "Added SDV OWNERS" into main 2024-04-08 10:11:18 +00:00
Thiago Amanajas
1fc56abf5e Added SDV OWNERS
BUG: 333039457

Test: Locally
Change-Id: I6c183fb9b77c47ea45351fc286c58fdd661826e5
2024-04-08 09:37:27 +00:00
Thiago Amanajas
7e8a80d857 Added automotive-sdv-tests
BUG: 333039457

Test: Locally
Change-Id: I9e80d2336c54130509730fd388d0bccce8cf22ef
2024-04-08 11:16:46 +02:00
Cliff Wang
3feb0dc532 Merge "" into main 2024-04-08 05:27:03 +00:00
Amir Voskoboynik
0930977b55 Revert "libmdnssd is only used by adbd."
This reverts commit 1ecbeae2dd.

Reason for revert: Prime candidate as culprit for build breakage
build_id/11678886
 
Bug: 333111739

Change-Id: I24ee63b7cfe738e505e691b2d111c4a816513657
2024-04-08 05:19:04 +00:00
Stephen Ho
6cc2ee7a6d Merge "Revert "16k: core: Enable TARGET_NO_BIONIC_PAGE_SIZE_MACRO by default on Android V targets"" into main 2024-04-08 04:06:44 +00:00
Dennis Shen
58ada6f972 aconfig: add flag info read c api
Bug: b/321077378
Test: atest aconfig_storage_read_api.test.cpp
Change-Id: If6c258429b8d8ccc872cac9f72cb533cf454ecbd
2024-04-07 20:36:25 +00:00
Dennis Shen
2ac7a4c2bd aconfig: add flag info read rust api
Bug: b/321077378
Test: atest aconfig_storage_read_api.test; atest
aconfig_storage_read_api.test.rust

Change-Id: I382ac0145c5d91827952b3ddb01cabefd1539854
2024-04-07 20:34:28 +00:00
Kennet Belenky
31971fb99e Revert "16k: core: Enable TARGET_NO_BIONIC_PAGE_SIZE_MACRO by default on Android V targets"
This reverts commit 21a09420c7.

Reason for revert: Identified as a culprit in a test break. https://buganizer.corp.google.com/issues/333124272

Change-Id: Ia5f906077ce40a0dffe09619a89ab2e2fdeb7e69
2024-04-05 23:09:08 +00:00
Devin Moore
6c5aedfbef Define PRODUCT_HIDL_ENABLED
This is used to force HIDL to be enabled for device bring-up when
partners have converted all of their AOSP HAL implementations to AIDL,
but still have some partner-owned interfaces that they are working on
converting from HIDL TO AIDL.

Test: PRODUCT_HIDL_ENABLED = true && adb shell lshal
Test: PRODUCT_HIDL_ENABLED = false && adb shell lshal
Bug: 332548148

Change-Id: I6e6dc6c9e22d31c270e3c3520fc074bbeb349808
2024-04-05 23:06:37 +00:00
Vilas Bhat
667f4ac528 Merge "16k: core: Enable TARGET_NO_BIONIC_PAGE_SIZE_MACRO by default on Android V targets" into main 2024-04-05 20:07:45 +00:00
Treehugger Robot
52e47884f9 Merge "libmdnssd is only used by adbd." into main 2024-04-05 19:41:34 +00:00
Spandan Das
06c6eb7919 Merge "Drop special-casing of tv in source/prebuilt selection" into main 2024-04-05 19:41:29 +00:00
Spandan Das
9448b6fb73 Drop special-casing of tv in source/prebuilt selection
Removal of this additional special-casing was missed in aosp/3028110

Test: presbumits
Test: used go/abtd to test a handful of targets in tv's release branch
Bug: 308188056
Change-Id: I6af3821f53e0ceeb0c48c921a0c851b9e6d2d5b6
2024-04-05 17:04:35 +00:00
Dennis Shen
eff5363e2d aconfig: add flag info field to proto
Bug: b/321077378
Test: m
Change-Id: I1b974f83ea49e8d4b19b3392cb7feab3d4b3fcdc
2024-04-05 16:40:43 +00:00
Elliott Hughes
1ecbeae2dd libmdnssd is only used by adbd.
Change-Id: I2deaecd02578cc17adf598d095b0e0d246c4d728
2024-04-05 16:32:25 +00:00
Dennis Shen
acfb82cf73 Merge "aconfig: move create flag info file api to aconfig_storage_write_api" into main 2024-04-05 13:59:45 +00:00
yike
9ec7a00364 Fix is_unit_test in module-info
`is_unit_test` is removed from module-info.json by mistake.

Bug: 309006256
Test: m out/target/product/vsoc_x86_64/module-info.json
Change-Id: I03ccc0efec83fbf5a0c6e548941bba6467ce8cd1
2024-04-05 04:40:57 +00:00
Treehugger Robot
542c741208 Merge "Drop special-casing of atv in source/prebuilt selection" into main 2024-04-05 04:08:14 +00:00
Zhi Dou
e78d4ed255 Merge "aconfig: remove @com.android.aconfig.annotations.AconfigFlagAccessor from the exported mode" into main 2024-04-05 02:23:17 +00:00
Spandan Das
f01a7d82ee Drop special-casing of atv in source/prebuilt selection
All tv devices on internal CI branches currently build in trunk_staging
config. Since trunk_staging provides sources of mainline modules via
RELEASE_APEX_CONTRIBUTIONS_*, we do not need this special-casing
anymore.

(cs query
https://source.corp.google.com/search?q=ATV.*TARGET_RELEASE.*next%20f:%5C.gcl&sq=)

Test: presbumits
Test: used go/abtd to test a handful of targets in tv's release branch
Bug: 308188056
Change-Id: Iaadd5b9151c8cce3fe0a193f2e5c37d63e6095d4
2024-04-04 23:44:38 +00:00
Dennis Shen
455dc608f3 aconfig: move create flag info file api to aconfig_storage_write_api
rust_ffi_static right now will export excessive symbols, this lead to a
duplication of symbols when aconfig links against both
libaconfig_storage_file_cc and libaconfig_storage_read_api_cc. This is
because aconfig_storage_read_api crate depends on aconfig_storage_file
crate. To solve this problem, move create flag info file api to
aconfig_storage_write_api crate which is parallel to
aconfig_storage_read_api crate.

Bug: b/321077378
Test: atest aconfig_storage_file.test; atest
aconfig_storage_read_api.test; atest aconfig_storage_write_api.test

Change-Id: Ibbb50193a2da82d52ccbb4087c8e3fb9f320805f
2024-04-04 21:39:04 +00:00
Zhi Dou
bc71cd03b9 aconfig: remove @com.android.aconfig.annotations.AconfigFlagAccessor from the
exported mode

The exported mode library will be dropped into google3, and there isn't
the library for this annotation.

Test: atest aconfig.test
Bug: n/a
Change-Id: I318d1c0faf232b22f42587b8ea2f976173c8554a
2024-04-04 20:21:50 +00:00
Dennis Shen
83066f6dc0 Merge "aconfig: add create_flag_info cc api" into main 2024-04-04 18:26:12 +00:00
Spandan Das
8d8f816a0f Merge "Convert BuildIgnoreApexContritbutions variable to a boolean" into main 2024-04-04 17:50:48 +00:00