e9af70ad68
Uses apex_utils.GetApexInfoFromTargetFiles to find and parse APEX files
in the target files partition dirs. Raises an error on failure to parse
or duplicate package names.
Bug: 177225446
Test: releasetools_test
Test: Create a merged build that provides the VNDK APEX on both vendor
and system. Observe failure.
Change-Id: I1356e263b7b32d6063129e079f3ba7ab4ff132a7
310 lines
12 KiB
Python
310 lines
12 KiB
Python
#
|
|
# Copyright (C) 2017 The Android Open Source Project
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
#
|
|
|
|
import os.path
|
|
import shutil
|
|
|
|
import common
|
|
import test_utils
|
|
from merge_target_files import (
|
|
validate_config_lists, DEFAULT_FRAMEWORK_ITEM_LIST,
|
|
DEFAULT_VENDOR_ITEM_LIST, DEFAULT_FRAMEWORK_MISC_INFO_KEYS, copy_items,
|
|
item_list_to_partition_set, process_apex_keys_apk_certs_common,
|
|
compile_split_sepolicy, validate_merged_apex_info)
|
|
|
|
|
|
class MergeTargetFilesTest(test_utils.ReleaseToolsTestCase):
|
|
|
|
def setUp(self):
|
|
self.testdata_dir = test_utils.get_testdata_dir()
|
|
|
|
def test_copy_items_CopiesItemsMatchingPatterns(self):
|
|
|
|
def createEmptyFile(path):
|
|
if not os.path.exists(os.path.dirname(path)):
|
|
os.makedirs(os.path.dirname(path))
|
|
open(path, 'a').close()
|
|
return path
|
|
|
|
def createSymLink(source, dest):
|
|
os.symlink(source, dest)
|
|
return dest
|
|
|
|
def getRelPaths(start, filepaths):
|
|
return set(
|
|
os.path.relpath(path=filepath, start=start) for filepath in filepaths)
|
|
|
|
input_dir = common.MakeTempDir()
|
|
output_dir = common.MakeTempDir()
|
|
expected_copied_items = []
|
|
actual_copied_items = []
|
|
patterns = ['*.cpp', 'subdir/*.txt']
|
|
|
|
# Create various files that we expect to get copied because they
|
|
# match one of the patterns.
|
|
expected_copied_items.extend([
|
|
createEmptyFile(os.path.join(input_dir, 'a.cpp')),
|
|
createEmptyFile(os.path.join(input_dir, 'b.cpp')),
|
|
createEmptyFile(os.path.join(input_dir, 'subdir', 'c.txt')),
|
|
createEmptyFile(os.path.join(input_dir, 'subdir', 'd.txt')),
|
|
createEmptyFile(
|
|
os.path.join(input_dir, 'subdir', 'subsubdir', 'e.txt')),
|
|
createSymLink('a.cpp', os.path.join(input_dir, 'a_link.cpp')),
|
|
])
|
|
# Create some more files that we expect to not get copied.
|
|
createEmptyFile(os.path.join(input_dir, 'a.h'))
|
|
createEmptyFile(os.path.join(input_dir, 'b.h'))
|
|
createEmptyFile(os.path.join(input_dir, 'subdir', 'subsubdir', 'f.gif'))
|
|
createSymLink('a.h', os.path.join(input_dir, 'a_link.h'))
|
|
|
|
# Copy items.
|
|
copy_items(input_dir, output_dir, patterns)
|
|
|
|
# Assert the actual copied items match the ones we expected.
|
|
for dirpath, _, filenames in os.walk(output_dir):
|
|
actual_copied_items.extend(
|
|
os.path.join(dirpath, filename) for filename in filenames)
|
|
self.assertEqual(
|
|
getRelPaths(output_dir, actual_copied_items),
|
|
getRelPaths(input_dir, expected_copied_items))
|
|
self.assertEqual(
|
|
os.readlink(os.path.join(output_dir, 'a_link.cpp')), 'a.cpp')
|
|
|
|
def test_validate_config_lists_ReturnsFalseIfMissingDefaultItem(self):
|
|
framework_item_list = list(DEFAULT_FRAMEWORK_ITEM_LIST)
|
|
framework_item_list.remove('SYSTEM/*')
|
|
self.assertFalse(
|
|
validate_config_lists(framework_item_list,
|
|
DEFAULT_FRAMEWORK_MISC_INFO_KEYS,
|
|
DEFAULT_VENDOR_ITEM_LIST))
|
|
|
|
def test_validate_config_lists_ReturnsTrueIfDefaultItemInDifferentList(self):
|
|
framework_item_list = list(DEFAULT_FRAMEWORK_ITEM_LIST)
|
|
framework_item_list.remove('ROOT/*')
|
|
vendor_item_list = list(DEFAULT_VENDOR_ITEM_LIST)
|
|
vendor_item_list.append('ROOT/*')
|
|
self.assertTrue(
|
|
validate_config_lists(framework_item_list,
|
|
DEFAULT_FRAMEWORK_MISC_INFO_KEYS,
|
|
vendor_item_list))
|
|
|
|
def test_validate_config_lists_ReturnsTrueIfExtraItem(self):
|
|
framework_item_list = list(DEFAULT_FRAMEWORK_ITEM_LIST)
|
|
framework_item_list.append('MY_NEW_PARTITION/*')
|
|
self.assertTrue(
|
|
validate_config_lists(framework_item_list,
|
|
DEFAULT_FRAMEWORK_MISC_INFO_KEYS,
|
|
DEFAULT_VENDOR_ITEM_LIST))
|
|
|
|
def test_validate_config_lists_ReturnsFalseIfSharedExtractedPartition(self):
|
|
vendor_item_list = list(DEFAULT_VENDOR_ITEM_LIST)
|
|
vendor_item_list.append('SYSTEM/my_system_file')
|
|
self.assertFalse(
|
|
validate_config_lists(DEFAULT_FRAMEWORK_ITEM_LIST,
|
|
DEFAULT_FRAMEWORK_MISC_INFO_KEYS,
|
|
vendor_item_list))
|
|
|
|
def test_validate_config_lists_ReturnsFalseIfSharedExtractedPartitionImage(
|
|
self):
|
|
vendor_item_list = list(DEFAULT_VENDOR_ITEM_LIST)
|
|
vendor_item_list.append('IMAGES/system.img')
|
|
self.assertFalse(
|
|
validate_config_lists(DEFAULT_FRAMEWORK_ITEM_LIST,
|
|
DEFAULT_FRAMEWORK_MISC_INFO_KEYS,
|
|
vendor_item_list))
|
|
|
|
def test_validate_config_lists_ReturnsFalseIfBadSystemMiscInfoKeys(self):
|
|
for bad_key in ['dynamic_partition_list', 'super_partition_groups']:
|
|
framework_misc_info_keys = list(DEFAULT_FRAMEWORK_MISC_INFO_KEYS)
|
|
framework_misc_info_keys.append(bad_key)
|
|
self.assertFalse(
|
|
validate_config_lists(DEFAULT_FRAMEWORK_ITEM_LIST,
|
|
framework_misc_info_keys,
|
|
DEFAULT_VENDOR_ITEM_LIST))
|
|
|
|
def test_process_apex_keys_apk_certs_ReturnsTrueIfNoConflicts(self):
|
|
output_dir = common.MakeTempDir()
|
|
os.makedirs(os.path.join(output_dir, 'META'))
|
|
|
|
framework_dir = common.MakeTempDir()
|
|
os.makedirs(os.path.join(framework_dir, 'META'))
|
|
os.symlink(
|
|
os.path.join(self.testdata_dir, 'apexkeys_framework.txt'),
|
|
os.path.join(framework_dir, 'META', 'apexkeys.txt'))
|
|
|
|
vendor_dir = common.MakeTempDir()
|
|
os.makedirs(os.path.join(vendor_dir, 'META'))
|
|
os.symlink(
|
|
os.path.join(self.testdata_dir, 'apexkeys_vendor.txt'),
|
|
os.path.join(vendor_dir, 'META', 'apexkeys.txt'))
|
|
|
|
process_apex_keys_apk_certs_common(framework_dir, vendor_dir, output_dir,
|
|
set(['product', 'system', 'system_ext']),
|
|
set(['odm', 'vendor']), 'apexkeys.txt')
|
|
|
|
merged_entries = []
|
|
merged_path = os.path.join(self.testdata_dir, 'apexkeys_merge.txt')
|
|
|
|
with open(merged_path) as f:
|
|
merged_entries = f.read().split('\n')
|
|
|
|
output_entries = []
|
|
output_path = os.path.join(output_dir, 'META', 'apexkeys.txt')
|
|
|
|
with open(output_path) as f:
|
|
output_entries = f.read().split('\n')
|
|
|
|
return self.assertEqual(merged_entries, output_entries)
|
|
|
|
def test_process_apex_keys_apk_certs_ReturnsFalseIfConflictsPresent(self):
|
|
output_dir = common.MakeTempDir()
|
|
os.makedirs(os.path.join(output_dir, 'META'))
|
|
|
|
framework_dir = common.MakeTempDir()
|
|
os.makedirs(os.path.join(framework_dir, 'META'))
|
|
os.symlink(
|
|
os.path.join(self.testdata_dir, 'apexkeys_framework.txt'),
|
|
os.path.join(framework_dir, 'META', 'apexkeys.txt'))
|
|
|
|
conflict_dir = common.MakeTempDir()
|
|
os.makedirs(os.path.join(conflict_dir, 'META'))
|
|
os.symlink(
|
|
os.path.join(self.testdata_dir, 'apexkeys_framework_conflict.txt'),
|
|
os.path.join(conflict_dir, 'META', 'apexkeys.txt'))
|
|
|
|
self.assertRaises(ValueError, process_apex_keys_apk_certs_common,
|
|
framework_dir, conflict_dir, output_dir,
|
|
set(['product', 'system', 'system_ext']),
|
|
set(['odm', 'vendor']), 'apexkeys.txt')
|
|
|
|
def test_process_apex_keys_apk_certs_HandlesApkCertsSyntax(self):
|
|
output_dir = common.MakeTempDir()
|
|
os.makedirs(os.path.join(output_dir, 'META'))
|
|
|
|
framework_dir = common.MakeTempDir()
|
|
os.makedirs(os.path.join(framework_dir, 'META'))
|
|
os.symlink(
|
|
os.path.join(self.testdata_dir, 'apkcerts_framework.txt'),
|
|
os.path.join(framework_dir, 'META', 'apkcerts.txt'))
|
|
|
|
vendor_dir = common.MakeTempDir()
|
|
os.makedirs(os.path.join(vendor_dir, 'META'))
|
|
os.symlink(
|
|
os.path.join(self.testdata_dir, 'apkcerts_vendor.txt'),
|
|
os.path.join(vendor_dir, 'META', 'apkcerts.txt'))
|
|
|
|
process_apex_keys_apk_certs_common(framework_dir, vendor_dir, output_dir,
|
|
set(['product', 'system', 'system_ext']),
|
|
set(['odm', 'vendor']), 'apkcerts.txt')
|
|
|
|
merged_entries = []
|
|
merged_path = os.path.join(self.testdata_dir, 'apkcerts_merge.txt')
|
|
|
|
with open(merged_path) as f:
|
|
merged_entries = f.read().split('\n')
|
|
|
|
output_entries = []
|
|
output_path = os.path.join(output_dir, 'META', 'apkcerts.txt')
|
|
|
|
with open(output_path) as f:
|
|
output_entries = f.read().split('\n')
|
|
|
|
return self.assertEqual(merged_entries, output_entries)
|
|
|
|
def test_item_list_to_partition_set(self):
|
|
item_list = [
|
|
'META/apexkeys.txt',
|
|
'META/apkcerts.txt',
|
|
'META/filesystem_config.txt',
|
|
'PRODUCT/*',
|
|
'SYSTEM/*',
|
|
'SYSTEM_EXT/*',
|
|
]
|
|
partition_set = item_list_to_partition_set(item_list)
|
|
self.assertEqual(set(['product', 'system', 'system_ext']), partition_set)
|
|
|
|
def test_compile_split_sepolicy(self):
|
|
product_out_dir = common.MakeTempDir()
|
|
|
|
def write_temp_file(path, data=''):
|
|
full_path = os.path.join(product_out_dir, path)
|
|
if not os.path.exists(os.path.dirname(full_path)):
|
|
os.makedirs(os.path.dirname(full_path))
|
|
with open(full_path, 'w') as f:
|
|
f.write(data)
|
|
|
|
write_temp_file(
|
|
'system/etc/vintf/compatibility_matrix.device.xml', """
|
|
<compatibility-matrix>
|
|
<sepolicy>
|
|
<kernel-sepolicy-version>30</kernel-sepolicy-version>
|
|
</sepolicy>
|
|
</compatibility-matrix>""")
|
|
write_temp_file('vendor/etc/selinux/plat_sepolicy_vers.txt', '30.0')
|
|
|
|
write_temp_file('system/etc/selinux/plat_sepolicy.cil')
|
|
write_temp_file('system/etc/selinux/mapping/30.0.cil')
|
|
write_temp_file('product/etc/selinux/mapping/30.0.cil')
|
|
write_temp_file('vendor/etc/selinux/vendor_sepolicy.cil')
|
|
write_temp_file('vendor/etc/selinux/plat_pub_versioned.cil')
|
|
|
|
cmd = compile_split_sepolicy(product_out_dir, {
|
|
'system': 'system',
|
|
'product': 'product',
|
|
'vendor': 'vendor',
|
|
}, os.path.join(product_out_dir, 'policy'))
|
|
self.assertEqual(' '.join(cmd),
|
|
('secilc -m -M true -G -N -c 30 '
|
|
'-o {OTP}/policy -f /dev/null '
|
|
'{OTP}/system/etc/selinux/plat_sepolicy.cil '
|
|
'{OTP}/system/etc/selinux/mapping/30.0.cil '
|
|
'{OTP}/vendor/etc/selinux/vendor_sepolicy.cil '
|
|
'{OTP}/vendor/etc/selinux/plat_pub_versioned.cil '
|
|
'{OTP}/product/etc/selinux/mapping/30.0.cil').format(
|
|
OTP=product_out_dir))
|
|
|
|
def _copy_apex(self, source, output_dir, partition):
|
|
shutil.copy(
|
|
source,
|
|
os.path.join(output_dir, partition, 'apex', os.path.basename(source)))
|
|
|
|
@test_utils.SkipIfExternalToolsUnavailable()
|
|
def test_validate_merged_apex_info(self):
|
|
output_dir = common.MakeTempDir()
|
|
os.makedirs(os.path.join(output_dir, 'SYSTEM/apex'))
|
|
os.makedirs(os.path.join(output_dir, 'VENDOR/apex'))
|
|
|
|
self._copy_apex(
|
|
os.path.join(self.testdata_dir, 'has_apk.apex'), output_dir, 'SYSTEM')
|
|
self._copy_apex(
|
|
os.path.join(test_utils.get_current_dir(),
|
|
'com.android.apex.compressed.v1.capex'), output_dir,
|
|
'VENDOR')
|
|
validate_merged_apex_info(output_dir, ('system', 'vendor'))
|
|
|
|
@test_utils.SkipIfExternalToolsUnavailable()
|
|
def test_validate_merged_apex_info_RaisesOnPackageInMultiplePartitions(self):
|
|
output_dir = common.MakeTempDir()
|
|
os.makedirs(os.path.join(output_dir, 'SYSTEM/apex'))
|
|
os.makedirs(os.path.join(output_dir, 'VENDOR/apex'))
|
|
|
|
same_apex_package = os.path.join(self.testdata_dir, 'has_apk.apex')
|
|
self._copy_apex(same_apex_package, output_dir, 'SYSTEM')
|
|
self._copy_apex(same_apex_package, output_dir, 'VENDOR')
|
|
self.assertRaisesRegexp(
|
|
common.ExternalError,
|
|
'Duplicate APEX packages found in multiple partitions: com.android.wifi',
|
|
validate_merged_apex_info, output_dir, ('system', 'vendor'))
|