e12c862013
Path conflicts could happen when following conditions are met. 1) a java library named "foo" is not installable. 2) a java library named "bar" is installable, and its stem is set to "foo". Then the notice file for 1) becomes foo.jar.txt following its LOCAL_MODULE, while the notice file for 2) becomes foo.jar.txt following its stem. Since the file for 1) is a synthetic one, the actual name isn't important. Avoid the conflict by appending a suffix (_non_installable, but could be anything) to the file name for 1). There still is a chance for the conflict; if the stem for "bar" is set to "foo_non_installable". But practically, the chances are very low. Bug: 139391334 Bug: 143700028 Test: m Change-Id: Id50b30774bbf65cc180baf963a95ea56fe6eb74f
135 lines
5.2 KiB
Makefile
135 lines
5.2 KiB
Makefile
###########################################################
|
|
## Track NOTICE files
|
|
###########################################################
|
|
$(call record-module-type,NOTICE_FILE)
|
|
|
|
ifneq ($(LOCAL_NOTICE_FILE),)
|
|
notice_file:=$(strip $(LOCAL_NOTICE_FILE))
|
|
else
|
|
notice_file:=$(strip $(wildcard $(LOCAL_PATH)/NOTICE))
|
|
endif
|
|
|
|
ifeq ($(LOCAL_MODULE_CLASS),GYP)
|
|
# We ignore NOTICE files for modules of type GYP.
|
|
notice_file :=
|
|
endif
|
|
|
|
ifeq ($(LOCAL_MODULE_CLASS),FAKE)
|
|
# We ignore NOTICE files for modules of type FAKE.
|
|
notice_file :=
|
|
endif
|
|
|
|
# Soong generates stub libraries that don't need NOTICE files
|
|
ifdef LOCAL_NO_NOTICE_FILE
|
|
ifneq ($(LOCAL_MODULE_MAKEFILE),$(SOONG_ANDROID_MK))
|
|
$(call pretty-error,LOCAL_NO_NOTICE_FILE should not be used by Android.mk files)
|
|
endif
|
|
notice_file :=
|
|
endif
|
|
|
|
ifeq ($(LOCAL_MODULE_CLASS),NOTICE_FILES)
|
|
# If this is a NOTICE-only module, we don't include base_rule.mk,
|
|
# so my_prefix is not set at this point.
|
|
ifeq ($(LOCAL_IS_HOST_MODULE),true)
|
|
my_prefix := HOST_
|
|
LOCAL_HOST_PREFIX :=
|
|
else
|
|
my_prefix := TARGET_
|
|
endif
|
|
endif
|
|
|
|
installed_notice_file :=
|
|
|
|
ifdef notice_file
|
|
|
|
ifdef my_register_name
|
|
ALL_MODULES.$(my_register_name).NOTICES := $(ALL_MODULES.$(my_register_name).NOTICES) $(notice_file)
|
|
endif
|
|
|
|
# This relies on the name of the directory in PRODUCT_OUT matching where
|
|
# it's installed on the target - i.e. system, data, etc. This does
|
|
# not work for root and isn't exact, but it's probably good enough for
|
|
# compliance.
|
|
# Includes the leading slash
|
|
ifdef LOCAL_INSTALLED_MODULE
|
|
module_installed_filename := $(patsubst $(PRODUCT_OUT)/%,%,$(LOCAL_INSTALLED_MODULE))
|
|
else
|
|
# This module isn't installable
|
|
ifneq ($(filter STATIC_LIBRARIES RLIB_LIBRARIES PROC_MACRO_LIBRARIES HEADER_LIBRARIES,$(LOCAL_MODULE_CLASS)),)
|
|
# Stick the static libraries with the dynamic libraries.
|
|
# We can't use xxx_OUT_STATIC_LIBRARIES because it points into
|
|
# device-obj or host-obj.
|
|
module_installed_filename := \
|
|
$(patsubst $(PRODUCT_OUT)/%,%,$($(LOCAL_2ND_ARCH_VAR_PREFIX)$(my_prefix)OUT_SHARED_LIBRARIES))/$(notdir $(LOCAL_BUILT_MODULE))
|
|
else ifeq ($(LOCAL_MODULE_CLASS),SHARED_LIBRARIES)
|
|
# Shared modules may be uninstallable(e.g. TARGET_SKIP_CURRENT_VNDK=true)
|
|
module_installed_filename :=
|
|
else
|
|
ifeq ($(LOCAL_MODULE_CLASS),JAVA_LIBRARIES)
|
|
# Stick the static java libraries with the regular java libraries.
|
|
module_leaf := $(notdir $(LOCAL_BUILT_MODULE))
|
|
# javalib.jar is the default name for the build module (and isn't meaningful)
|
|
# If that's what we have, substitute the module name instead. These files
|
|
# aren't included on the device, so this name is synthetic anyway.
|
|
# Extra path "static" is added to try to avoid name conflict between the notice file of
|
|
# this 'uninstallable' Java module and the notice file for another 'installable' Java module
|
|
# whose stem is the same as this module's name.
|
|
ifneq ($(filter javalib.jar,$(module_leaf)),)
|
|
module_leaf := static/$(LOCAL_MODULE).jar
|
|
endif
|
|
module_installed_filename := \
|
|
$(patsubst $(PRODUCT_OUT)/%,%,$($(my_prefix)OUT_JAVA_LIBRARIES))/$(module_leaf)
|
|
else ifeq ($(LOCAL_MODULE_CLASS),ETC)
|
|
# ETC modules may be uninstallable, yet still have a NOTICE file. e.g. apex components
|
|
module_installed_filename :=
|
|
else
|
|
$(error Cannot determine where to install NOTICE file for $(LOCAL_MODULE))
|
|
endif # JAVA_LIBRARIES
|
|
endif # STATIC_LIBRARIES
|
|
endif
|
|
|
|
ifdef module_installed_filename
|
|
|
|
# In case it's actually a host file
|
|
module_installed_filename := $(patsubst $(HOST_OUT)/%,%,$(module_installed_filename))
|
|
module_installed_filename := $(patsubst $(HOST_CROSS_OUT)/%,%,$(module_installed_filename))
|
|
|
|
installed_notice_file := $($(my_prefix)OUT_NOTICE_FILES)/src/$(module_installed_filename).txt
|
|
|
|
$(installed_notice_file): PRIVATE_INSTALLED_MODULE := $(module_installed_filename)
|
|
|
|
$(installed_notice_file): $(notice_file)
|
|
@echo Notice file: $< -- $@
|
|
$(hide) mkdir -p $(dir $@)
|
|
$(hide) cat $< > $@
|
|
|
|
ifdef LOCAL_INSTALLED_MODULE
|
|
# Make LOCAL_INSTALLED_MODULE depend on NOTICE files if they exist
|
|
# libraries so they get installed along with it. Make it an order-only
|
|
# dependency so we don't re-install a module when the NOTICE changes.
|
|
$(LOCAL_INSTALLED_MODULE): | $(installed_notice_file)
|
|
endif
|
|
|
|
# To facilitate collecting NOTICE files for apps_only build,
|
|
# we install the NOTICE file even if a module gets built but not installed,
|
|
# because shared jni libraries won't be installed to the system image.
|
|
ifdef TARGET_BUILD_APPS
|
|
# for static Java libraries, we don't need to even build LOCAL_BUILT_MODULE,
|
|
# but just javalib.jar in the common intermediate dir.
|
|
ifeq ($(LOCAL_MODULE_CLASS),JAVA_LIBRARIES)
|
|
$(intermediates.COMMON)/javalib.jar : | $(installed_notice_file)
|
|
else
|
|
$(LOCAL_BUILT_MODULE): | $(installed_notice_file)
|
|
endif # JAVA_LIBRARIES
|
|
endif # TARGET_BUILD_APPS
|
|
|
|
endif # module_installed_filename
|
|
endif # notice_file
|
|
|
|
# Create a predictable, phony target to build this notice file.
|
|
# Define it even if the notice file doesn't exist so that other
|
|
# modules can depend on it.
|
|
notice_target := NOTICE-$(if \
|
|
$(LOCAL_IS_HOST_MODULE),HOST$(if $(my_host_cross),_CROSS,),TARGET)-$(LOCAL_MODULE_CLASS)-$(LOCAL_MODULE)
|
|
.PHONY: $(notice_target)
|
|
$(notice_target): $(installed_notice_file)
|