platform_build/core/art_config.mk
Jiakai Zhang d6c6e3a9f3 Determine whether to enable userfaultfd GC at build time.
This is determined by:
- a product config flag
- the vendor API level

It is then passed to the device as a system property
"ro.dalvik.vm.enable_uffd_gc".

This change is a no-op change. It doesn't enable userfaultfd GC by
default. OVERRIDE_ENABLE_UFFD_GC=default can be passed to the build
system to enable userfaultfd GC for testing purposes.

Bug: 242553398
Test: -
  1. lunch aosp_redfin-userdebug
  2. OVERRIDE_ENABLE_UFFD_GC=default build/soong/soong_ui.bash --dumpvars-mode --vars=ENABLE_UFFD_GC
  3. See "false" in the output
Test: -
  1. lunch aosp_oriole-userdebug
  2. OVERRIDE_ENABLE_UFFD_GC=default build/soong/soong_ui.bash --dumpvars-mode --vars=ENABLE_UFFD_GC
  3. See "true" in the output
Test: -
  1. lunch aosp_redfin-userdebug
  2. OVERRIDE_ENABLE_UFFD_GC=true build/soong/soong_ui.bash --dumpvars-mode --vars=ENABLE_UFFD_GC
  3. See "true" in the output
Test: -
  1. lunch aosp_oriole-userdebug
  2. OVERRIDE_ENABLE_UFFD_GC=false build/soong/soong_ui.bash --dumpvars-mode --vars=ENABLE_UFFD_GC
  3. See "false" in the output
Change-Id: Ifd6e6cddb502315912ff949619a5b526ae0d73ff
2022-11-17 16:33:44 +00:00

46 lines
1.8 KiB
Makefile

# ART configuration that has to be determined after product config is resolved.
#
# Inputs:
# PRODUCT_ENABLE_UFFD_GC: See comments in build/make/core/product.mk.
# OVERRIDE_ENABLE_UFFD_GC: Overrides PRODUCT_ENABLE_UFFD_GC. Can be passed from the commandline for
# debugging purposes.
# BOARD_API_LEVEL: See comments in build/make/core/main.mk.
# BOARD_SHIPPING_API_LEVEL: See comments in build/make/core/main.mk.
# PRODUCT_SHIPPING_API_LEVEL: See comments in build/make/core/product.mk.
#
# Outputs:
# ENABLE_UFFD_GC: Whether to use userfaultfd GC.
config_enable_uffd_gc := \
$(firstword $(OVERRIDE_ENABLE_UFFD_GC) $(PRODUCT_ENABLE_UFFD_GC))
ifeq (,$(filter-out default,$(config_enable_uffd_gc)))
ENABLE_UFFD_GC := true
# Disable userfaultfd GC if the device doesn't support it (i.e., if
# `min(ro.board.api_level ?? ro.board.first_api_level ?? MAX_VALUE,
# ro.product.first_api_level ?? ro.build.version.sdk ?? MAX_VALUE) < 31`)
# This logic aligns with how `ro.vendor.api_level` is calculated in
# `system/core/init/property_service.cpp`.
# We omit the check on `ro.build.version.sdk` here because we are on the latest build system.
board_api_level := $(firstword $(BOARD_API_LEVEL) $(BOARD_SHIPPING_API_LEVEL))
ifneq (,$(board_api_level))
ifeq (true,$(call math_lt,$(board_api_level),31))
ENABLE_UFFD_GC := false
endif
endif
ifneq (,$(PRODUCT_SHIPPING_API_LEVEL))
ifeq (true,$(call math_lt,$(PRODUCT_SHIPPING_API_LEVEL),31))
ENABLE_UFFD_GC := false
endif
endif
else ifeq (true,$(config_enable_uffd_gc))
ENABLE_UFFD_GC := true
else ifeq (false,$(config_enable_uffd_gc))
ENABLE_UFFD_GC := false
else
$(error Unknown PRODUCT_ENABLE_UFFD_GC value: $(config_enable_uffd_gc))
endif
ADDITIONAL_PRODUCT_PROPERTIES += ro.dalvik.vm.enable_uffd_gc=$(ENABLE_UFFD_GC)