0219e9292e
Currently, prebuilt binaries with debug symbols are installed unstripped. There are only a few of prebuilt shared library (that I'm trying to fix), so I can do this manually by making intermediate target and applying TARGET_STRIP, each of them, one by one. But dynamic_binary.mk has more features than stripping binaries (like copying unstripped binaries to symbols directory) and if I do it manually, they will lose all the benefits. Note that this doesn't change anything when LOCAL_STRIP_MODULE is not set. I actually tried to force strip every BUILD_PREBUILT'ed modules, but there were a few problems: - Some packages are not installed (i.e. not in PRODUCT_PACAKGES) but are built (i.e. in ALL_MODULES). And some of them are built in spite that they do not have appropriate prebuilt shared library for TARGET_ARCH. Stripping them causes "unknown format". - Some prebuilt modules set LOCAL_MODULE_CLASS incorrectly. Example is default.supp of external/valgrind/main, which should be ETC, not SHARED_LIBRARY. Both are better fixed, but I concluded that it's better to be conservative. Bug: 4585734 Change-Id: If71723b1d76007d45b02429ea5161a8265dd5b6d
142 lines
5 KiB
Makefile
142 lines
5 KiB
Makefile
###########################################################
|
|
## Standard rules for copying files that are prebuilt
|
|
##
|
|
## Additional inputs from base_rules.make:
|
|
## None.
|
|
##
|
|
###########################################################
|
|
|
|
ifneq ($(LOCAL_PREBUILT_LIBS),)
|
|
$(error dont use LOCAL_PREBUILT_LIBS anymore LOCAL_PATH=$(LOCAL_PATH))
|
|
endif
|
|
ifneq ($(LOCAL_PREBUILT_EXECUTABLES),)
|
|
$(error dont use LOCAL_PREBUILT_EXECUTABLES anymore LOCAL_PATH=$(LOCAL_PATH))
|
|
endif
|
|
ifneq ($(LOCAL_PREBUILT_JAVA_LIBRARIES),)
|
|
$(error dont use LOCAL_PREBUILT_JAVA_LIBRARIES anymore LOCAL_PATH=$(LOCAL_PATH))
|
|
endif
|
|
|
|
ifneq ($(filter APPS,$(LOCAL_MODULE_CLASS)),)
|
|
ifeq (true,$(WITH_DEXPREOPT))
|
|
ifeq (,$(TARGET_BUILD_APPS))
|
|
ifndef LOCAL_DEX_PREOPT
|
|
LOCAL_DEX_PREOPT := true
|
|
endif
|
|
endif
|
|
endif
|
|
endif
|
|
|
|
ifeq ($(LOCAL_STRIP_MODULE),true)
|
|
ifdef LOCAL_IS_HOST_MODULE
|
|
$(error Cannot strip host module LOCAL_PATH=$(LOCAL_PATH))
|
|
endif
|
|
ifeq ($(filter SHARED_LIBRARIES EXECUTABLES,$(LOCAL_MODULE_CLASS)),)
|
|
$(error Can strip only shared libraries or executables LOCAL_PATH=$(LOCAL_PATH))
|
|
endif
|
|
ifneq ($(LOCAL_PREBUILT_STRIP_COMMENTS),)
|
|
$(error Cannot strip scripts LOCAL_PATH=$(LOCAL_PATH))
|
|
endif
|
|
include $(BUILD_SYSTEM)/dynamic_binary.mk
|
|
built_module := $(linked_module)
|
|
else
|
|
include $(BUILD_SYSTEM)/base_rules.mk
|
|
built_module := $(LOCAL_BUILT_MODULE)
|
|
endif
|
|
|
|
# Deal with the OSX library timestamp issue when installing
|
|
# a prebuilt simulator library.
|
|
ifneq ($(filter STATIC_LIBRARIES SHARED_LIBRARIES,$(LOCAL_MODULE_CLASS)),)
|
|
prebuilt_module_is_a_library := true
|
|
else
|
|
prebuilt_module_is_a_library :=
|
|
endif
|
|
|
|
PACKAGES.$(LOCAL_MODULE).OVERRIDES := $(strip $(LOCAL_OVERRIDES_PACKAGES))
|
|
|
|
# Ensure that prebuilt .apks have been aligned.
|
|
ifneq ($(filter APPS,$(LOCAL_MODULE_CLASS)),)
|
|
ifeq ($(LOCAL_DEX_PREOPT),true)
|
|
# Make sure the boot jars get dexpreopt-ed first
|
|
$(built_module): $(DEXPREOPT_BOOT_ODEXS) | $(DEXPREOPT) $(DEXOPT) $(AAPT)
|
|
endif
|
|
$(built_module) : $(LOCAL_PATH)/$(LOCAL_SRC_FILES) | $(ZIPALIGN)
|
|
$(transform-prebuilt-to-target-with-zipalign)
|
|
ifeq ($(LOCAL_DEX_PREOPT),true)
|
|
$(hide) rm -f $(patsubst %.apk,%.odex,$@)
|
|
$(call dexpreopt-one-file,$@,$(patsubst %.apk,%.odex,$@))
|
|
$(call dexpreopt-remove-classes.dex,$@)
|
|
|
|
built_odex := $(basename $(built_module)).odex
|
|
$(built_odex): $(built_module)
|
|
endif
|
|
else
|
|
ifneq ($(LOCAL_PREBUILT_STRIP_COMMENTS),)
|
|
$(built_module) : $(LOCAL_PATH)/$(LOCAL_SRC_FILES)
|
|
$(transform-prebuilt-to-target-strip-comments)
|
|
else
|
|
$(built_module) : $(LOCAL_PATH)/$(LOCAL_SRC_FILES) | $(ACP)
|
|
$(transform-prebuilt-to-target)
|
|
endif
|
|
endif
|
|
|
|
ifeq ($(LOCAL_IS_HOST_MODULE)$(LOCAL_MODULE_CLASS),JAVA_LIBRARIES)
|
|
# for target java libraries, the LOCAL_BUILT_MODULE is in a product-specific dir,
|
|
# while the deps should be in the common dir, so we make a copy in the common dir.
|
|
# For nonstatic library, $(common_javalib_jar) is the dependency file,
|
|
# while $(common_classes_jar) is used to link.
|
|
common_classes_jar := $(call intermediates-dir-for,JAVA_LIBRARIES,$(LOCAL_MODULE),,COMMON)/classes.jar
|
|
common_javalib_jar := $(dir $(common_classes_jar))javalib.jar
|
|
|
|
$(common_classes_jar) : $(LOCAL_PATH)/$(LOCAL_SRC_FILES) | $(ACP)
|
|
$(transform-prebuilt-to-target)
|
|
|
|
$(common_javalib_jar) : $(common_classes_jar) | $(ACP)
|
|
$(transform-prebuilt-to-target)
|
|
|
|
# make sure the classes.jar and javalib.jar are built before $(LOCAL_BUILT_MODULE)
|
|
$(built_module) : $(common_javalib_jar)
|
|
endif # TARGET JAVA_LIBRARIES
|
|
|
|
ifeq ($(LOCAL_CERTIFICATE),EXTERNAL)
|
|
# The magic string "EXTERNAL" means this package will be signed with
|
|
# the test key throughout the build process, but we expect the final
|
|
# package to be signed with a different key.
|
|
#
|
|
# This can be used for packages where we don't have access to the
|
|
# keys, but want the package to be predexopt'ed.
|
|
LOCAL_CERTIFICATE := testkey
|
|
PACKAGES.$(LOCAL_MODULE).EXTERNAL_KEY := 1
|
|
endif
|
|
ifeq ($(LOCAL_CERTIFICATE),)
|
|
ifneq ($(filter APPS,$(LOCAL_MODULE_CLASS)),)
|
|
# It is now a build error to add a prebuilt .apk without
|
|
# specifying a key for it.
|
|
$(error No LOCAL_CERTIFICATE specified for prebuilt "$(LOCAL_SRC_FILES)")
|
|
endif
|
|
else ifeq ($(LOCAL_CERTIFICATE),PRESIGNED)
|
|
# The magic string "PRESIGNED" means this package is already checked
|
|
# signed with its release key.
|
|
#
|
|
# By setting .CERTIFICATE but not .PRIVATE_KEY, this package will be
|
|
# mentioned in apkcerts.txt (with certificate set to "PRESIGNED")
|
|
# but the dexpreopt process will not try to re-sign the app.
|
|
PACKAGES.$(LOCAL_MODULE).CERTIFICATE := PRESIGNED
|
|
PACKAGES := $(PACKAGES) $(LOCAL_MODULE)
|
|
else
|
|
# If this is not an absolute certificate, assign it to a generic one.
|
|
ifeq ($(dir $(strip $(LOCAL_CERTIFICATE))),./)
|
|
LOCAL_CERTIFICATE := $(SRC_TARGET_DIR)/product/security/$(LOCAL_CERTIFICATE)
|
|
endif
|
|
|
|
PACKAGES.$(LOCAL_MODULE).PRIVATE_KEY := $(LOCAL_CERTIFICATE).pk8
|
|
PACKAGES.$(LOCAL_MODULE).CERTIFICATE := $(LOCAL_CERTIFICATE).x509.pem
|
|
PACKAGES := $(PACKAGES) $(LOCAL_MODULE)
|
|
endif
|
|
|
|
ifneq ($(prebuilt_module_is_a_library),)
|
|
ifneq ($(LOCAL_IS_HOST_MODULE),)
|
|
$(transform-host-ranlib-copy-hack)
|
|
else
|
|
$(transform-ranlib-copy-hack)
|
|
endif
|
|
endif
|