17315c2eda
If we don't have any new dependencies, or we never set up the check_elf_files.timestamp rule, don't create an empty one now. There were >7000 of these unused and empty rules in my AOSP aosp_cf_x86_phone build. This was initially brought to my attention by the new checks in https://github.com/google/kati/pull/189 Test: diff out/build-aosp_cf_x86_phone.ninja, only removed phony rules Change-Id: Ia43cbbd04df4a01d2182b14e3ccbe5d5ecbcabad
51 lines
2.2 KiB
Makefile
51 lines
2.2 KiB
Makefile
# Check the correctness of the prebuilt ELF files
|
|
#
|
|
# This check ensures that DT_SONAME matches with the filename, DT_NEEDED
|
|
# matches the shared libraries specified in LOCAL_SHARED_LIBRARIES, and all
|
|
# undefined symbols in the prebuilt binary can be found in one of the shared
|
|
# libraries specified in LOCAL_SHARED_LIBRARIES.
|
|
#
|
|
# Inputs:
|
|
# - LOCAL_ALLOW_UNDEFINED_SYMBOLS
|
|
# - LOCAL_BUILT_MODULE
|
|
# - LOCAL_IS_HOST_MODULE
|
|
# - LOCAL_MODULE_CLASS
|
|
# - intermediates
|
|
# - my_installed_module_stem
|
|
# - my_prebuilt_src_file
|
|
# - my_check_elf_file_shared_lib_files
|
|
|
|
ifndef LOCAL_IS_HOST_MODULE
|
|
ifneq ($(filter $(LOCAL_MODULE_CLASS),SHARED_LIBRARIES EXECUTABLES NATIVE_TESTS),)
|
|
check_elf_files_stamp := $(intermediates)/check_elf_files.timestamp
|
|
$(check_elf_files_stamp): PRIVATE_SONAME := $(if $(filter $(LOCAL_MODULE_CLASS),SHARED_LIBRARIES),$(my_installed_module_stem))
|
|
$(check_elf_files_stamp): PRIVATE_ALLOW_UNDEFINED_SYMBOLS := $(LOCAL_ALLOW_UNDEFINED_SYMBOLS)
|
|
# PRIVATE_SHARED_LIBRARY_FILES are file paths to built shared libraries.
|
|
# In addition to $(my_check_elf_file_shared_lib_files), some file paths are
|
|
# added by `resolve-shared-libs-for-elf-file-check` from `core/main.mk`.
|
|
$(check_elf_files_stamp): PRIVATE_SHARED_LIBRARY_FILES := $(my_check_elf_file_shared_lib_files)
|
|
$(check_elf_files_stamp): $(my_prebuilt_src_file) $(my_check_elf_file_shared_lib_files) $(CHECK_ELF_FILE) $(LLVM_READOBJ)
|
|
@echo Check prebuilt ELF binary: $<
|
|
$(hide) mkdir -p $(dir $@)
|
|
$(hide) rm -f $@
|
|
$(hide) $(CHECK_ELF_FILE) \
|
|
--skip-bad-elf-magic \
|
|
--skip-unknown-elf-machine \
|
|
$(if $(PRIVATE_SONAME),--soname $(PRIVATE_SONAME)) \
|
|
$(foreach l,$(PRIVATE_SHARED_LIBRARY_FILES),--shared-lib $(l)) \
|
|
$(if $(PRIVATE_ALLOW_UNDEFINED_SYMBOLS),--allow-undefined-symbols) \
|
|
--llvm-readobj=$(LLVM_READOBJ) \
|
|
$<
|
|
$(hide) touch $@
|
|
|
|
CHECK_ELF_FILES.$(check_elf_files_stamp) := 1
|
|
|
|
ifneq ($(strip $(LOCAL_CHECK_ELF_FILES)),false)
|
|
ifneq ($(strip $(BUILD_BROKEN_PREBUILT_ELF_FILES)),true)
|
|
$(LOCAL_BUILT_MODULE): $(check_elf_files_stamp)
|
|
check-elf-files: $(check_elf_files_stamp)
|
|
endif # BUILD_BROKEN_PREBUILT_ELF_FILES
|
|
endif # LOCAL_CHECK_ELF_FILES
|
|
|
|
endif # SHARED_LIBRARIES, EXECUTABLES, NATIVE_TESTS
|
|
endif # !LOCAL_IS_HOST_MODULE
|