2015-01-23 23:15:10 +01:00
|
|
|
// Copyright 2014 Google Inc. All rights reserved.
|
|
|
|
//
|
|
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
// you may not use this file except in compliance with the License.
|
|
|
|
// You may obtain a copy of the License at
|
|
|
|
//
|
|
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
//
|
|
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
// See the License for the specific language governing permissions and
|
|
|
|
// limitations under the License.
|
|
|
|
|
2014-10-28 06:34:56 +01:00
|
|
|
package bootstrap
|
|
|
|
|
|
|
|
import (
|
|
|
|
"bufio"
|
|
|
|
"errors"
|
|
|
|
"fmt"
|
|
|
|
"os"
|
|
|
|
"path/filepath"
|
|
|
|
"strings"
|
|
|
|
"syscall"
|
2015-11-19 01:01:01 +01:00
|
|
|
|
|
|
|
"github.com/google/blueprint"
|
2014-10-28 06:34:56 +01:00
|
|
|
)
|
|
|
|
|
|
|
|
const logFileName = ".ninja_log"
|
|
|
|
|
2017-07-20 07:43:30 +02:00
|
|
|
// removeAbandonedFilesUnder removes any files that appear in the Ninja log, and
|
|
|
|
// are prefixed with one of the `under` entries, but that are not currently
|
Run globs during earlier bootstrap phases
Instead of sometimes re-running minibp/the primary builder during the
next phase, run bpglob earlier to check dependencies.
We've run into issues where the environment is slightly different
between bootstrapping phase and the main build phase. It's also a
problem because our primary builder (Soong) exports information used by
another tool (Kati) that runs in between the bootstrapping phases and
the main phase. When Soong would run in the main phase, it could get out
of sync, and would require the build to be run again.
To do this, add a "subninja" include a build-globs.ninja file to each
build.ninja file. The first time, this will be an empty file, but we'll
always run minibp / the primary builder anyway. When the builder runs,
in addition to writing a dependency file, write out the
build-globs.ninja file with the rules to run bpglob.
Since bpglob may need to be run very early, before it would normally be
built, build it with microfactory.
Change-Id: I89fcd849a8729e892f163d40060ab90b5d4dfa5d
2018-07-06 06:56:59 +02:00
|
|
|
// build targets, or in `exempt`
|
2017-07-20 07:43:30 +02:00
|
|
|
func removeAbandonedFilesUnder(ctx *blueprint.Context, config *Config,
|
Run globs during earlier bootstrap phases
Instead of sometimes re-running minibp/the primary builder during the
next phase, run bpglob earlier to check dependencies.
We've run into issues where the environment is slightly different
between bootstrapping phase and the main build phase. It's also a
problem because our primary builder (Soong) exports information used by
another tool (Kati) that runs in between the bootstrapping phases and
the main phase. When Soong would run in the main phase, it could get out
of sync, and would require the build to be run again.
To do this, add a "subninja" include a build-globs.ninja file to each
build.ninja file. The first time, this will be an empty file, but we'll
always run minibp / the primary builder anyway. When the builder runs,
in addition to writing a dependency file, write out the
build-globs.ninja file with the rules to run bpglob.
Since bpglob may need to be run very early, before it would normally be
built, build it with microfactory.
Change-Id: I89fcd849a8729e892f163d40060ab90b5d4dfa5d
2018-07-06 06:56:59 +02:00
|
|
|
srcDir string, under, exempt []string) error {
|
2017-07-20 07:43:30 +02:00
|
|
|
|
|
|
|
if len(under) == 0 {
|
|
|
|
return nil
|
|
|
|
}
|
2014-11-09 20:58:40 +01:00
|
|
|
|
2015-11-19 01:01:01 +01:00
|
|
|
ninjaBuildDir, err := ctx.NinjaBuildDir()
|
|
|
|
if err != nil {
|
|
|
|
return err
|
2014-10-28 06:34:56 +01:00
|
|
|
}
|
|
|
|
|
2014-11-09 20:58:40 +01:00
|
|
|
targetRules, err := ctx.AllTargets()
|
2014-10-28 06:34:56 +01:00
|
|
|
if err != nil {
|
2014-11-09 20:58:40 +01:00
|
|
|
return fmt.Errorf("error determining target list: %s", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
replacer := strings.NewReplacer(
|
|
|
|
"@@SrcDir@@", srcDir,
|
Simplify bootstrap
tl;dr: Read if you don't use the wrapper or use SKIP_NINJA
Previously, we were relying on the ninja behavior of restarting the
build when the build.ninja file was updated to switch between different
bootstrap stages. But that means that every step that could produce a
build.ninja must pass in order to switch to a different stage. That
wasn't a big problem when we had a two stage build -- there was very
little that could fail in the second stage before we chose to go back to
the first stage. But when we had a three stage build, it was possible to
get into a state (usually during development) where you were in the
second stage, but the build was failing because the first stage needed
to be run. This was fixed in d79f1af7423e0ef7a13573efdae5100a57fabc82
by adding a wrapper that always started building at the first stage.
But this kept all of the complexity of using ninja restarts without any
of the benefits, so this change removes that complexity and just runs
each stage sequentially in the wrapper. So the wrapper is now required.
Since we're no longer going through choosestage, we can also skip the
template parsing for the later stages that don't need to be templated --
this can save a couple of seconds for large files.
In addition to all of the above, this also lets Soong reduce the number
of times the main ninja file is loaded. We had been running the wrapper
once (3 stages), then running ninja again after combining the
Soong-generated build.ninja with the Kati-generated build.ninja. This
change lets us removing the intermediate parsing of Soong's build.ninja,
so that we only execute ninja 3 times per build. It also lets us have
dependencies on pools or rules from Kati in the primary builder, since
we're never executing the main build.ninja without the Kati build.ninja.
The wrapper has a new option, NINJA to provide the path to ninja. This
used to be hardcoded to `ninja`, and will still default to that. But
we'll be running the first two bootstrap stages with $NINJA even if
SKIP_NINJA is set.
The wrapper passes "-w dupbuild=err" to ninja now -- this really should
always be turned on if you care about reliable builds.
Change-Id: I6f656b74eb3d064b8b9e69d1d6dac1129d72b747
2016-08-13 21:42:11 +02:00
|
|
|
"@@BuildDir@@", BuildDir)
|
2015-11-19 01:01:01 +01:00
|
|
|
ninjaBuildDir = replacer.Replace(ninjaBuildDir)
|
2014-11-09 20:58:40 +01:00
|
|
|
targets := make(map[string]bool)
|
|
|
|
for target := range targetRules {
|
|
|
|
replacedTarget := replacer.Replace(target)
|
2015-07-14 03:11:49 +02:00
|
|
|
targets[filepath.Clean(replacedTarget)] = true
|
2014-10-28 06:34:56 +01:00
|
|
|
}
|
Run globs during earlier bootstrap phases
Instead of sometimes re-running minibp/the primary builder during the
next phase, run bpglob earlier to check dependencies.
We've run into issues where the environment is slightly different
between bootstrapping phase and the main build phase. It's also a
problem because our primary builder (Soong) exports information used by
another tool (Kati) that runs in between the bootstrapping phases and
the main phase. When Soong would run in the main phase, it could get out
of sync, and would require the build to be run again.
To do this, add a "subninja" include a build-globs.ninja file to each
build.ninja file. The first time, this will be an empty file, but we'll
always run minibp / the primary builder anyway. When the builder runs,
in addition to writing a dependency file, write out the
build-globs.ninja file with the rules to run bpglob.
Since bpglob may need to be run very early, before it would normally be
built, build it with microfactory.
Change-Id: I89fcd849a8729e892f163d40060ab90b5d4dfa5d
2018-07-06 06:56:59 +02:00
|
|
|
for _, target := range exempt {
|
|
|
|
replacedTarget := replacer.Replace(target)
|
|
|
|
targets[filepath.Clean(replacedTarget)] = true
|
|
|
|
}
|
2014-10-28 06:34:56 +01:00
|
|
|
|
2017-07-20 07:43:30 +02:00
|
|
|
filePaths, err := parseNinjaLog(ninjaBuildDir, under)
|
2014-10-28 06:34:56 +01:00
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, filePath := range filePaths {
|
2014-11-09 20:58:40 +01:00
|
|
|
isTarget := targets[filePath]
|
2014-10-28 06:34:56 +01:00
|
|
|
if !isTarget {
|
2019-12-17 22:12:35 +01:00
|
|
|
err = removeFileAndEmptyDirs(absolutePath(filePath))
|
2014-10-28 06:34:56 +01:00
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2017-07-20 07:43:30 +02:00
|
|
|
func parseNinjaLog(ninjaBuildDir string, under []string) ([]string, error) {
|
2015-11-19 01:01:01 +01:00
|
|
|
logFilePath := filepath.Join(ninjaBuildDir, logFileName)
|
2014-10-28 06:34:56 +01:00
|
|
|
logFile, err := os.Open(logFilePath)
|
|
|
|
if err != nil {
|
|
|
|
if os.IsNotExist(err) {
|
|
|
|
return nil, nil
|
|
|
|
}
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
defer logFile.Close()
|
|
|
|
|
|
|
|
scanner := bufio.NewScanner(logFile)
|
|
|
|
|
|
|
|
// Check that the first line indicates that this is a Ninja log version 5
|
|
|
|
const expectedFirstLine = "# ninja log v5"
|
|
|
|
if !scanner.Scan() || scanner.Text() != expectedFirstLine {
|
|
|
|
return nil, errors.New("unrecognized ninja log format")
|
|
|
|
}
|
|
|
|
|
|
|
|
var filePaths []string
|
|
|
|
for scanner.Scan() {
|
|
|
|
line := scanner.Text()
|
|
|
|
if strings.HasPrefix(line, "#") {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
const fieldSeperator = "\t"
|
|
|
|
fields := strings.Split(line, fieldSeperator)
|
|
|
|
|
|
|
|
const precedingFields = 3
|
|
|
|
const followingFields = 1
|
|
|
|
|
|
|
|
if len(fields) < precedingFields+followingFields+1 {
|
|
|
|
return nil, fmt.Errorf("log entry has too few fields: %q", line)
|
|
|
|
}
|
|
|
|
|
|
|
|
start := precedingFields
|
|
|
|
end := len(fields) - followingFields
|
|
|
|
filePath := strings.Join(fields[start:end], fieldSeperator)
|
|
|
|
|
2017-07-20 07:43:30 +02:00
|
|
|
for _, dir := range under {
|
|
|
|
if strings.HasPrefix(filePath, dir) {
|
|
|
|
filePaths = append(filePaths, filePath)
|
|
|
|
break
|
|
|
|
}
|
|
|
|
}
|
2014-10-28 06:34:56 +01:00
|
|
|
}
|
|
|
|
if err := scanner.Err(); err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
|
|
|
|
return filePaths, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func removeFileAndEmptyDirs(path string) error {
|
|
|
|
err := os.Remove(path)
|
|
|
|
if err != nil {
|
|
|
|
if os.IsNotExist(err) {
|
|
|
|
return nil
|
|
|
|
}
|
2015-02-25 02:13:12 +01:00
|
|
|
pathErr := err.(*os.PathError)
|
|
|
|
switch pathErr.Err {
|
2015-11-18 01:18:13 +01:00
|
|
|
case syscall.ENOTEMPTY, syscall.EEXIST, syscall.ENOTDIR:
|
2015-02-25 02:13:12 +01:00
|
|
|
return nil
|
|
|
|
}
|
2014-10-28 06:34:56 +01:00
|
|
|
return err
|
|
|
|
}
|
2015-02-12 19:24:29 +01:00
|
|
|
fmt.Printf("removed old ninja-created file %s because it has no rule to generate it\n", path)
|
2014-10-28 06:34:56 +01:00
|
|
|
|
|
|
|
path, err = filepath.Abs(path)
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
cwd, err := os.Getwd()
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
for dir := filepath.Dir(path); dir != cwd; dir = filepath.Dir(dir) {
|
|
|
|
err = os.Remove(dir)
|
|
|
|
if err != nil {
|
|
|
|
pathErr := err.(*os.PathError)
|
|
|
|
switch pathErr.Err {
|
|
|
|
case syscall.ENOTEMPTY, syscall.EEXIST:
|
|
|
|
// We've come to a nonempty directory, so we're done.
|
|
|
|
return nil
|
|
|
|
default:
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|