Merge "Add a stronger wording to don't use ModuleFromName"

This commit is contained in:
Treehugger Robot 2023-04-05 04:03:15 +00:00 committed by Gerrit Code Review
commit 44baecd513

View file

@ -300,6 +300,9 @@ type BaseModuleContext interface {
// There are no guarantees about which variant of the module will be returned. // There are no guarantees about which variant of the module will be returned.
// Prefer retrieving the module using GetDirectDep or a visit function, when possible, as // Prefer retrieving the module using GetDirectDep or a visit function, when possible, as
// this will guarantee the appropriate module-variant dependency is returned. // this will guarantee the appropriate module-variant dependency is returned.
//
// WARNING: This should _only_ be used within the context of bp2build, where variants and
// dependencies are not created.
ModuleFromName(name string) (Module, bool) ModuleFromName(name string) (Module, bool)
// OtherModuleDependencyVariantExists returns true if a module with the // OtherModuleDependencyVariantExists returns true if a module with the